Anand B Pillai [EMAIL PROTECTED] added the comment:
Hi Gregory,
Let me know if I can help out some way in testing the #3797
patches on various platforms.
Regards,
--Anand
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3492
Gregory P. Smith [EMAIL PROTECTED] added the comment:
fixed in r66266 along with #3790.
leaving this open and assigned to me while i investigate the other uses
of ByteArray in the Modules/ directory.
IMHO, its fine if we fix any remaining bytearray uses up for rc2.
--
resolution: -
Changes by Gregory P. Smith [EMAIL PROTECTED]:
--
priority: release blocker - deferred blocker
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3492
___
Gregory P. Smith [EMAIL PROTECTED] added the comment:
issue #3797 has been opened to track the other files mentioned.
--
status: open - closed
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3492
Nick Coghlan [EMAIL PROTECTED] added the comment:
Patch looks good to me (I've only looked at the patch - not the other
possible misuses of PyByteArray_ that Amaury noted)
--
nosy: +ncoghlan
___
Python tracker [EMAIL PROTECTED]
Changes by Jesús Cea Avión [EMAIL PROTECTED]:
--
nosy: +jcea
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3492
___
___
Python-bugs-list mailing list
Antoine Pitrou [EMAIL PROTECTED] added the comment:
We must definitely clean up other uses of bytearray in the extension
modules - see #3790 for an example.
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3492
Antoine Pitrou [EMAIL PROTECTED] added the comment:
+1 for committing.
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3492
___
___
Python-bugs-list mailing list
Gregory P. Smith [EMAIL PROTECTED] added the comment:
Correct, zipimport required fixing in order for this to work. The newly
attached zlib-and-zipimport-gps01 patch.
review at http://codereview.appspot.com/4454
I haven't had a chance to look at the other modules Amaury mentioned but
on
Anand B Pillai [EMAIL PROTECTED] added the comment:
Does py3k list/barry have this bug in their radar for rc2 ?
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3492
___
Anand B Pillai [EMAIL PROTECTED] added the comment:
On Thu, Sep 4, 2008 at 4:59 PM, Amaury Forgeot d'Arc
[EMAIL PROTECTED] wrote:
Amaury Forgeot d'Arc [EMAIL PROTECTED] added the comment:
Two remarks:
1. Some functions in Modules/zipimport.c (get_data) will now receive
PyBytes, but
Gregory P. Smith [EMAIL PROTECTED] added the comment:
this is a very simple patch and makes sense to me. marking it a release
blocker and asking about it on the mailing list. if anyone disagrees
with this one please speak up.
in general IO input functions elsewhere return bytes(). zlib
Anand B Pillai [EMAIL PROTECTED] added the comment:
Thanks. Will this make into beta3 ?
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3492
___
___
Antoine Pitrou [EMAIL PROTECTED] added the comment:
Any updates ? The py3k list is also very silent since the
week-end...Thanks!
Your two patches look good, I suppose either Alexandre or I will commit
them soon.
You shouldn't to worry when you don't get a reply immediately, people
react
Anand B Pillai [EMAIL PROTECTED] added the comment:
Any updates ? The py3k list is also very silent since the week-end...Thanks!
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3492
___
Anand B Pillai [EMAIL PROTECTED] added the comment:
Hi, I have a patch ready for this to be applied to zlibmodule.c. The
patch is attached. I have tested it and it is working fine.
--
keywords: +patch
Added file: http://bugs.python.org/file11047/zlibmodule.patch
Alexandre Vassalotti [EMAIL PROTECTED] added the comment:
Could you submit unified diff--i.e., with 'diff -u' or 'svn diff'?
Also, could you add tests for this fix?
--
nosy: +alexandre.vassalotti
___
Python tracker [EMAIL PROTECTED]
Anand B Pillai [EMAIL PROTECTED] added the comment:
Uploading svn diff for zlibmodule.c. Btw, how do I add unit tests for a
fix ? You want me to create a simple test file and upload it here, or is
there a standard procedure for this ? Please advise.
Added file:
Anand B Pillai [EMAIL PROTECTED] added the comment:
Ok. I added two tests for checking the type of the returned object for
zlib.compress and zlib.decompress in test_zlib.py in the py3k branch.
Btw, my code uses assertEqual(type(...), bytes). Is this the proper way
of type checking in py3k ? I
New submission from Anand B Pillai [EMAIL PROTECTED]:
import zlib
s='This is a string'
sc=zlib.compress(s)
sc
bytearray(b'x\x9c\x0b\xc9\xc8,V\x00\xa2D\x85\xe2\x92\xa2\xcc\xbct\x00/\xc2\x05\xcd')
zlib.decompress(sc)
bytearray(b'This is a string')
This is wrong behavior as compress
20 matches
Mail list logo
