[issue34972] json dump silently converts int keys to string

[Stuart Bishop]

Stuart Bishop  added the comment:

(sorry, my example is normal Python behavior. {1:1, 1.0:2} == {1:2} , {1.0:1} 
== {1:1} )

--
nosy: +stub

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34972] json dump silently converts int keys to string

[Stub]

Stub  added the comment:

Similarly, keys can be lost entirely:

>>> json.dumps({1:2, 1.0:3})
'{"1": 3}'

--
nosy: +Stub2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34972] json dump silently converts int keys to string

[Facundo Batista]

Facundo Batista  added the comment:

I understand (and agree with) the merits of automatically converting the int to 
str when dumping to a string.

However, this result really surprised me:

>>> json.dumps({1:2, "1":3})
'{"1": 2, "1": 3}'

Is it a valid JSON?

--
nosy: +facundobatista

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34972] json dump silently converts int keys to string

[Eric V. Smith]

Change by Eric V. Smith :


--
resolution:  -> not a bug

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34972] json dump silently converts int keys to string

[My-Tien Nguyen]

Change by My-Tien Nguyen :


--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34972] json dump silently converts int keys to string

[My-Tien Nguyen]

My-Tien Nguyen  added the comment:

Sure, I can do that, but wanted to propose this regardless. I guess this is a 
disagreement on a language design level.
As a proponent of strong typing I wouldn’t have allowed non-string keys in the 
first place, and if they are allowed I would warn about conversion. This is 
also more aligned with the “explicit is better than implicit” principle.

--
resolution: not a bug -> 
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34972] json dump silently converts int keys to string

[Steve Dower]

Steve Dower  added the comment:

Agreed with Eric. json.dump needs to produce valid JSON, which requires keys to 
be strings.

Try using pickle if you need to preserve full Python semantics.

--
nosy: +steve.dower
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34972] json dump silently converts int keys to string

[Eric V. Smith]

Eric V. Smith  added the comment:

I can't think of another place where we issue a warning for anything similar. 
I'm opposed to any changes here: it's clearly documented behavior.

It's like being surprised .ini files convert to strings: it's just how that 
format works.

--
nosy: +eric.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34972] json dump silently converts int keys to string

[My-Tien Nguyen]

My-Tien Nguyen  added the comment:

I don’t think, “other languages do that too” is a good argument here. This 
would apply if behaving differently would break user expectation. But here we 
would do nothing more than explicitly inform the user of a relevant operation. 
If they already expected that behaviour, they can disregard the warning.

I don’t see how `parse_int`would help me here, I would need a `parse_str=int`, 
but then it would try to parse every string, and I don’t see the use case for 
that.

I would suggest a warning similar to this:

--- json/encoder.py
+++ json/encoder.py
@@ -1,6 +1,7 @@
 """Implementation of JSONEncoder
 """
 import re
+import warnings
 
 try:
 from _json import encode_basestring_ascii as c_encode_basestring_ascii
@@ -353,7 +354,9 @@
 items = sorted(dct.items(), key=lambda kv: kv[0])
 else:
 items = dct.items()
+non_str_key = False
 for key, value in items:
+non_str_key = non_str_key or not isinstance(key, str)
 if isinstance(key, str):
 pass
 # JavaScript is weakly typed for these, so it makes sense to
@@ -403,6 +406,8 @@
 else:
 chunks = _iterencode(value, _current_indent_level)
 yield from chunks
+if non_str_key:
+warnings.warn("Encountered non-string key(s), converted to 
string.", RuntimeWarning)
 if newline_indent is not None:
 _current_indent_level -= 1
 yield '\n' + _indent * _current_indent_level

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34972] json dump silently converts int keys to string

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

Thanks for the report. There was a related issue few days back issue32816. I 
think this is a documented behavior at 
https://docs.python.org/3.8/library/json.html#json.dumps . Having a warning in 
place might break code and I don't know if there is a safe way to introduce 
this as a code level warning given that this is a documented behavior in Python 
2 and 3. I think this is the case with other languages too like JavaScript 
itself converting int to string without warning adhering to JSON standard. 
Correct me if I am wrong or other languages have a warning related to this

> Note: Keys in key/value pairs of JSON are always of the type str. When a 
> dictionary is converted into JSON, all the keys of the dictionary are coerced 
> to strings. As a result of this, if a dictionary is converted into JSON and 
> then back into a dictionary, the dictionary may not equal the original one. 
> That is, loads(dumps(x)) != x if x has non-string keys

You can try doing json.loads(data, parse_int=int) but it will try converting 
the values.

>>> json.loads(json.dumps({1:'1'}), parse_int=int)
{'1': '1'}
>>> json.loads(json.dumps({1:1}), parse_int=int) 
{'1': 1}


Thanks

--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34972] json dump silently converts int keys to string

[My-Tien Nguyen]

New submission from My-Tien Nguyen :

When int keys are silently converted to string on json serialization, the user 
needs to remember to convert it back to int on loading.
I think that a warning should be shown at least.

In my case I serialize a dict to json with int keys, later load it back into a 
dict (resulting in a dict with string keys) and test for existence of an int 
key in the dict which will then return False incorrectly.

I am aware that json does not support int keys, but this can be easily 
forgotten.

--
components: +Library (Lib)
type:  -> behavior
versions: +Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34972] json dump silently converts int keys to string

[My-Tien Nguyen]

Change by My-Tien Nguyen :


--
nosy: My-Tien Nguyen
priority: normal
severity: normal
status: open
title: json dump silently converts int keys to string

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com