[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

Change by STINNER Victor :


--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[Eric Snow]

Eric Snow  added the comment:

On Fri, Oct 15, 2021 at 3:56 AM STINNER Victor  wrote:
> New changeset 063abd931f064a4b6b478b0b6e9aa13ee38d2cff by Victor Stinner in 
> branch 'main':
> bpo-35081: Move interpreteridobject.h to Include/internal/ (GH-28969)

FYI, _xxsubinterpretersmodule is supposed to be an extension module
(not builtin), so it's not meant to use internal APIs.  At some point
that happened and I only noticed now.  I've created bpo-45486 to
address that.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 063abd931f064a4b6b478b0b6e9aa13ee38d2cff by Victor Stinner in 
branch 'main':
bpo-35081: Move interpreteridobject.h to Include/internal/ (GH-28969)
https://github.com/python/cpython/commit/063abd931f064a4b6b478b0b6e9aa13ee38d2cff


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:

I reopen the issue since there is still activity on it.

--
resolution: fixed -> 
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +27257
pull_request: https://github.com/python/cpython/pull/28969

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[Mark Dickinson]

Change by Mark Dickinson :


--
nosy: +mark.dickinson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:


New changeset e9e7d284c434768333fdfb53a3663eae74cb995a by Victor Stinner in 
branch 'master':
bpo-35081: Move dtoa.h header to the internal C API (GH-18489)
https://github.com/python/cpython/commit/e9e7d284c434768333fdfb53a3663eae74cb995a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 45876a90e2663f12b90c2090ec3e48bd97841aae by Victor Stinner in 
branch 'master':
bpo-35081: Move bytes_methods.h to the internal C API (GH-18492)
https://github.com/python/cpython/commit/45876a90e2663f12b90c2090ec3e48bd97841aae


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +17865
pull_request: https://github.com/python/cpython/pull/18492

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +17862
pull_request: https://github.com/python/cpython/pull/18489

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +13937
pull_request: https://github.com/python/cpython/pull/13890

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:


New changeset ec13b9322d95a651606219469fc7b7e9c977f248 by Victor Stinner in 
branch 'master':
bpo-35081: Add Include/internal/pycore_tupleobject.h (GH-10705)
https://github.com/python/cpython/commit/ec13b9322d95a651606219469fc7b7e9c977f248


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +9956

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 8ac6539d85b481fc6b5e9145446b07e591b2caba by Victor Stinner in 
branch 'master':
bpo-35081: Add _PyTuple_CAST() (GH-10704)
https://github.com/python/cpython/commit/8ac6539d85b481fc6b5e9145446b07e591b2caba


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +9955

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:

In bpo-35296, I modified "make install" to also install Include/internal/.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:

I close the issue, it seems like all sub-tasks have been completed!

Summary of the change:

* Header files of Include/internal/ are now all prefixed by "pycore_" and the 
directory has been added to the header search path. For example, #include 
"pycore_pystate.h" is now used in C code, instead of #include 
"internal/pystate.h".
* All "#ifdef Py_BUILD_CORE" code has been moved from Include/*.h to 
Include/internal/*.h (except of the _PyTuple_ITEMS() macro)
* I created many new header files in Include/internal/
* _json and _locale modules are now built with Py_BUILD_CORE define
* _PyObject_GC_TRACK() and _PyObject_GC_UNTRACK() have been removed from the 
public C API and moved to the internal API

There are other issues to track following steps:

* bpo-35296: Install Include/internal/ header files
* bpo-35258: Fix -Wmissing-prototypes warnings
* bpo-35134: Create Include/cpython/ subdirectory
* bpo-35059: Convert macros to static inline functions

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 4ac5328affa37bdfc5847dfdb2a41bad772e7270 by Victor Stinner in 
branch 'master':
bpo-35081: add NEWS entry for new Include/internal/pycore_*.h files (GH-10666)
https://github.com/python/cpython/commit/4ac5328affa37bdfc5847dfdb2a41bad772e7270


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 984061eeb49c54fee901b92e5d3dde1c7a25cfa1 by Victor Stinner in 
branch 'master':
bpo-35081: Add new internal headers to Makefile (GH-10670)
https://github.com/python/cpython/commit/984061eeb49c54fee901b92e5d3dde1c7a25cfa1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +9924

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +9919

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:


New changeset bcda8f1d42a98d9022736dd52d855be8e220fe15 by Victor Stinner in 
branch 'master':
bpo-35081: Add Include/internal/pycore_object.h (GH-10640)
https://github.com/python/cpython/commit/bcda8f1d42a98d9022736dd52d855be8e220fe15


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +9888, 9889

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +9888

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +9888, 9889, 9890

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:

Please review PR 10624 of bpo-35134: Create Include/unstable/ subdirectory. 
It's the second part of my plan :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 3e21ad1a254cc33e8d4920ad7f026254ec728bee by Victor Stinner in 
branch 'master':
bpo-35081: Move _PyGC_FINALIZED() back to C API (GH-10626)
https://github.com/python/cpython/commit/3e21ad1a254cc33e8d4920ad7f026254ec728bee


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:

Stefan Behnel:
> Making _PyGC_FINALIZED() internal broke Cython 
> (https://github.com/cython/cython/issues/2721). It's used in the finaliser 
> implementation 
> (https://github.com/cython/cython/blob/da657c8e326a419cde8ae6ea91be9661b9622504/Cython/Compiler/ModuleNode.py#L1442-L1456),
>  to determine if an object for which tp_dealloc() is called has already been 
> finalised or whether we have to do it. I'm not sure how to deal with this on 
> our side now. Any clue?

I wrote PR 10626 to add _PyGC_FINALIZED() back to the C API.

My intent was only to remove _PyObject_GC_TRACK(o) and _PyObject_GC_UNTRACK(o) 
from the public C API.

I didn't expect that anyone would use _PyGC_FINALIZED() :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +9874

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:

TODO: add a NEWS entry for all these changes.

Copy of Nick Coghlan's comment:
https://github.com/python/cpython/pull/10275#issuecomment-439339982

@vstinner For folks consuming source archives (Linux distros, anyone embedding 
Python in a larger application, etc) rather than prebuilt binaries, the build 
process is something that can break, even for Py_BUILD_CORE only changes.

For those folks, when they pull a new source archive, their builds may break, 
especially if they're applying additional downstream patches the way Linux 
distros do.

The NEWS entry for this header file rearrangement should go in the Build 
section (https://github.com/python/cpython/tree/master/Misc/NEWS.d/next/Build) 
rather than the C API section (since these headers aren't part of the public 
API at all), but it should still exist.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:

> Making _PyGC_FINALIZED() internal broke Cython (...)

Aha, interesting. Would you mind to open a new dedicated issue? So we can 
discuss how much of the GC details we want to leak into the API :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[Stefan Behnel]

Stefan Behnel  added the comment:

Making _PyGC_FINALIZED() internal broke Cython 
(https://github.com/cython/cython/issues/2721). It's used in the finaliser 
implementation 
(https://github.com/cython/cython/blob/da657c8e326a419cde8ae6ea91be9661b9622504/Cython/Compiler/ModuleNode.py#L1442-L1456),
 to determine if an object for which tp_dealloc() is called has already been 
finalised or whether we have to do it. I'm not sure how to deal with this on 
our side now. Any clue?

--
nosy: +scoder

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[Alexey Izbyshev]

Alexey Izbyshev  added the comment:

> Oh, I never saw this warning before. It seems to not be included in -Wall. 
> Would you mind to open a new issue to discuss it?

Victor, I've opened #35258 as you suggested.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 1a6be91e6fd65ce9cb88c193db7e92ec6076 by Victor Stinner in 
branch 'master':
bpo-35081: Make some _PyGC macros internal (GH-10507)
https://github.com/python/cpython/commit/1a6be91e6fd65ce9cb88c193db7e92ec6076


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:

Hum, this issue is much harder than what I expected.

Status:

* Include/internal/ header files have been renamed to get a new "pycore_" 
prefix which avoids conflicts with Include/ header files. Example: 
"pycore_pystate.h" vs "pystate.h".
* pyatomic.c has been moved to Include/internal/ and it is no longer 
included in Python.h.
* Except of _PyTuple_ITEMS() and _PyObject_GC_TRACK(), all internal APIs have 
been moved to Include/internal/. Many new header files have been created, like 
pycore_lifecycle.h and pycore_pathconfig.h.

TODO:

* Move _PyObject_GC_TRACK() to Include/internal/
* msg329608 describes bugs like: pystate.c:968:1: warning: no previous 
prototype for ‘_PyGILState_Init’ [-Wmissing-prototypes]
* bpo-35134 now manages moving unstable API to a new separated Include/ 
subdirectory
* bpo-35059 converts macros to static inline functions

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +9767

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:

Status: only pyport. and tupleobject.h use Py_BUILD_CORE, and only 
tupleobject.h uses "#ifdef Py_BUILD_CORE" (contains code specific to internals).

$ grep Py_BUILD_CORE Include/*.h
Include/pyport.h:#   if defined(Py_BUILD_CORE) || 
defined(Py_BUILD_CORE_BUILTIN)
Include/pyport.h:#   else /* Py_BUILD_CORE */
Include/pyport.h:#   endif /* Py_BUILD_CORE */
Include/pyport.h:#if defined(Py_BUILD_CORE) || defined(Py_BUILD_CORE_BUILTIN)
Include/pyport.h:#endif /* Py_BUILD_CORE */
Include/tupleobject.h:#ifdef Py_BUILD_CORE

tupleobject.c:

#ifdef Py_BUILD_CORE
#  define _PyTuple_ITEMS(op) PyTupleObject *)(op))->ob_item))
#endif

I added this macro in bpo-35199, to prepare the C code for a new C API hiding 
implementation details: see bpo-35206.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 0d12672b30b8c6c992bef7564581117ae83e11ad by Victor Stinner (Paul 
Ganssle) in branch 'master':
bpo-35081: Remove Py_BUILD_CORE from datetime.h (GH-10416)
https://github.com/python/cpython/commit/0d12672b30b8c6c992bef7564581117ae83e11ad


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 621cebe81b1e6c8de10425955bf532d31ee4df42 by Victor Stinner in 
branch 'master':
bpo-35081: Rename internal headers (GH-10275)
https://github.com/python/cpython/commit/621cebe81b1e6c8de10425955bf532d31ee4df42


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:

> Python/pystate.c:968:1: warning: no previous prototype for ‘_PyGILState_Init’ 
> [-Wmissing-prototypes]
 _PyGILState_Init(PyInterpreterState *i, PyThreadState *t)
 ^~~~

Oh, I never saw this warning before. It seems to not be included in -Wall. 
Would you mind to open a new issue to discuss it?

I will try to fix the regressions that I introduced, but I'm interested by a 
more general discussion on this issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[Alexey Izbyshev]

Alexey Izbyshev  added the comment:

Victor, you moved declarations of some functions to other headers, but didn't 
include the new headers into files that implement the functions in some cases. 
For example, _PyGILState_Init was moved into 
Include/internal/pycore_lifecycle.h in 
a1c249c40517917d2e0971d55aea8d14a44b2cc8, but it's implemented in 
Python/pystate.c, which doesn't include the new header.

This may lead to subtle problems because the compiler can't check that 
signatures of the declaration and the implementation match. I suggest to use 
-Wmissing-prototypes and -Wmissing-declarations to detect such situations:

../../cpython/Python/pystate.c: At top level:
../../cpython/Python/pystate.c:968:1: warning: no previous prototype for 
‘_PyGILState_Init’ [-Wmissing-prototypes]
 _PyGILState_Init(PyInterpreterState *i, PyThreadState *t)
 ^~~~
../../cpython/Python/pystate.c:988:1: warning: no previous prototype for 
‘_PyGILState_Fini’ [-Wmissing-prototypes]
 _PyGILState_Fini(void)
 ^~~~

Sadly, there are many other similar issues in Python now, but you can at least 
compare the number of warnings before and after your changes.

--
nosy: +izbyshev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 130893debfd97c70e3a89d9ba49892f53e6b9d79 by Victor Stinner in 
branch 'master':
bpo-35081: Internal headers require Py_BUILD_CORE (GH-10363)
https://github.com/python/cpython/commit/130893debfd97c70e3a89d9ba49892f53e6b9d79


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[Paul Ganssle]

Change by Paul Ganssle :


--
pull_requests: +9696

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 9fc57a384825530635ef5ec093a31d864ea14f7c by Victor Stinner in 
branch 'master':
bpo-35081: Add pycore_fileutils.h (GH-10371)
https://github.com/python/cpython/commit/9fc57a384825530635ef5ec093a31d864ea14f7c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +9672

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +9664

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 5ed6995675b084fe583b71f96fdde4413bb2a77b by Victor Stinner in 
branch 'master':
bpo-35081: Add _PyCoreConfig_AsDict() (GH-10362)
https://github.com/python/cpython/commit/5ed6995675b084fe583b71f96fdde4413bb2a77b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +9662

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:

> Please don't change Include/datetime.h without consulting with original 
> authors of this code (see issue876130).

FYI I tried to be very careful on each change to never modify the *public* C 
API.

But I modified the Py_BUILD_CORE API. This is fine since this API can change 
anytime, and it must not be used outside Python.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Please don't change Include/datetime.h without consulting with original authors 
of this code (see issue876130).

--
nosy: +atuining, lemburg, serhiy.storchaka, tim.peters

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:

I created bpo-35134: Move !Py_LIMITED_API to Include/pycapi/.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +9588

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +9587

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +9586

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:

> bpo-35081: And pycore_lifecycle.h and pycore_pathconfig.h (GH-10273)

I tried to add the Py_BUILD_CORE guard in pycore_pathconfig.h:

+#ifndef Py_BUILD_CORE
+#  error "Py_BUILD_CORE must be defined to include this header"
+#endif

But it breaks the compilation of _testcapimodule.c: get_coreconfig() uses 
_Py_wstrlist_as_pylist(), and _Py_wstrlist_as_pylist() is defined in 
pycore_pathconfig.h.

IMHO _testcapi should be compiled with Py_BUILD_CORE defined. I wrote PR 10274 
but then _testcapi fails because of datetime.h: this bug should be fixed by PR 
10238.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +9585

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

STINNER Victor  added the comment:


New changeset a1c249c40517917d2e0971d55aea8d14a44b2cc8 by Victor Stinner in 
branch 'master':
bpo-35081: And pycore_lifecycle.h and pycore_pathconfig.h (GH-10273)
https://github.com/python/cpython/commit/a1c249c40517917d2e0971d55aea8d14a44b2cc8


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +9584

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35081] Move internal headers to Include/internal/

[STINNER Victor]

Change by STINNER Victor :


--
title: Rename Include/internals/ to Include/pycore/ -> Move internal headers to 
Include/internal/

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com