[issue35455] Solaris: thread_time doesn't work with current implementation

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset a12f459ec2a31b96a21c735eb18f3d0fd19e99ff by Jakub Kulík in branch 
'3.8':
[3.8] bpo-35455: Fix thread_time for Solaris OS (GH-8). (GH-23145)
https://github.com/python/cpython/commit/a12f459ec2a31b96a21c735eb18f3d0fd19e99ff


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35455] Solaris: thread_time doesn't work with current implementation

[Jakub Kulik]

Change by Jakub Kulik :


--
versions:  -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35455] Solaris: thread_time doesn't work with current implementation

[Jakub Kulik]

Change by Jakub Kulik :


--
pull_requests: +22057
pull_request: https://github.com/python/cpython/pull/23145

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35455] Solaris: thread_time doesn't work with current implementation

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 72bb4c6c1fc5f5209819a2e62d55475ddc888192 by Miss Skeleton (bot) 
in branch '3.9':
bpo-35455: Fix thread_time for Solaris OS (GH-8) (GH-23130)
https://github.com/python/cpython/commit/72bb4c6c1fc5f5209819a2e62d55475ddc888192


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35455] Solaris: thread_time doesn't work with current implementation

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 4.0 -> 5.0
pull_requests: +22046
pull_request: https://github.com/python/cpython/pull/23130

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35455] Solaris: thread_time doesn't work with current implementation

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Perhaps we should also use gethrtime() and gethrvtime() on HP-UX, but this is a 
different issue.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35455] Solaris: thread_time doesn't work with current implementation

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35455] Solaris: thread_time doesn't work with current implementation

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 9568622c9983b682b2a2a7bacfd3c341028ea099 by Jakub Kulík in branch 
'master':
bpo-35455: Fix thread_time for Solaris OS (GH-8)
https://github.com/python/cpython/commit/9568622c9983b682b2a2a7bacfd3c341028ea099


--
nosy: +pablogsal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35455] Solaris: thread_time doesn't work with current implementation

[Jakub Kulik]

Change by Jakub Kulik :


--
versions: +Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35455] Solaris: thread_time doesn't work with current implementation

[Jakub Kulik]

Change by Jakub Kulik :


--
title: Solaris thread_time doesn't work with current implementation -> Solaris: 
thread_time doesn't work with current implementation

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35455] Solaris thread_time doesn't work with current implementation

[Jakub Kulik]

Jakub Kulik  added the comment:

Comment from https://bugs.python.org/issue42173#msg380205 confirmed that this 
issue is still relevant to Illumos based systems. Because of that, I am happy 
to resolve it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35455] Solaris thread_time doesn't work with current implementation

[Jakub Kulik]

Jakub Kulik  added the comment:

Correction: looking at the PR, I made it so that it checks for SunOS, so even 
with CLOCK_THREAD_CPUTIME_ID available, new code would be executed. 

So if you believe that this should be implemented for other SunOSes, I can do 
it ;).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35455] Solaris thread_time doesn't work with current implementation

[Jakub Kulik]

Jakub Kulik  added the comment:

I was speaking for Oracle Solaris 11.4, where CLOCK_THREAD_CPUTIME_ID is now 
implemented (and we don't need it in older releases). But you are right that 
other Solaris/SunOS versions might not have this and hence would find this 
useful.

I can rebase and reopen the original PR, but I cannot test it that well now 
that our Solaris doesn't use that part of the code (I can change the #define 
for testing, that should be sufficient).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35455] Solaris thread_time doesn't work with current implementation

[Batuhan Taskaya]

Batuhan Taskaya  added the comment:

This issue is still valid under other solaris/sunos versions. @kulikjak are you 
still interested in resolving this issue?

--
nosy: +BTaskaya
resolution: not a bug -> 
status: closed -> open
versions: +Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35455] Solaris thread_time doesn't work with current implementation

[Jakub Kulik]

Jakub Kulik  added the comment:

Since I created this pull request, clock_gettime(CLOCK_THREAD_CPUTIME_ID, ..) 
was implemented into the Solaris kernel, so I guess that this is no longer 
relevant.

--
resolution:  -> not a bug
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35455] Solaris thread_time doesn't work with current implementation

[Jakub Kulik]

Change by Jakub Kulik :


--
versions: +Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35455] Solaris thread_time doesn't work with current implementation

[Jakub Kulik]

Change by Jakub Kulik :


--
pull_requests: +10347
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35455] Solaris thread_time doesn't work with current implementation

[Jakub Kulik]

Change by Jakub Kulik :


--
type:  -> crash

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35455] Solaris thread_time doesn't work with current implementation

[Jakub Kulik]

New submission from Jakub Kulik :

Implementation of time.thread_time() doesn't work on Solaris because clock_id 
CLOCK_THREAD_CPUTIME_ID is not known (it is defined, but clock_gettime returns 
EINVAL error). Solaris, however, has function gethrvtime() which can substitute 
this functionality.

I attached a possible patch which does work during tests and I further tested 
it with some basic scripts.

--
components: Extension Modules
files: thread_time.diff
keywords: patch
messages: 331509
nosy: kulikjak
priority: normal
severity: normal
status: open
title: Solaris thread_time doesn't work with current implementation
versions: Python 3.7
Added file: https://bugs.python.org/file47984/thread_time.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com