[issue35550] Some define guards for Solaris are wrong

Change by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue35550] Some define guards for Solaris are wrong

STINNER Victor added the comment: > We don't plan to switch to gcc on 2.7 and so it doesn't affect us. Ok. I close the issue. If anyone wants to fix 2.7, please go ahead :-) -- stage: commit review -> resolved status: open -> closed ___ Python trac

[issue35550] Some define guards for Solaris are wrong

Jakub Kulik added the comment: We are building previous versions of Python with Solaris Studio which works with define guards as they are right now. 3.7 is first version build with gcc. We don't plan to switch to gcc on 2.7 and so it doesn't affect us. But I guess if this fix can be done eas

[issue35550] Some define guards for Solaris are wrong

Change by Gregory P. Smith : -- assignee: gregory.p.smith -> ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35550] Some define guards for Solaris are wrong

STINNER Victor added the comment: Do you want to fix the 2.7 branch as well? -- nosy: +vstinner ___ Python tracker ___ ___ Python-b

[issue35550] Some define guards for Solaris are wrong

miss-islington added the comment: New changeset d82344378ad8e471b8ed12fb99807f68351c5412 by Miss Islington (bot) in branch '3.7': bpo-35550: Fix incorrect Solaris define guards (GH-11275) https://github.com/python/cpython/commit/d82344378ad8e471b8ed12fb99807f68351c5412 -- nosy: +mis

[issue35550] Some define guards for Solaris are wrong

Change by Gregory P. Smith : -- assignee: -> gregory.p.smith resolution: -> fixed stage: patch review -> commit review versions: +Python 3.8 ___ Python tracker ___ __

[issue35550] Some define guards for Solaris are wrong

Change by miss-islington : -- pull_requests: +10735 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35550] Some define guards for Solaris are wrong

Change by miss-islington : -- pull_requests: +10735, 10736 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue35550] Some define guards for Solaris are wrong

Gregory P. Smith added the comment: New changeset 6f9bc72c79c3262e5d0f2c0e96b016477399cfb1 by Gregory P. Smith (Jakub Kulík) in branch 'master': bpo-35550: Fix incorrect Solaris define guards (GH-11275) https://github.com/python/cpython/commit/6f9bc72c79c3262e5d0f2c0e96b016477399cfb1 ---

[issue35550] Some define guards for Solaris are wrong

Change by Jakub Kulik : -- keywords: +patch pull_requests: +10509 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-lis

[issue35550] Some define guards for Solaris are wrong

New submission from Jakub Kulik : Python source code uses on several places ifdef sun or defined(sun) without the underscores, which is not standard compliant and shouldn't be used. Our recent Solaris python build ended up skipping these sections resulting in some obvious problems. Defines s