[issue35767] unittest loader doesn't work with partial test functions

[Jason Fried]

Change by Jason Fried :


--
resolution:  -> fixed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35767] unittest loader doesn't work with partial test functions

[Jason Fried]

Change by Jason Fried :


--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35767] unittest loader doesn't work with partial test functions

[Irit Katriel]

Irit Katriel  added the comment:

Can this be closed now?

--
components: +Tests
nosy: +iritkatriel
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35767] unittest loader doesn't work with partial test functions

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset 841387dd43e67b1800d10e4d7ce1f8cedc9f3706 by Łukasz Langa (Miss 
Islington (bot)) in branch '3.7':
bpo-35767: Fix unittest.loader to allow partials as test_functions (GH-11600) 
(#11662)
https://github.com/python/cpython/commit/841387dd43e67b1800d10e4d7ce1f8cedc9f3706


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35767] unittest loader doesn't work with partial test functions

[miss-islington]

Change by miss-islington :


--
pull_requests: +11464, 11465, 11466

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35767] unittest loader doesn't work with partial test functions

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset fd628cf5adaeee73eab579393cdff71c8f70cdf2 by Łukasz Langa (Jason 
Fried) in branch 'master':
bpo-35767: Fix unittest.loader to allow partials as test_functions (#11600)
https://github.com/python/cpython/commit/fd628cf5adaeee73eab579393cdff71c8f70cdf2


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35767] unittest loader doesn't work with partial test functions

[miss-islington]

Change by miss-islington :


--
pull_requests: +11464

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35767] unittest loader doesn't work with partial test functions

[miss-islington]

Change by miss-islington :


--
pull_requests: +11464, 11465

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35767] unittest loader doesn't work with partial test functions

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

Seems this was introduced with issue32071

--
nosy: +jonash, pitrou, xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35767] unittest loader doesn't work with partial test functions

[Jason Fried]

Change by Jason Fried :


--
keywords: +patch, patch, patch
pull_requests: +11316, 11317, 11318
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35767] unittest loader doesn't work with partial test functions

[Jason Fried]

Change by Jason Fried :


--
keywords: +patch
pull_requests: +11316
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35767] unittest loader doesn't work with partial test functions

[Jason Fried]

Change by Jason Fried :


--
keywords: +patch, patch
pull_requests: +11316, 11317
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35767] unittest loader doesn't work with partial test functions

[Jason Fried]

Jason Fried  added the comment:

working on a pull request

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35767] unittest loader doesn't work with partial test functions

[Jason Fried]

Jason Fried  added the comment:

Oh this is broken in 3.7 trunk

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35767] unittest loader doesn't work with partial test functions

[Jason Fried]

New submission from Jason Fried :

https://github.com/python/cpython/blob/3.7/Lib/unittest/loader.py#L232

fullName = '%s.%s' % (testCaseClass.__module__, testFunc.__qualname__)

Instead we should probably replace testFunc.__qualname__ with attrname

I ran into this while running a test suite that built up test functions using 
partials and added them to the TestCase class with setattr. 

This works in 3.6.3

--
messages: 333926
nosy: fried, lisroach, lukasz.langa
priority: normal
severity: normal
status: open
title: unittest loader doesn't work with partial test functions
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com