[issue35861] test_named_expressions raises SyntaxWarning

[Emily Morehouse]

Change by Emily Morehouse :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35861] test_named_expressions raises SyntaxWarning

[Emily Morehouse]

Emily Morehouse  added the comment:


New changeset 075de6cf6cb0f5f4d3711fc07f023a9a7a0a816b by Emily Morehouse 
(Joannah Nanjekye) in branch 'master':
bpo-35861: Fix SyntaxWarning in test_named_expressions.py (GH-11722)
https://github.com/python/cpython/commit/075de6cf6cb0f5f4d3711fc07f023a9a7a0a816b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35861] test_named_expressions raises SyntaxWarning

[Joannah Nanjekye]

Change by Joannah Nanjekye :


--
keywords: +patch, patch, patch
pull_requests: +11598, 11599, 11600
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35861] test_named_expressions raises SyntaxWarning

[Joannah Nanjekye]

Change by Joannah Nanjekye :


--
keywords: +patch
pull_requests: +11598
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35861] test_named_expressions raises SyntaxWarning

[Joannah Nanjekye]

Change by Joannah Nanjekye :


--
keywords: +patch, patch
pull_requests: +11598, 11599
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35861] test_named_expressions raises SyntaxWarning

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

Thanks Emily, I am marking this as easy since it's related to tests and doesn't 
affect alpha release. If no one gets to this I will raise a fix for this by 
Sunday.

--
keywords: +easy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35861] test_named_expressions raises SyntaxWarning

[Emily Morehouse]

Emily Morehouse  added the comment:

Yes, you're exactly correct! Feel free to submit a PR and add me as a reviewer 
when you're ready.

--
assignee:  -> xtreak
stage:  -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35861] test_named_expressions raises SyntaxWarning

[Karthikeyan Singaravelan]

New submission from Karthikeyan Singaravelan :

SyntaxWarning was recently added for comparison using "is" over literals with 
issue34850. This is raised on master for a PEP 572 related test. The warning is 
emitted twice which is covered with bpo-35798 and I verified the patch. The fix 
for this issue would be to use == as noted in the warning. 

Emily, if you can confirm my report then I would like to triage this as an easy 
one since the fix is simple.

# SyntaxWarning on master

➜  cpython git:(master) ./python.exe Lib/test/test_named_expressions.py
Lib/test/test_named_expressions.py:168: SyntaxWarning: "is" with a literal. Did 
you mean "=="?
  if (match := 10) is 10:
Lib/test/test_named_expressions.py:168: SyntaxWarning: "is" with a literal. Did 
you mean "=="?
  if (match := 10) is 10:

--
Ran 56 tests in 0.010s

OK


Thanks

--
components: Tests
messages: 334587
nosy: emilyemorehouse, serhiy.storchaka, xtreak
priority: normal
severity: normal
status: open
title: test_named_expressions raises SyntaxWarning
type: behavior
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com