[issue35903] Build of posixshmem.c should probe for required OS functions

[Neil Schemenauer]

Change by Neil Schemenauer :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35903] Build of posixshmem.c should probe for required OS functions

[Neil Schemenauer]

Neil Schemenauer  added the comment:


New changeset 5741c45acf9b0ce22ff0dbf56322fe0ff16cfcfc by Neil Schemenauer in 
branch 'master':
bpo-35903: Use autoconfig to probe for shm_open() and shm_unlink(). (#11765)
https://github.com/python/cpython/commit/5741c45acf9b0ce22ff0dbf56322fe0ff16cfcfc


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35903] Build of posixshmem.c should probe for required OS functions

[Neil Schemenauer]

Neil Schemenauer  added the comment:

Hi Ronald,
I tested with my MacBook but I'm not sure what version of the OS.  Probably the 
latest but I can check when I get home.  Maybe my comment was not clear. On my 
MacBook, you don't need librt for shm_open, etc.  That sounds like it is the 
same as your 10.14.3.

AC_SEARCH_LIBS is the macro I'm using to find if I need to link with librt.  It 
is a bit hard to use though.  It will execute the true clause if the function 
doesn't require any of the specified libraries.  That seems to be the case for 
MacOS.  It also adds -lrt to LIBS and so I have to undo that.

I'm using $ac_cv_search_shm_open test if -lrt is actually needed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35903] Build of posixshmem.c should probe for required OS functions

[Ronald Oussoren]

Ronald Oussoren  added the comment:

@Neil: On what version of macOS did you test? 

On 10.14.3 with Xcode 10.1 shm_open is in libSystem (that's named libc on most 
other unixy systems) and there is no library named librt.

--
nosy: +ronaldoussoren

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35903] Build of posixshmem.c should probe for required OS functions

[Neil Schemenauer]

Neil Schemenauer  added the comment:

I didn't understand autoconfig well enough but I think I fixed it now.  
Apparently MacOS is a platform where it has shm_open but you don't need to link 
with -lrt.  The revised 'configure' should handle that correctly now.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35903] Build of posixshmem.c should probe for required OS functions

[Davin Potts]

Davin Potts  added the comment:

Agreed that the logic for building that code needs exactly this sort of change. 
 Thanks for the patch!

It looks like your patch does not happily detect the dependencies on MacOS for 
some reason, but all appears well on Windows & Linux.  I will have a closer 
look in the morning on a MacOS system.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35903] Build of posixshmem.c should probe for required OS functions

[Neil Schemenauer]

Change by Neil Schemenauer :


--
pull_requests: +11719, 11720

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35903] Build of posixshmem.c should probe for required OS functions

[Neil Schemenauer]

Change by Neil Schemenauer :


--
pull_requests: +11719, 11720, 11721

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35903] Build of posixshmem.c should probe for required OS functions

[Neil Schemenauer]

Change by Neil Schemenauer :


--
pull_requests: +11719

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35903] Build of posixshmem.c should probe for required OS functions

[Neil Schemenauer]

New submission from Neil Schemenauer :

The logic in setup.py that determines if _multiprocessing/posixshmem.c should 
get built is not very robust.  I think it is better to use autoconfig to probe 
for the required functions and libraries.  My autoconfig brain cells are a bit 
fuzzy but I think my patch is correct.

I look for shm_open and shm_unlink.  I also check if librt is required for 
these functions.

--
assignee: davin
components: Build
keywords: patch
messages: 334888
nosy: davin, nascheme
priority: normal
severity: normal
stage: patch review
status: open
title: Build of posixshmem.c should probe for required OS functions
type: enhancement
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com