[issue35936] Give modulefinder some much-needed updates.

Nick Coghlan added the comment: New changeset 9d7b2c0909b78800d1376fd696f73824ea680463 by Nick Coghlan (Brandt Bucher) in branch 'master': bpo-35936: Updates to modulefinder (GH-11787) https://github.com/python/cpython/commit/9d7b2c0909b78800d1376fd696f73824ea680463 --

[issue35936] Give modulefinder some much-needed updates.

Nick Coghlan added the comment: Thanks Brandt! I'll also go back and close #17396, #35376, and #25160 -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue35936] Give modulefinder some much-needed updates.

Change by Brandt Bucher : -- nosy: +barry, brett.cannon, ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35936] Give modulefinder some much-needed updates.

Brandt Bucher added the comment: Alright, I've gotten all of the tests passing for the new importlib-only implementation. I broke these modifications out into a new private function, _find_module, to make it clear that this fix is a simple drop-in replacement for imp.find_module. Let me

[issue35936] Give modulefinder some much-needed updates.

Change by SilentGhost : -- nosy: +jvr ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35936] Give modulefinder some much-needed updates.

Change by Brandt Bucher : -- keywords: +patch pull_requests: +11779 stage: -> patch review ___ Python tracker ___ ___

[issue35936] Give modulefinder some much-needed updates.

Change by Brandt Bucher : -- keywords: +patch, patch pull_requests: +11779, 11780 stage: -> patch review ___ Python tracker ___

[issue35936] Give modulefinder some much-needed updates.

New submission from Brandt Bucher : I've written a patch here that includes a few useful fixes. Namely: - It doesn't crash if it encounters a syntax error. (17396) - It doesn't report certain name collisions as bad. (35376) - It doesn't use mutable default arguments in its initializer. - Most

[issue35936] Give modulefinder some much-needed updates.

Change by Brandt Bucher : -- components: Library (Lib) nosy: brandtbucher priority: normal severity: normal status: open title: Give modulefinder some much-needed updates. type: enhancement versions: Python 3.4 ___ Python tracker