[issue36290] _ast.ast_type_init does not handle args and kwargs correctly.

[miss-islington]

miss-islington  added the comment:


New changeset 1a4e9e6f35dad26b37639198f1444591d04399e0 by Miss Islington (bot) 
in branch '3.9':
bpo-36290: Fix keytword collision handling in AST node constructors (GH-12382)
https://github.com/python/cpython/commit/1a4e9e6f35dad26b37639198f1444591d04399e0


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36290] _ast.ast_type_init does not handle args and kwargs correctly.

[miss-islington]

miss-islington  added the comment:


New changeset 907ee1f14aaf587683ced44818c5a1d1cabf4174 by Miss Islington (bot) 
in branch '3.8':
bpo-36290: Fix keytword collision handling in AST node constructors (GH-12382)
https://github.com/python/cpython/commit/907ee1f14aaf587683ced44818c5a1d1cabf4174


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36290] _ast.ast_type_init does not handle args and kwargs correctly.

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36290] _ast.ast_type_init does not handle args and kwargs correctly.

[miss-islington]

Change by miss-islington :


--
pull_requests: +19630
pull_request: https://github.com/python/cpython/pull/20366

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36290] _ast.ast_type_init does not handle args and kwargs correctly.

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset c73914a562580ae72048876cb42ed8e76e2c83f9 by Rémi Lapeyre in 
branch 'master':
bpo-36290: Fix keytword collision handling in AST node constructors (GH-12382)
https://github.com/python/cpython/commit/c73914a562580ae72048876cb42ed8e76e2c83f9


--
nosy: +pablogsal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36290] _ast.ast_type_init does not handle args and kwargs correctly.

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 6.0 -> 7.0
pull_requests: +19629
pull_request: https://github.com/python/cpython/pull/20365

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36290] _ast.ast_type_init does not handle args and kwargs correctly.

[Rémi Lapeyre]

Change by Rémi Lapeyre :


--
keywords: +patch
pull_requests: +12340
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36290] _ast.ast_type_init does not handle args and kwargs correctly.

[Brett Cannon]

Change by Brett Cannon :


--
nosy: +benjamin.peterson, brett.cannon, serhiy.storchaka, yselivanov

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36290] _ast.ast_type_init does not handle args and kwargs correctly.

[Rémi Lapeyre]

New submission from Rémi Lapeyre :

While looking at issue 36287 I noticed that the argument parsing logic in 
_ast.ast_type_init is wrong, for example ast.Constant takes only one argument:

✗ ./python.exe 
Python 3.8.0a2+ (remotes/origin/HEAD-1-ged9b774cf3:ed9b774cf3, Mar 14 2019, 
00:50:47) 
[Clang 10.0.0 (clang-1000.10.44.4)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import ast
>>> ast.Constant(1, 2)
Traceback (most recent call last):
  File "", line 1, in 
TypeError: Constant constructor takes at most 1 positional argument
>>> ast.Constant(1)
<_ast.Constant object at 0x105b52950>
>>> ast.Constant(value=2)
<_ast.Constant object at 0x105b528f0>
>>> ast.Constant(1, value=2)
<_ast.Constant object at 0x105b529b0>
>>> ast.Constant(1, value=2).value
2


The last lines should have raised TypeError. I could reproduce the issue with 
Python 2.7, 3.7 and 3.8 but I'm not sure it's worth fixing for 2.7.

I will write a patch to fix the issue.

--
components: Library (Lib)
messages: 337926
nosy: remi.lapeyre
priority: normal
severity: normal
status: open
title: _ast.ast_type_init does not handle args and kwargs correctly.
type: behavior
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com