[issue3634] invalid result value of _weakref.__init__()

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Fixed in r66352. -- resolution: accepted -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3634] invalid result value of _weakref.__init__()

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: Both patches look fine to me. They could be backported to 2.5 as well. -- keywords: -needs review resolution: -> accepted ___ Python tracker <[EMAIL PROTECTED]>

[issue3634] invalid result value of _weakref.__init__()

STINNER Victor <[EMAIL PROTECTED]> added the comment: amaury: oh yes, i forget to use assertRaise(). A new patch is attached. ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3634] invalid result value of _weakref.__init__()

Changes by STINNER Victor <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file11431/weakref_test.patch ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3634] invalid result value of _weakref.__init__()

Changes by STINNER Victor <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file11434/weakref_test-2.patch ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3634] invalid result value of _weakref.__init__()

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: I think the test should check that TypeError is actually raised: self.assertRaises(TypeError, r.__init__, 0, 0, 0, 0, 0) It's even shorter than the try/except block... -- nosy: +amaury.forgeotdarc

[issue3634] invalid result value of _weakref.__init__()

STINNER Victor <[EMAIL PROTECTED]> added the comment: Add a test to check to regression. Added file: http://bugs.python.org/file11431/weakref_test.patch ___ Python tracker <[EMAIL PROTECTED]>

[issue3634] invalid result value of _weakref.__init__()

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Adding a simple unit test would be nice. -- nosy: +pitrou ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue3634] invalid result value of _weakref.__init__()

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: The patch looks absolutely fine to me. (I think I have to have another core developer look at it too, though.) -- assignee: -> benjamin.peterson keywords: +needs review nosy: +benjamin.peterson ___

[issue3634] invalid result value of _weakref.__init__()

STINNER Victor <[EMAIL PROTECTED]> added the comment: The bug and the fix are trivials. Can anyone review my patch? ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue3634] invalid result value of _weakref.__init__()

Changes by Daniel Diniz <[EMAIL PROTECTED]>: -- nosy: +ajaksu2 ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mailing l

[issue3634] invalid result value of _weakref.__init__()

New submission from STINNER Victor <[EMAIL PROTECTED]>: _weakref.__init__() doesn't catch errors correctly. Example: - 8< - from gc import collect import _weakref class FuzzingUserClass: pass obj = _weakref.ref(FuzzingUserClass) # Exception not r