[issue36611] Debug memory allocators: remove useless "serialno" field to reduce memory footprint

STINNER Victor added the comment: We decided to only disable the code by default, but the code stays until we are sure that nobody uses it. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue36611] Debug memory allocators: remove useless "serialno" field to reduce memory footprint

STINNER Victor added the comment: New changeset e8f9acf03484c6c3f163f04a76321419369c28aa by Victor Stinner in branch 'master': bpo-36611: Disable serialno field of debug memory allocators (#12796) https://github.com/python/cpython/commit/e8f9acf03484c6c3f163f04a76321419369c28aa --

[issue36611] Debug memory allocators: remove useless "serialno" field to reduce memory footprint

miss-islington added the comment: New changeset 7182e653fb5c6f78f05892b6ed302fc8db8978d3 by Miss Islington (bot) in branch '3.7': bpo-36611: Fix test_sys.test_getallocatedblocks() (GH-12797) https://github.com/python/cpython/commit/7182e653fb5c6f78f05892b6ed302fc8db8978d3 -- nosy:

[issue36611] Debug memory allocators: remove useless "serialno" field to reduce memory footprint

Change by miss-islington : -- pull_requests: +12729 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36611] Debug memory allocators: remove useless "serialno" field to reduce memory footprint

STINNER Victor added the comment: New changeset 9b8314cfe29ca532fc335277f6c36b72e6132922 by Victor Stinner in branch 'master': bpo-36611: Fix test_sys.test_getallocatedblocks() (GH-12797) https://github.com/python/cpython/commit/9b8314cfe29ca532fc335277f6c36b72e6132922 --

[issue36611] Debug memory allocators: remove useless "serialno" field to reduce memory footprint

STINNER Victor added the comment: The serialno has been added at the same time than the whole debug hooks on Python memory allocated by Tim Peters in 2002, 17 years ago: commit ddea208be9e2a8fa281e25ebbc890378dd2aa286 Author: Tim Peters Date: Sat Mar 23 10:03:50 2002 + Give

[issue36611] Debug memory allocators: remove useless "serialno" field to reduce memory footprint

STINNER Victor added the comment: This issue is related to the following thread on python-dev which discuss disabling Py_TRACE_REFS by default, bpo-36465, to reduce the memory footprint in debug mode: https://mail.python.org/pipermail/python-dev/2019-April/157015.html --

[issue36611] Debug memory allocators: remove useless "serialno" field to reduce memory footprint

Inada Naoki added the comment: I never used the serialno too. -- nosy: +inada.naoki ___ Python tracker ___ ___ Python-bugs-list

[issue36611] Debug memory allocators: remove useless "serialno" field to reduce memory footprint

STINNER Victor added the comment: While testing my changes, I found a bug in test_sys: ./python -X tracemalloc -m test test_sys -v -m test_getallocatedblocks == ERROR: test_getallocatedblocks (test.test_sys.SysModuleTest)

[issue36611] Debug memory allocators: remove useless "serialno" field to reduce memory footprint

Change by STINNER Victor : -- pull_requests: +12724 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36611] Debug memory allocators: remove useless "serialno" field to reduce memory footprint

STINNER Victor added the comment: I wrote 2 pull requests for the two options: * PR 12795 removes serialno field * PR 12796 adds PYMEM_DEBUG_SERIALNO define which is unset by default -- ___ Python tracker

[issue36611] Debug memory allocators: remove useless "serialno" field to reduce memory footprint

Change by STINNER Victor : -- pull_requests: +12723 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36611] Debug memory allocators: remove useless "serialno" field to reduce memory footprint

Change by STINNER Victor : -- keywords: +patch pull_requests: +12722 stage: -> patch review ___ Python tracker ___ ___

[issue36611] Debug memory allocators: remove useless "serialno" field to reduce memory footprint

New submission from STINNER Victor : When PYTHONMALLOC=debug environment variable or -X dev command line option is used, Python installs debug hooks on memory allocators which add 2 size_t before and 2 size_t after each memory block: it adds 32 bytes to every memory allocation. I'm