[issue36656] Please add race-free os.link and os.symlink wrapper / helper

2019-06-29 Thread Tom Hale
Tom Hale added the comment: I've created a PR here: https://github.com/python/cpython/pull/14464 Only shutil.symlink is currently implemented. Feedback sought from Windows users. @Michael.Felt please note that `overwrite=False` is the default. @taleinat I hope that the new implementation

[issue36656] Please add race-free os.link and os.symlink wrapper / helper

2019-06-29 Thread Roundup Robot
Change by Roundup Robot : -- keywords: +patch pull_requests: +14280 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14464 ___ Python tracker ___

[issue36656] Please add race-free os.link and os.symlink wrapper / helper

2019-06-27 Thread Tal Einat
Tal Einat added the comment: I think there is a general flaw with the suggested implementation approach. An infinite loop as currently suggested seems dangerous to me. For example, it could cause a program to stall indefinitely in some unforeseen edge-case. I don't think this would be

[issue36656] Please add race-free os.link and os.symlink wrapper / helper

2019-06-27 Thread Tal Einat
Change by Tal Einat : -- components: +Library (Lib) versions: +Python 3.9 -Python 3.7 ___ Python tracker ___ ___ Python-bugs-list

[issue36656] Please add race-free os.link and os.symlink wrapper / helper

2019-06-07 Thread Michael Felt
Michael Felt added the comment: I started a reply on the python-mentoring maillist - and promised to come back here. a) imho - the discussion about an "attacker" is only misleading for the general case. For active attacks - where an attacker has active acces to the system is not something

[issue36656] Please add race-free os.link and os.symlink wrapper / helper

2019-06-07 Thread Robert Collins
Robert Collins added the comment: Thank you @Eryk -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36656] Please add race-free os.link and os.symlink wrapper / helper

2019-06-07 Thread Michael Felt
Change by Michael Felt : -- nosy: +Michael.Felt ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36656] Please add race-free os.link and os.symlink wrapper / helper

2019-06-04 Thread Eryk Sun
Eryk Sun added the comment: > I'd like to add a few notes; please do consider Windows interactions > here - Windows does not have the same model for inode replacement that > Posix has. Certainly Windows doesn't have the same model for inode replacement since it doesn't have inodes. ;-)

[issue36656] Please add race-free os.link and os.symlink wrapper / helper

2019-06-03 Thread Robert Collins
Robert Collins added the comment: I'd like to add a few notes; please do consider Windows interactions here - Windows does not have the same model for inode replacement that Posix has. Secondly, I note that the thread model discussed here hasn't been particular well articulated. In