[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

STINNER Victor added the comment: New changeset b894b669c98cc365b84cbb8d20f531f1d0686f59 by Victor Stinner in branch '3.7': Update libregrtest from master (GH-19517) https://github.com/python/cpython/commit/b894b669c98cc365b84cbb8d20f531f1d0686f59 --

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

miss-islington added the comment: New changeset f9016e5fc9424d41c8e53de84f8699e78769a14a by Miss Islington (bot) in branch '3.7': [3.8] bpo-36670, regrtest: Fix WindowsLoadTracker() for partial line (GH-16550) (GH-16560)

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

STINNER Victor added the comment: Thanks for the bug report. I was impacted by the bug with my French locale as well. I pushed a fix based on Lorenz Mende's work, with minor changes. I also enhanced WindowsLoadTracker to handle partial write and report parsing errors as warnings rather

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

Change by miss-islington : -- pull_requests: +16153 pull_request: https://github.com/python/cpython/pull/16562 ___ Python tracker ___

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

STINNER Victor added the comment: New changeset de3195c937d5fca0d79cc93dbafa76c0f89ca5b8 by Victor Stinner in branch '3.8': [3.8] bpo-36670, regrtest: Fix WindowsLoadTracker() for partial line (GH-16550) (GH-16560)

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

Change by STINNER Victor : -- pull_requests: +16151 pull_request: https://github.com/python/cpython/pull/16560 ___ Python tracker ___

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

Change by STINNER Victor : -- pull_requests: +16150 pull_request: https://github.com/python/cpython/pull/16559 ___ Python tracker ___

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

STINNER Victor added the comment: New changeset 098e25672f1c3578855d5ded4f5147795c9ed956 by Victor Stinner in branch 'master': bpo-36670: Enhance regrtest (GH-16556) https://github.com/python/cpython/commit/098e25672f1c3578855d5ded4f5147795c9ed956 --

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

Change by STINNER Victor : -- pull_requests: +16144 pull_request: https://github.com/python/cpython/pull/16556 ___ Python tracker ___

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

Change by STINNER Victor : -- pull_requests: +16143 pull_request: https://github.com/python/cpython/pull/16555 ___ Python tracker ___

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

Change by STINNER Victor : -- pull_requests: +16142 pull_request: https://github.com/python/cpython/pull/16554 ___ Python tracker ___

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

STINNER Victor added the comment: New changeset c65119d5bfded03f80a9805889391b66fa7bf551 by Victor Stinner in branch 'master': bpo-36670: Enhance regrtest WindowsLoadTracker (GH-16553) https://github.com/python/cpython/commit/c65119d5bfded03f80a9805889391b66fa7bf551 --

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

Change by STINNER Victor : -- pull_requests: +16141 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/16553 ___ Python tracker ___

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

STINNER Victor added the comment: New changeset 3e04cd268ee9a57f95dc78d8974b21a6fac3f666 by Victor Stinner in branch 'master': bpo-36670, regrtest: Fix WindowsLoadTracker() for partial line (GH-16550) https://github.com/python/cpython/commit/3e04cd268ee9a57f95dc78d8974b21a6fac3f666

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

STINNER Victor added the comment: Ok, I managed to reproduce the bug using this change: diff --git a/Lib/test/libregrtest/win_utils.py b/Lib/test/libregrtest/win_utils.py index f0c17b906f..78429faa89 100644 --- a/Lib/test/libregrtest/win_utils.py +++ b/Lib/test/libregrtest/win_utils.py @@

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

Change by STINNER Victor : -- pull_requests: +16138 pull_request: https://github.com/python/cpython/pull/16550 ___ Python tracker ___

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

David Bolen added the comment: I've confirmed the partial read with some local modifications, and the failures are always split between time stamp and value: Warning -- Failed to parse typeperf output: '"10/02/2019 17:42:26.229"' 0.0 Warning -- Missing first field: ,"0.00" 0.0 Adding

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

David Bolen added the comment: Oh, I agree it's just a warning, and I suspect few people look into warnings, but since it's not from an actual test, I'm not sure the overall build should be flagged. The manual typeperf looks fine, but there's no way I could tell visually how the I/O is

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

STINNER Victor added the comment: > Just an FYI that this change is generating warnings on my Windows 10 buildbot > with some regularity about a failure to parse testperf output, such as: Warning -- Failed to parse typeperf output: '"10/01/2019 07:58:50.056"' Aha, interesting. I added a

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

David Bolen added the comment: Just an FYI that this change is generating warnings on my Windows 10 buildbot with some regularity about a failure to parse testperf output, such as: Warning -- Failed to parse typeperf output: '"10/01/2019 07:58:50.056"' from

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

miss-islington added the comment: New changeset a72de9338882b8013a4bb8adb930fe3308682e28 by Miss Islington (bot) in branch '3.8': bpo-36670: regrtest bug fixes (GH-16537) https://github.com/python/cpython/commit/a72de9338882b8013a4bb8adb930fe3308682e28 --

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

Change by miss-islington : -- pull_requests: +16127 pull_request: https://github.com/python/cpython/pull/16538 ___ Python tracker ___

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

STINNER Victor added the comment: New changeset 2ea71a07d0a720707094ee55f78fd232c40724bc by Victor Stinner in branch 'master': bpo-36670: regrtest bug fixes (GH-16537) https://github.com/python/cpython/commit/2ea71a07d0a720707094ee55f78fd232c40724bc --

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

Change by STINNER Victor : -- pull_requests: +16126 pull_request: https://github.com/python/cpython/pull/16537 ___ Python tracker ___

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

Change by STINNER Victor : -- pull_requests: +16121 pull_request: https://github.com/python/cpython/pull/16530 ___ Python tracker ___

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

STINNER Victor added the comment: > We could avoid typeperf command by accessing directly performance counters: > (...) Honestly, it sounds very complicated. I don't think that it's worth it. With Lorenz's fix, regrtest now "just works". So I think that it's good enough. --

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

miss-islington added the comment: New changeset d6a92b55944bf1ef4992e4375f02a7132717bf53 by Miss Islington (bot) in branch '3.7': bpo-36670: Multiple regrtest bugfixes (GH-16511) https://github.com/python/cpython/commit/d6a92b55944bf1ef4992e4375f02a7132717bf53 --

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

STINNER Victor added the comment: Thanks Lorenz Mende for the nice bug report, investigating the issue and proposing fix. I wrote a PR based on your work with some minor changes. I included it in a large regrtest change to fix other bugs. regrtest should work again with locales other than

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

miss-islington added the comment: New changeset 6b4c70abcaa348c84a2c1bb6f5a46596cf358e36 by Miss Islington (bot) in branch '3.8': bpo-36670: Multiple regrtest bugfixes (GH-16511) https://github.com/python/cpython/commit/6b4c70abcaa348c84a2c1bb6f5a46596cf358e36 -- nosy:

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

Change by miss-islington : -- pull_requests: +16104 pull_request: https://github.com/python/cpython/pull/16514 ___ Python tracker ___

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

Change by miss-islington : -- pull_requests: +16103 pull_request: https://github.com/python/cpython/pull/16513 ___ Python tracker ___

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

STINNER Victor added the comment: New changeset 982bfa4da07b2e5749a0f4e68f99e972bcc3a549 by Victor Stinner in branch 'master': bpo-36670: Multiple regrtest bugfixes (GH-16511) https://github.com/python/cpython/commit/982bfa4da07b2e5749a0f4e68f99e972bcc3a549 --

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

Change by STINNER Victor : -- pull_requests: +16101 pull_request: https://github.com/python/cpython/pull/16511 ___ Python tracker ___

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

STINNER Victor added the comment: We could avoid typeperf command by accessing directly performance counters: (1) The Performance Data Helper (PDH) interface, which provides high-level access to data from both version 1 and version 2 performance counter providers. (2) The registry interface,

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

STINNER Victor added the comment: I tested attached win_utils.py on my Windows 10. I uses the command: ['typeperf', '"\\Système\\Longueur de la file du processeur"', '-si', '5'] Oh wait, counter names are now translated? Oh ok. -- ___ Python

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

STINNER Victor added the comment: On my Windows 10 version 1903, I get: C:\> typeperf "\System\Processor Queue Length" -si 1 Fin du programme, veuillez patienter... Erreur : aucun compteur valide. C:\> echo %errorlevel% -268435454 Error message in english: "Error: No valid counters" Because

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

Change by Lorenz Mende : -- pull_requests: +16036 pull_request: https://github.com/python/cpython/pull/16456 ___ Python tracker ___

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

Change by Lorenz Mende : -- keywords: +patch pull_requests: +15175 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/15488 ___ Python tracker

[issue36670] regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german)

Change by STINNER Victor : -- title: test suite broken due to cpu usage feature on win 10/ german -> regrtest: win_utils decodes typeperf output from the wrong encoding (test suite broken due to cpu usage feature on win 10/ german) ___ Python