[issue36713] duplicate method definition in Lib/ctypes/test/test_unicode.py

[Ezio Melotti]

Ezio Melotti  added the comment:

Fixed, thanks for the PR!

--
assignee:  -> ezio.melotti
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36713] duplicate method definition in Lib/ctypes/test/test_unicode.py

[Ezio Melotti]

Ezio Melotti  added the comment:


New changeset 25d8404c358f3b1cc8321cdc74049d45dcb8d014 by Ezio Melotti (Michele 
Angrisano) in branch '2.7':
bpo-36713: Rename duplicated method in test_unicode. (#13525)
https://github.com/python/cpython/commit/25d8404c358f3b1cc8321cdc74049d45dcb8d014


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36713] duplicate method definition in Lib/ctypes/test/test_unicode.py

[Michele Angrisano]

Change by Michele Angrisano :


--
keywords: +patch
pull_requests: +13440
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36713] duplicate method definition in Lib/ctypes/test/test_unicode.py

[Michele Angrisano]

Michele Angrisano  added the comment:

I'm on it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36713] duplicate method definition in Lib/ctypes/test/test_unicode.py

[Ezio Melotti]

Ezio Melotti  added the comment:

The duplicate method is gone from 3.5+, but it is still present on 2.7:
2.7/Lib/ctypes/test/test_unicode.py:96
2.7/Lib/ctypes/test/test_unicode.py:110

The one at line 96 should be renamed "test_ascii_strict".

Michele, do you want to work on a PR to fix it?

--
nosy: +ezio.melotti

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36713] duplicate method definition in Lib/ctypes/test/test_unicode.py

[Michele Angrisano]

Michele Angrisano  added the comment:

The proper link is this: cf448832ebca7ed34809168660fa96c3c61f8abb.

Sorry.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36713] duplicate method definition in Lib/ctypes/test/test_unicode.py

[Michele Angrisano]

Michele Angrisano  added the comment:

That method was already removed in cf44883.

--
nosy: +mangrisano

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36713] duplicate method definition in Lib/ctypes/test/test_unicode.py

[Batuhan]

Change by Batuhan :


--
title: uplicate method definition in Lib/ctypes/test/test_unicode.py -> 
duplicate method definition in Lib/ctypes/test/test_unicode.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com