[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

Roundup Robot added the comment: New changeset 2150eadb54c7 by Serhiy Storchaka in branch 'default': Remove old typo. https://hg.python.org/cpython/rev/2150eadb54c7 -- nosy: +python-dev ___ Python tracker

[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

Changes by Ezio Melotti ezio.melo...@gmail.com: ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3672 ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

Changes by hippietrail hippytr...@gmail.com: -- nosy: +hippietrail ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3672 ___ ___ Python-bugs-list

[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

Martin v. Löwis mar...@v.loewis.de added the comment: Reviewers: report_bugs.python.org, Benjamin, Message: Issues fixed in r72188. http://codereview.appspot.com/52081/diff/1/5 File Doc/library/codecs.rst (right): http://codereview.appspot.com/52081/diff/1/5#newcode326 Line 326: In addition,

[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

Changes by Martin v. Löwis mar...@v.loewis.de: Removed file: http://bugs.python.org/file13830/surrogates.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3672 ___

[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

Changes by Martin v. Löwis mar...@v.loewis.de: Added file: http://bugs.python.org/file13836/surrogates.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3672 ___

[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

Benjamin Peterson benja...@python.org added the comment: I think the new patch looks fine. -- assignee: benjamin.peterson - loewis ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3672 ___

[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

Benjamin Peterson benja...@python.org added the comment: Something I overlooked is that PyCodec_SurrogateErrors isn't exposed in any headers. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3672

[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

Martin v. Löwis mar...@v.loewis.de added the comment: Committed as r72208, blocked as r72209. As for PyCodec_SurrogateErrors: I'd rather make it static than expose it. -- resolution: - accepted status: open - closed ___ Python tracker

[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

Benjamin Peterson benja...@python.org added the comment: 2009/5/2 \Martin v. Löwis\ rep...@bugs.python.org@psf.upfronthosting.co.za: Martin v. Löwis mar...@v.loewis.de added the comment: Committed as r72208, blocked as r72209. As for PyCodec_SurrogateErrors: I'd rather make it static than

[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

Martin v. Löwis mar...@v.loewis.de added the comment: As for PyCodec_SurrogateErrors: I'd rather make it static than expose it. Why? All the other error handlers are exposed. Sure - but what for? IMO, they all shouldn't be exposed. -- ___ Python

[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

Benjamin Peterson benja...@python.org added the comment: 2009/5/2 \Martin v. Löwis\ rep...@bugs.python.org@psf.upfronthosting.co.za: Martin v. Löwis mar...@v.loewis.de added the comment: As for PyCodec_SurrogateErrors: I'd rather make it static than expose it. Why? All the other error

[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

Martin v. Löwis mar...@v.loewis.de added the comment: Here is a patch that implements this proposed approach. It introduces a surrogates error handler, useful only for the utf-8 codec. If this is accepted, the implementation of PEP 383 can be simplified significantly, essentially removing the

[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

Martin v. Löwis mar...@v.loewis.de added the comment: rietveld: http://codereview.appspot.com/52081 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3672 ___

[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

Changes by Martin v. Löwis mar...@v.loewis.de: Removed file: http://bugs.python.org/file13827/surrogates.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3672 ___

[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

Martin v. Löwis mar...@v.loewis.de added the comment: Fixed indexing error. -- Added file: http://bugs.python.org/file13830/surrogates.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3672

[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

Benjamin Peterson benja...@python.org added the comment: http://codereview.appspot.com/52081/diff/1/5 File Doc/library/codecs.rst (right): http://codereview.appspot.com/52081/diff/1/5#newcode326 Line 326: In addition, the following error handlers are specific to only selected In addition, the

[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

Marc-Andre Lemburg m...@egenix.com added the comment: On 2009-04-29 22:39, Martin v. Löwis @psf.upfronthosting.co.za wrote: Martin v. Löwis mar...@v.loewis.de added the comment: I think we could preserve the marshal format with yet another error handler - one that emits half surrogates into

[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

Marc-Andre Lemburg m...@egenix.com added the comment: While it's probably ok to fix the codecs, there's an issue which makes this difficult at least for the utf-8 codec: The marshal module uses utf-8 to write Unicode objects and these can and need to be able to store the full range of supported

[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

Martin v. Löwis mar...@v.loewis.de added the comment: I think we could preserve the marshal format with yet another error handler - one that emits half surrogates into their intuitive form. -- ___ Python tracker rep...@bugs.python.org

[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

Antoine Pitrou pit...@free.fr added the comment: We could fix it for 3.1, and perhaps leave 2.7 unchanged if some people rely on this (for whatever reason). -- nosy: +pitrou priority: - high stage: - test needed versions: +Python 3.1 ___ Python

[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

Changes by Antoine Pitrou pit...@free.fr: -- nosy: +lemburg, loewis ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3672 ___ ___ Python-bugs-list

[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

Changes by Jakub Wilk uba...@users.sf.net: -- nosy: +jwilk ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3672 ___ ___ Python-bugs-list mailing

[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

Changes by Ezio Melotti [EMAIL PROTECTED]: -- nosy: +ezio.melotti ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3672 ___ ___ Python-bugs-list mailing

[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

New submission from Adam Olsen [EMAIL PROTECTED]: The Unicode FAQ makes it quite clear that any surrogates in UTF-8 or UTF-32 should be treated as errors. Lone surrogates in UTF-16 should probably be treated as errors too (but only during encoding/decoding; unicode objects on UTF-16 builds

[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

Changes by Adam Olsen [EMAIL PROTECTED]: -- components: +Unicode type: - behavior ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3672 ___ ___