[issue36721] Add pkg-config python-3.8-embed and --embed to python3.8-config

2019-05-31 Thread Michael Haubenwallner 


Change by Michael Haubenwallner :


--
pull_requests: +13592
pull_request: https://github.com/python/cpython/pull/737

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36721] Add pkg-config python-3.8-embed and --embed to python3.8-config

2019-05-27 Thread STINNER Victor 


STINNER Victor  added the comment:

The initial issue has been fixed. As far as I know, all known issues have been 
fixed, so I close the issue. Thanks Miro for the help in reviews and tests!

FYI waf is already fixed for the future Python 3.8 beta1! It now attempts to 
use --embed for its "pyembed" config ;-) Miro wrote a fix:

https://gitlab.com/ita1024/waf/merge_requests/2236
https://gitlab.com/ita1024/waf/issues/2239

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36721] Add pkg-config python-3.8-embed and --embed to python3.8-config

2019-05-24 Thread STINNER Victor 


STINNER Victor  added the comment:


New changeset bc66faccb8a6140e7e07b5e67843b7f21152c144 by Victor Stinner in 
branch 'master':
bpo-36721: Fix pkg-config symbolic links on "make install" (GH-13551)
https://github.com/python/cpython/commit/bc66faccb8a6140e7e07b5e67843b7f21152c144


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36721] Add pkg-config python-3.8-embed and --embed to python3.8-config

2019-05-24 Thread STINNER Victor 


STINNER Victor  added the comment:

By the way, I'm not sure that the current layout of .pc files. The name 
"module" give a different configuration. Is that correct?

$ grep ^Libs: /opt/py38/lib/pkgconfig/python-3.8-embed.pc
Libs: -L${libdir} -lpython3.8

$ grep ^Libs: /opt/py38dbg/lib/pkgconfig/python-3.8-embed.pc
Libs: -L${libdir} -lpython3.8d

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36721] Add pkg-config python-3.8-embed and --embed to python3.8-config

2019-05-24 Thread STINNER Victor 


Change by STINNER Victor :


--
pull_requests: +13462

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36721] Add pkg-config python-3.8-embed and --embed to python3.8-config

2019-05-24 Thread STINNER Victor 


STINNER Victor  added the comment:

Miro commented my PR:
https://github.com/python/cpython/pull/13500#issuecomment-495510268

"""
This is what it gave me in Fedora, feels a bit inconsistent:

   /usr/lib64/pkgconfig/python-3.8-embed.pc
   /usr/lib64/pkgconfig/python-embed-3.8d.pc
   /usr/lib64/pkgconfig/python3-embed.pc
"""

I installed Python in release mode:

$ ./configure --enable-shared --prefix=/opt/py38 CFLAGS="-O0" && make && make 
install

It gives me:

vstinner@apu$ ls -l /opt/py38/lib/pkgconfig/
-rw-r--r--. 1 vstinner vstinner 312 24 mai   17:39 python-3.8-embed.pc
-rw-r--r--. 1 vstinner vstinner 286 24 mai   17:39 python-3.8.pc
lrwxrwxrwx. 1 vstinner vstinner  19 24 mai   17:39 python3-embed.pc -> 
python-3.8-embed.pc
lrwxrwxrwx. 1 vstinner vstinner  13 24 mai   17:39 python3.pc -> python-3.8.pc

Debug build:

$ ./configure --enable-shared --prefix=/opt/py38dbg --with-pydebug CFLAGS="-O0" 
&& make && make install

It gives me:

vstinner@apu$ ls -l /opt/py38dbg/lib/pkgconfig/
lrwxrwxrwx. 1 vstinner vstinner  13 24 mai   17:43 python-3.8d.pc -> 
python-3.8.pc
-rw-r--r--. 1 vstinner vstinner 317 24 mai   17:43 python-3.8-embed.pc
-rw-r--r--. 1 vstinner vstinner 290 24 mai   17:43 python-3.8.pc
lrwxrwxrwx. 1 vstinner vstinner  19 24 mai   17:43 python3-embed.pc -> 
python-3.8-embed.pc
lrwxrwxrwx. 1 vstinner vstinner  13 24 mai   17:43 python3.pc -> python-3.8.pc
lrwxrwxrwx. 1 vstinner vstinner  19 24 mai   17:43 python-embed-3.8d.pc -> 
python-embed-3.8.pc

Oh! "python-embed-3.8d.pc" is a broken symbolic link to "python-embed-3.8.pc" 
(which doesn't exist).


Ok, now I get it: I messed up in names of symbolic links :-) I wrote PR 13551 
which gives me the following files for a debug build:

vstinner@apu$ ls -l /opt/py38dbg/lib/pkgconfig/*.pc
lrwxrwxrwx. 1 vstinner vstinner  19 24 mai   17:51 
/opt/py38dbg/lib/pkgconfig/python-3.8d-embed.pc -> python-3.8-embed.pc
lrwxrwxrwx. 1 vstinner vstinner  13 24 mai   17:51 
/opt/py38dbg/lib/pkgconfig/python-3.8d.pc -> python-3.8.pc
-rw-r--r--. 1 vstinner vstinner 317 24 mai   17:51 
/opt/py38dbg/lib/pkgconfig/python-3.8-embed.pc
-rw-r--r--. 1 vstinner vstinner 290 24 mai   17:51 
/opt/py38dbg/lib/pkgconfig/python-3.8.pc
lrwxrwxrwx. 1 vstinner vstinner  19 24 mai   17:51 
/opt/py38dbg/lib/pkgconfig/python3-embed.pc -> python-3.8-embed.pc
lrwxrwxrwx. 1 vstinner vstinner  13 24 mai   17:51 
/opt/py38dbg/lib/pkgconfig/python3.pc -> python-3.8.pc


The format is now: "python" "version" "embed suffix".

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36721] Add pkg-config python-3.8-embed and --embed to python3.8-config

2019-05-22 Thread STINNER Victor 


STINNER Victor  added the comment:

Even if I'm not confident in my change (add --embed option), I chose to merge 
it anyway since at least "waf" build system is broken by my other changes (no 
longer link C extensions to libpython). I would like to get this change into 
Python 3.8 beta1 to attempt to fix most applications embedding Python.

Anyway, if something goes wrong, we still have plenty of time to decide what to 
do before 3.8.0 final, scheduled for 2019-10-21: 
https://www.python.org/dev/peps/pep-0569/

--

Since I merged my change, I reset the priority from Release Blocker to normal.

--
priority: release blocker -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36721] Add pkg-config python-3.8-embed and --embed to python3.8-config

2019-05-22 Thread STINNER Victor 


STINNER Victor  added the comment:


New changeset 0a8e57248b913851640c64375600f05157c997df by Victor Stinner in 
branch 'master':
bpo-36721: Add --embed option to python-config (GH-13500)
https://github.com/python/cpython/commit/0a8e57248b913851640c64375600f05157c997df


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36721] Add pkg-config python-3.8-embed and --embed to python3.8-config

2019-05-22 Thread STINNER Victor 


Change by STINNER Victor :


--
keywords: +patch
pull_requests: +13415
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36721] Add pkg-config python-3.8-embed and --embed to python3.8-config

2019-05-22 Thread STINNER Victor 


Change by STINNER Victor :


--
title: Add pkg-config python-3.8-embed -> Add pkg-config python-3.8-embed and 
--embed to python3.8-config

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com