[issue36854] GC operates out of global runtime state.

Change by STINNER Victor : -- pull_requests: +28766 pull_request: https://github.com/python/cpython/pull/30566 ___ Python tracker ___ __

[issue36854] GC operates out of global runtime state.

Change by STINNER Victor : -- pull_requests: +28765 pull_request: https://github.com/python/cpython/pull/30565 ___ Python tracker ___ __

[issue36854] GC operates out of global runtime state.

Change by STINNER Victor : -- pull_requests: +28764 pull_request: https://github.com/python/cpython/pull/30564 ___ Python tracker ___ __

[issue36854] GC operates out of global runtime state.

Change by STINNER Victor : -- components: +Subinterpreters -Interpreter Core ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue36854] GC operates out of global runtime state.

Eric Snow added the comment: On Wed, Dec 4, 2019 at 4:36 AM STINNER Victor wrote: > Each time I tried to fix a bug in the Python finalization, I introduced worse > bugs :-D :) > We cannot fix all bugs at once, we have to work incrementally. +1 > I like the idea of introducing workarounds

[issue36854] GC operates out of global runtime state.

STINNER Victor added the comment: Eric: """ Thanks so much for getting this done, Victor! Did I mention that you're my hero? :) """ You're welcome. I'm a believer that subinterpreters is one of the most realistic solution to make Python faster. I said it in my EuroPython keynote on CPython p

[issue36854] GC operates out of global runtime state.

STINNER Victor added the comment: Victor> I'm not fully happy with this solution Eric> Should we have an issue open for finding a better solution? Are there risks with what you did that we don't want long-term? Pablo made a small changes in my workaround, by calling _PyGC_CollectNoFail() a

[issue36854] GC operates out of global runtime state.

Change by Pablo Galindo Salgado : -- pull_requests: +16936 pull_request: https://github.com/python/cpython/pull/17455 ___ Python tracker ___ ___

[issue36854] GC operates out of global runtime state.

Eric Snow added the comment: Did I mention that you're my hero? :) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue36854] GC operates out of global runtime state.

Eric Snow added the comment: Thanks so much for getting this done, Victor! > I'm not fully happy with this solution Should we have an issue open for finding a better solution? Are there risks with what you did that we don't want long-term? -- __

[issue36854] GC operates out of global runtime state.

STINNER Victor added the comment: I close again the issue ;-) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue36854] GC operates out of global runtime state.

miss-islington added the comment: New changeset bff525566469021949910deec84e837306b79886 by Miss Islington (bot) in branch '3.7': bpo-36854: Fix reference counter in PyInit__testcapi() (GH-17338) https://github.com/python/cpython/commit/bff525566469021949910deec84e837306b79886 -- no

[issue36854] GC operates out of global runtime state.

Change by miss-islington : -- pull_requests: +16823 pull_request: https://github.com/python/cpython/pull/17339 ___ Python tracker ___ __

[issue36854] GC operates out of global runtime state.

STINNER Victor added the comment: New changeset 84c36c152a2bdf98f9cc7ce0e1db98e1f442a05e by Victor Stinner in branch '3.8': bpo-36854: Fix reference counter in PyInit__testcapi() (GH-17338) https://github.com/python/cpython/commit/84c36c152a2bdf98f9cc7ce0e1db98e1f442a05e -- ___

[issue36854] GC operates out of global runtime state.

STINNER Victor added the comment: > New changeset 310e2d25170a88ef03f6fd31efcc899fe062da2c by Victor Stinner in > branch 'master': > bpo-36854: Fix refleak in subinterpreter (GH-17331) I'm not fully happy with this solution, but at least, it allows me to move on to the next tasks to implemen

[issue36854] GC operates out of global runtime state.

Change by STINNER Victor : -- pull_requests: +16822 pull_request: https://github.com/python/cpython/pull/17338 ___ Python tracker ___ __

[issue36854] GC operates out of global runtime state.

STINNER Victor added the comment: New changeset 310e2d25170a88ef03f6fd31efcc899fe062da2c by Victor Stinner in branch 'master': bpo-36854: Fix refleak in subinterpreter (GH-17331) https://github.com/python/cpython/commit/310e2d25170a88ef03f6fd31efcc899fe062da2c -- __

[issue36854] GC operates out of global runtime state.

Change by STINNER Victor : -- pull_requests: +16818 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/17331 ___ Python tracker ___ __

[issue36854] GC operates out of global runtime state.

STINNER Victor added the comment: > test_atexit leaked [3988, 3986, 3988] references, sum=11962 The following patch fix it: diff --git a/Python/pylifecycle.c b/Python/pylifecycle.c index 7591f069b4..f088ef0bce 100644 --- a/Python/pylifecycle.c +++ b/Python/pylifecycle.c @@ -1210,6 +1210,15 @@

[issue36854] GC operates out of global runtime state.

STINNER Victor added the comment: Even if the test is simplified to the following code, it does still leak: def test_callbacks_leak(self): _testcapi.run_in_subinterp("pass") -- ___ Python tracker __

[issue36854] GC operates out of global runtime state.

STINNER Victor added the comment: I reopen the issue, the change introduced a reference leak :-( Example: $ ./python -m test -R 3:3 test_atexit -m test.test_atexit.SubinterpreterTest.test_callbacks_leak 0:00:00 load avg: 1.12 Run tests sequentially 0:00:00 load avg: 1.12 [1/1] test_atexit beg

[issue36854] GC operates out of global runtime state.

STINNER Victor added the comment: It's now done in the future Python 3.9! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.9 -Python 3.8 ___ Python tracker

[issue36854] GC operates out of global runtime state.

STINNER Victor added the comment: New changeset 7247407c35330f3f6292f1d40606b7ba6afd5700 by Victor Stinner in branch 'master': bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287) https://github.com/python/cpython/commit/7247407c35330f3f6292f1d40606b7ba6afd5700 -- __

[issue36854] GC operates out of global runtime state.

Change by STINNER Victor : -- pull_requests: +16780 pull_request: https://github.com/python/cpython/pull/17287 ___ Python tracker ___ __

[issue36854] GC operates out of global runtime state.

STINNER Victor added the comment: New changeset 67e0de6f0b060ac8f373952f0ca4b3117ad5b611 by Victor Stinner in branch 'master': bpo-36854: gcmodule.c gets its state from tstate (GH-17285) https://github.com/python/cpython/commit/67e0de6f0b060ac8f373952f0ca4b3117ad5b611 -- __

[issue36854] GC operates out of global runtime state.

Change by STINNER Victor : -- pull_requests: +16778 pull_request: https://github.com/python/cpython/pull/17285 ___ Python tracker ___ __

[issue36854] GC operates out of global runtime state.

STINNER Victor added the comment: New changeset 9da7430675ceaeae5abeb9c9f7cd552b71b3a93a by Victor Stinner in branch 'master': bpo-36854: Clear the current thread later (GH-17279) https://github.com/python/cpython/commit/9da7430675ceaeae5abeb9c9f7cd552b71b3a93a -- nosy: +vstinner _

[issue36854] GC operates out of global runtime state.

Change by STINNER Victor : -- pull_requests: +16772 pull_request: https://github.com/python/cpython/pull/17279 ___ Python tracker ___ __

[issue36854] GC operates out of global runtime state.

Change by Paulo Henrique Silva : -- nosy: +phsilva ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue36854] GC operates out of global runtime state.

Change by Eric Snow : -- keywords: +patch pull_requests: +13130 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue36854] GC operates out of global runtime state.

New submission from Eric Snow : (also see #24554) We need to move GC state from _PyRuntimeState to PyInterpreterState. -- assignee: eric.snow components: Interpreter Core messages: 341911 nosy: eric.snow, pablogsal priority: normal severity: normal status: open title: GC operates out o