[issue37050] Remove expr_text from ast node FormattedValue

[Eric V. Smith]

Change by Eric V. Smith :


--
priority: release blocker -> 
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37050] Remove expr_text from ast node FormattedValue

[Eric V. Smith]

Eric V. Smith  added the comment:


New changeset 6f6ff8a56518a80da406aad6ac8364c046cc7f18 by Eric V. Smith in 
branch 'master':
bpo-37050: Remove expr_text from FormattedValue ast node, use Constant node 
instead (GH-13597)
https://github.com/python/cpython/commit/6f6ff8a56518a80da406aad6ac8364c046cc7f18


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37050] Remove expr_text from ast node FormattedValue

[Eric V. Smith]

Change by Eric V. Smith :


--
keywords: +patch
pull_requests: +13504
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/13597

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37050] Remove expr_text from ast node FormattedValue

[Matthias Bussonnier]

Change by Matthias Bussonnier :


--
nosy: +mbussonn

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37050] Remove expr_text from ast node FormattedValue

[Eric V. Smith]

New submission from Eric V. Smith :

I added the expr_text optional field to the FormattedValue node in order to 
implement the '=' feature of f-strings (see issue 36817).

However, the expr_text field isn't strictly needed. Instead, the same feature 
could be added with another Constant string node child of the JoinedStr node.

I'm going to remove expr_text and use another Constant in order to remove this 
change to the 3.8 ast nodes. I have a patch mostly worked out, I'll have it 
ready in the next day or two. I want to get this in to 3.8 beta 1, because 
otherwise we're stuck with the expr_text implementation.

--
assignee: eric.smith
components: Interpreter Core
messages: 343511
nosy: eric.smith, lukasz.langa
priority: release blocker
severity: normal
stage: needs patch
status: open
title: Remove expr_text from ast node FormattedValue
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com