[issue37055] Numerous warnings with blake2 module

Change by Christian Heimes : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> compile error ___ Python tracker ___

[issue37055] Numerous warnings with blake2 module

Pablo Galindo Salgado added the comment: Can we close this issue or remove the release blocker? -- ___ Python tracker ___ ___

[issue37055] Numerous warnings with blake2 module

Christian Heimes added the comment: I hope that I'll be able to drop our sha3 copy soonish. OpenSSL 1.0.2 reaches EOL by the end of the year. In theory I could require >= 1.1.1 in 3.9... -- ___ Python tracker

[issue37055] Numerous warnings with blake2 module

miss-islington added the comment: New changeset 2bb4fc379b14377e1cdcefad8d5f2fbbb1172524 by Miss Islington (bot) in branch '3.8': bpo-37055: fix warnings in _blake2 module (GH-14646) https://github.com/python/cpython/commit/2bb4fc379b14377e1cdcefad8d5f2fbbb1172524 --

[issue37055] Numerous warnings with blake2 module

Gregory P. Smith added the comment: oh well, no pony for us this decade. :) -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue37055] Numerous warnings with blake2 module

Change by miss-islington : -- pull_requests: +15207 pull_request: https://github.com/python/cpython/pull/15525 ___ Python tracker ___

[issue37055] Numerous warnings with blake2 module

miss-islington added the comment: New changeset b27cbec801e17a13d7fef49116a8fc279930d2b1 by Miss Islington (bot) (Inada Naoki) in branch 'master': bpo-37055: fix warnings in _blake2 module (GH-14646) https://github.com/python/cpython/commit/b27cbec801e17a13d7fef49116a8fc279930d2b1

[issue37055] Numerous warnings with blake2 module

Christian Heimes added the comment: Although OpenSSL comes with blake2, it does not support any of the advanced features like keying, personalization, or tree hashing. See https://github.com/openssl/openssl/issues/980 -- ___ Python tracker

[issue37055] Numerous warnings with blake2 module

Gregory P. Smith added the comment: META: Do we still have platforms we support that we do not also require a modern enough OpenSSL version in order for CPython to build that'd provide blake2 for us? I'd love to ditch maintenance of our own copies of the various secure hash function

[issue37055] Numerous warnings with blake2 module

Pablo Galindo Salgado added the comment: Related to this, the blake2 function (declared as static inline) is not used, which makes the Solaris and compilers unhappy. Patch for reference: --- a/Modules/_blake2/impl/blake2.h +++ b/Modules/_blake2/impl/blake2.h @@ -169,11 +169,6 @@

[issue37055] Numerous warnings with blake2 module

Łukasz Langa added the comment: This is marked as a release blocker. The last beta is scheduled for Monday. Please decide how to proceed ASAP. -- nosy: +lukasz.langa priority: deferred blocker -> release blocker ___ Python tracker

[issue37055] Numerous warnings with blake2 module

Change by Inada Naoki : -- keywords: +patch pull_requests: +14457 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14646 ___ Python tracker ___

[issue37055] Numerous warnings with blake2 module

Christian Heimes added the comment: The file blake2ns.h renames some of the exported constants to prefix them with PyBlake2_foo. The file needs to be updated every time the sources are updated. I'll look into the issue. -- nosy: +christian.heimes, inada.naoki priority: normal ->

[issue37055] Numerous warnings with blake2 module

New submission from Rémi Lapeyre : Issue 33164 (commit 51aa35e9e17eef60d04add9619fe2a7eb938358c) introduced numerous new warnings on MacOS: /Users/remi/src/cpython/Modules/_blake2/impl/blake2b.c:192:9: warning: 'blake2b_init' macro redefined [-Wmacro-redefined] #define blake2b_init