[issue37146] opcode cache for LOAD_GLOBAL emits false alarm in memory leak hunting

STINNER Victor added the comment: New changeset 9f672a52f55ce198d5689b5771948350028b4a3b by Victor Stinner in branch 'master': bpo-37146: Move _PyEval_DeactivateOpCache() to the internal C API (GH-24786) https://github.com/python/cpython/commit/9f672a52f55ce198d5689b5771948350028b4a3b -

[issue37146] opcode cache for LOAD_GLOBAL emits false alarm in memory leak hunting

Change by STINNER Victor : -- pull_requests: +23552 pull_request: https://github.com/python/cpython/pull/24786 ___ Python tracker ___ __

[issue37146] opcode cache for LOAD_GLOBAL emits false alarm in memory leak hunting

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue37146] opcode cache for LOAD_GLOBAL emits false alarm in memory leak hunting

Pablo Galindo Salgado added the comment: New changeset af5fa13ef6f648fc7a7a33a7556db13887e7d643 by Pablo Galindo in branch 'master': bpo-37146: Deactivate opcode cache only when using huntrleaks in the test suite (GH-24643) https://github.com/python/cpython/commit/af5fa13ef6f648fc7a7a33a7556

[issue37146] opcode cache for LOAD_GLOBAL emits false alarm in memory leak hunting

Change by Pablo Galindo Salgado : -- pull_requests: +23428 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/24643 ___ Python tracker ___ ___

[issue37146] opcode cache for LOAD_GLOBAL emits false alarm in memory leak hunting

Change by Christian Heimes : -- components: +Interpreter Core -SSL nosy: -christian.heimes title: SSl Securité version 3.9.2 -> opcode cache for LOAD_GLOBAL emits false alarm in memory leak hunting type: security -> behavior ___ Python tracker

[issue37146] opcode cache for LOAD_GLOBAL emits false alarm in memory leak hunting

Pablo Galindo Salgado added the comment: > Or maybe need a generic -X flag to tell Python that libregrtest is tracking > leaks, since we might need to change other parameters than only the opcode > cache size. I think we should go this way, maybe even less "public". If we add a -X, then it

[issue37146] opcode cache for LOAD_GLOBAL emits false alarm in memory leak hunting

Yury Selivanov added the comment: > Giving the ability to control the cache size, at least at Python startup, is > one option. I'd really prefer not to allow users to control cache sizes. There's basically no point in that; the only practically useful thing is to enable or disable it. -

[issue37146] opcode cache for LOAD_GLOBAL emits false alarm in memory leak hunting

STINNER Victor added the comment: > (Or perhaps provide an -X flag to disable it without the need to recompile.) Giving the ability to control the cache size, at least at Python startup, is one option. Or maybe need a generic -X flag to tell Python that libregrtest is tracking leaks, since

[issue37146] opcode cache for LOAD_GLOBAL emits false alarm in memory leak hunting

STINNER Victor added the comment: I reopen the issue (but I'm not interested by trying to fix it). -- resolution: fixed -> status: closed -> open ___ Python tracker ___ _

[issue37146] opcode cache for LOAD_GLOBAL emits false alarm in memory leak hunting

Guido van Rossum added the comment: Please revert this and use a separate build flag (e.g. DISABLE_INLINE_CACHES) for the refleaks run. (Or perhaps provide an -X flag to disable it without the need to recompile.) I am developing new inline cache ideas and of course I need to run in debug mo

[issue37146] opcode cache for LOAD_GLOBAL emits false alarm in memory leak hunting

Change by STINNER Victor : -- pull_requests: +23365 pull_request: https://github.com/python/cpython/pull/24582 ___ Python tracker ___ __

[issue37146] opcode cache for LOAD_GLOBAL emits false alarm in memory leak hunting

Yury Selivanov added the comment: > It seems like nobody came up with a solution for the debug mode since June. I > close the issue. Reopen it if you would like to propose a solution. I think the only solution is to have a flag to disable optimizations, inlcluding this one. --

[issue37146] opcode cache for LOAD_GLOBAL emits false alarm in memory leak hunting

STINNER Victor added the comment: It seems like nobody came up with a solution for the debug mode since June. I close the issue. Reopen it if you would like to propose a solution. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed

[issue37146] opcode cache for LOAD_GLOBAL emits false alarm in memory leak hunting

STINNER Victor added the comment: INADA-san wrote PR 13787 to disable opcache when Python is compiled in debug mode. Pablo and me approved the change, so I merged it. Pablo wrote a more robust solution, PR 13789, to disable opcache only in regrtest, to look for memory leaks. But INADA-san ha

[issue37146] opcode cache for LOAD_GLOBAL emits false alarm in memory leak hunting

STINNER Victor added the comment: New changeset eddef861b49f1635222a9e1771231c34a807debf by Victor Stinner (Inada Naoki) in branch 'master': bpo-37146: disable opcache when Py_DEBUG is defined (GH-13787) https://github.com/python/cpython/commit/eddef861b49f1635222a9e1771231c34a807debf -

[issue37146] opcode cache for LOAD_GLOBAL emits false alarm in memory leak hunting

Change by Pablo Galindo Salgado : -- pull_requests: +13673 pull_request: https://github.com/python/cpython/pull/13789 ___ Python tracker ___ ___

[issue37146] opcode cache for LOAD_GLOBAL emits false alarm in memory leak hunting

Change by Inada Naoki : -- keywords: +patch pull_requests: +13671 stage: -> patch review pull_request: https://github.com/python/cpython/pull/13787 ___ Python tracker ___

[issue37146] opcode cache for LOAD_GLOBAL emits false alarm in memory leak hunting

New submission from STINNER Victor : opcode cache for LOAD_GLOBAL introduced false alarm in memory leak hunting (python3 -m test -R 3:3 ...). => opcache: bpo-26219. Before the change: $ git checkout 91234a16367b56ca03ee289f7c03a34d4cfec4c8^ $ make && ./python -m test -R 3:3 test_pprint ...