[issue37179] asyncio loop.start_tls() provide support for TLS in TLS

[Andrew Svetlov]

Change by Andrew Svetlov :


--
resolution:  -> duplicate
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37179] asyncio loop.start_tls() provide support for TLS in TLS

[Kumar Aditya]

Change by Kumar Aditya :


--
type:  -> enhancement
versions: +Python 3.11 -Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37179] asyncio loop.start_tls() provide support for TLS in TLS

[Kumar Aditya]

Kumar Aditya  added the comment:

This has been fixed in the main branch since 
https://github.com/python/cpython/pull/31275, this can be closed now.

--
nosy: +kumaraditya303

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37179] asyncio loop.start_tls() provide support for TLS in TLS

[Jordan Borean]

Change by Jordan Borean :


--
pull_requests: +26517
pull_request: https://github.com/python/cpython/pull/28073

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37179] asyncio loop.start_tls() provide support for TLS in TLS

[Jordan Borean]

Change by Jordan Borean :


--
pull_requests: +25050
pull_request: https://github.com/python/cpython/pull/26454

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37179] asyncio loop.start_tls() provide support for TLS in TLS

[Jordan Borean]

Jordan Borean  added the comment:

Fantastic thanks, I'll keep watching the issue in the background as it sounds 
like it's under control.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37179] asyncio loop.start_tls() provide support for TLS in TLS

[Andrew Svetlov]

Andrew Svetlov  added the comment:

Thanks for the reminder.
You are correct, the mentioned PR should set 
_SSLProtocolTransport._start_tls_compatible to True

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37179] asyncio loop.start_tls() provide support for TLS in TLS

[Jordan Borean]

Jordan Borean  added the comment:

I'm looking through the PR https://github.com/python/cpython/pull/17975 and it 
doesn't look like it addresses this particular problem. The code for start_tls 
https://github.com/python/cpython/blob/d2a8e69c2c605fbaa3656a5f99aa8d295f74c80e/Lib/asyncio/base_events.py#L1210-L1212
 has a check for the attribute '_start_tls_compatible' but 
_SSLProtocolTransport 
(https://github.com/python/cpython/blob/master/Lib/asyncio/sslproto.py) does 
not set this. The PR mentioned https://github.com/python/cpython/pull/17975 
does not seem to touch any of this so I would assume the problem is still there?

I also installed 3.10.0a7 and this problem still persists when I call 
loop.start_tls with my SSL writer transport.

--
nosy: +jborean93

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37179] asyncio loop.start_tls() provide support for TLS in TLS

[Yury Selivanov]

Yury Selivanov  added the comment:

> The aiohttp issue says they won't fix this until asyncio supports it. Kinda 
> understand that.

I saw you opened an issue with aiohttp to allow this and they're open to it. I 
hope that will get some movement. It also would be a big test for uvloop's (and 
3.10 asyncio) TLS implementation.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37179] asyncio loop.start_tls() provide support for TLS in TLS

[Cooper Lees]

Cooper Lees  added the comment:

Yury, only problem with that is aiohttp hard blocks HTTPS proxies period. The 
aiohttp issue says they won't fix this until asyncio supports it. Kinda 
understand that.

[cooper:~]$ ./aioclient.par
HTTPS proxies https://fwdproxy:8082 are not supported, ignoring
^CTraceback (most recent call last):
  File "", line 37, in 
  File "", line 35, in __run
  File "/usr/local/fbcode/platform007/lib/python3.7/runpy.py", line 193, in 
_run_module_as_main
"__main__", mod_spec)
  File "/usr/local/fbcode/platform007/lib/python3.7/runpy.py", line 85, in 
_run_code
exec(code, run_globals)
  File 
"/data/users/cooper/fbsource/fbcode/buck-out/dev/gen/ti/fwdproxy/client_samples/py/aioclient#link-tree/ti/fwdproxy/client_samples/py/aioclient.py",
 line 56, in 
asyncio.run(run_example())
  File "/usr/local/fbcode/platform007/lib/python3.7/asyncio/runners.py", line 
43, in run
return loop.run_until_complete(main)
  File "uvloop/loop.pyx", line 1450, in uvloop.loop.Loop.run_until_complete
  File "uvloop/loop.pyx", line 1443, in uvloop.loop.Loop.run_until_complete
  File "uvloop/loop.pyx", line 1351, in uvloop.loop.Loop.run_forever
  File "uvloop/loop.pyx", line 519, in uvloop.loop.Loop._run
  File "uvloop/handles/poll.pyx", line 213, in uvloop.loop.__on_uvpoll_event
  File "uvloop/cbhandles.pyx", line 90, in uvloop.loop.Handle._run
  File "uvloop/cbhandles.pyx", line 73, in uvloop.loop.Handle._run
  File "uvloop/loop.pyx", line 359, in uvloop.loop.Loop._read_from_self
  File "uvloop/loop.pyx", line 364, in uvloop.loop.Loop._invoke_signals
  File "uvloop/loop.pyx", line 339, in uvloop.loop.Loop._ceval_process_signals
KeyboardInterrupt

Kept stack trace to prove I was using uvloop :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37179] asyncio loop.start_tls() provide support for TLS in TLS

[Cooper Lees]

Change by Cooper Lees :


--
keywords: +patch
pull_requests: +20556
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/17975

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37179] asyncio loop.start_tls() provide support for TLS in TLS

[Yury Selivanov]

Yury Selivanov  added the comment:

Looks like https://github.com/python/cpython/pull/17975 was forgotten and was 
never committed to 3.9. So it's 3.10 now.

Best bet for you is to use uvloop which should support the feature.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37179] asyncio loop.start_tls() provide support for TLS in TLS

[Cooper Lees]

Cooper Lees  added the comment:

Another bump since I've waiting over a year. Any plans for this? Will it make 
3.10? Anything I can do?

--
versions: +Python 3.10 -Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37179] asyncio loop.start_tls() provide support for TLS in TLS

[Cooper Lees]

Cooper Lees  added the comment:

@fantix - Is there anything I can do to help this progress. I'd be happy to 
potentially even do parts of the back porting if you're swamped. Would just 
need some guidance.

I need this as I'm looking to add auth to some internal HTTP(S) proxies I use 
and in order to allow aiohttp to be able to do client TLS auth, this is 
required.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37179] asyncio loop.start_tls() provide support for TLS in TLS

[Fantix King]

Change by Fantix King :


--
nosy: +fantix

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37179] asyncio loop.start_tls() provide support for TLS in TLS

[Yury Selivanov]

Yury Selivanov  added the comment:

Yeah, we have the SSL reimplementation ready to be backported from uvloop to 
cpython.  Fantix, the original author, should be able to do that soon.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37179] asyncio loop.start_tls() provide support for TLS in TLS

[Cooper Lees]

New submission from Cooper Lees :

aiohttp would love to be able to support HTTPS Proxy servers. To do this, 
asyncio itself needs to be able to provide TLS within TLS connections.

Can we add this support to asyncio please.

(I tried search but could not find a related issue - Please merge if there is)

--
components: asyncio
messages: 344846
nosy: asvetlov, cooperlees, yselivanov
priority: normal
severity: normal
status: open
title: asyncio loop.start_tls() provide support for TLS in TLS
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com