[issue37363] Additional PEP578 hooks

Stéphane Wirtel added the comment: the http module is covered by the audit events -- ___ Python tracker ___ ___ Python-bugs-list

[issue37363] Additional PEP578 hooks

Stéphane Wirtel added the comment: New changeset 927b841c215a1ca36c9b3203eadc67ce05b1ed07 by Saiyang Gou in branch 'master': bpo-37363: Add audit events to the `http.client` module (GH-21321) https://github.com/python/cpython/commit/927b841c215a1ca36c9b3203eadc67ce05b1ed07 --

[issue37363] Additional PEP578 hooks

Change by Stéphane Wirtel : -- versions: +Python 3.10 -Python 3.8, Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue37363] Additional PEP578 hooks

Stéphane Wirtel added the comment: Hi @Christian, When you have time for my last question. Thank you, -- ___ Python tracker ___

[issue37363] Additional PEP578 hooks

Change by Saiyang Gou : -- nosy: +gousaiyang nosy_count: 4.0 -> 5.0 pull_requests: +20472 pull_request: https://github.com/python/cpython/pull/21321 ___ Python tracker ___

[issue37363] Additional PEP578 hooks

Stéphane Wirtel added the comment: @Christian, I have merged your PR for the audit events, but I have not closed this issue, I suppose there will be other PRs for this issue. -- nosy: +matrixise ___ Python tracker

[issue37363] Additional PEP578 hooks

miss-islington added the comment: New changeset 2f01cf61874aa42eebe49d51d4881792d9c4 by Miss Islington (bot) in branch '3.8': bpo-37363: Document internal audit events (GH-14663) https://github.com/python/cpython/commit/2f01cf61874aa42eebe49d51d4881792d9c4 --

[issue37363] Additional PEP578 hooks

miss-islington added the comment: New changeset ed4b3216e59df4806e5ef63b3357fc577a9443d7 by Miss Islington (bot) (Christian Heimes) in branch 'master': bpo-37363: Document internal audit events (GH-14663) https://github.com/python/cpython/commit/ed4b3216e59df4806e5ef63b3357fc577a9443d7

[issue37363] Additional PEP578 hooks

Change by miss-islington : -- pull_requests: +15668 pull_request: https://github.com/python/cpython/pull/16046 ___ Python tracker ___

[issue37363] Additional PEP578 hooks

Change by Christian Heimes : -- pull_requests: +14471 pull_request: https://github.com/python/cpython/pull/14663 ___ Python tracker ___

[issue37363] Additional PEP578 hooks

Steve Dower added the comment: All that's left here right now is some xmlrpc events, unless we can think of any more stdlib modules that should have them? -- ___ Python tracker

[issue37363] Additional PEP578 hooks

miss-islington added the comment: New changeset 746992c1ae4c632220563d3fe54123498f93db1d by Miss Islington (bot) in branch '3.8': bpo-37363: Add audit events on startup for the run commands (GH-14524) https://github.com/python/cpython/commit/746992c1ae4c632220563d3fe54123498f93db1d

[issue37363] Additional PEP578 hooks

Change by miss-islington : -- pull_requests: +14349 pull_request: https://github.com/python/cpython/pull/14536 ___ Python tracker ___

[issue37363] Additional PEP578 hooks

Steve Dower added the comment: New changeset e226e83d36dfc7220d836fb7a249ce18e70cb4a6 by Steve Dower in branch 'master': bpo-37363: Add audit events on startup for the run commands (GH-14524) https://github.com/python/cpython/commit/e226e83d36dfc7220d836fb7a249ce18e70cb4a6 --

[issue37363] Additional PEP578 hooks

Change by Steve Dower : -- pull_requests: +14337 pull_request: https://github.com/python/cpython/pull/14524 ___ Python tracker ___

[issue37363] Additional PEP578 hooks

Steve Dower added the comment: FWIW, I tried looking into how we can prevent or detect monkeypatching of "sys.audit", and the answer seems to be that we need to define a custom type for the sys module and for sys.__dict__. I'm not prepared to do that yet, and IMHO there are enough way to

[issue37363] Additional PEP578 hooks

miss-islington added the comment: New changeset 8763d43a9558b345af6a3a298afa18e7d3b42fd0 by Miss Islington (bot) in branch '3.8': bpo-37363: Add audit events for a range of modules (GH-14301) https://github.com/python/cpython/commit/8763d43a9558b345af6a3a298afa18e7d3b42fd0 -- nosy:

[issue37363] Additional PEP578 hooks

Steve Dower added the comment: New changeset 60419a7e96577cf783b3b45bf3984f9fb0d7ddff by Steve Dower in branch 'master': bpo-37363: Add audit events for a range of modules (GH-14301) https://github.com/python/cpython/commit/60419a7e96577cf783b3b45bf3984f9fb0d7ddff --

[issue37363] Additional PEP578 hooks

Change by miss-islington : -- pull_requests: +14165 pull_request: https://github.com/python/cpython/pull/14345 ___ Python tracker ___

[issue37363] Additional PEP578 hooks

Christian Heimes added the comment: I'll add hooks to ssl module for wrap_socket and wrap_bio. -- ___ Python tracker ___ ___

[issue37363] Additional PEP578 hooks

Steve Dower added the comment: PR 14301 has at least a few hooks for most of the modules above. I think xmlrpc deserves some, but it is not as immediately obvious where to put them as for the other modules. smtpd also still needs looking at. --

[issue37363] Additional PEP578 hooks

Change by Steve Dower : -- keywords: +patch pull_requests: +14125 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/14301 ___ Python tracker

[issue37363] Additional PEP578 hooks

New submission from Steve Dower : We should also (see whether we should) add audit hooks for the following modules: * configparser * crypt * ensurepip * ftplib * glob * http * imaplib * nntplib * pdb * poplib * runpy * shutil * smtpd * smtplib * socketserver * sqlite3 * telnetlib * webbrowser