[issue37562] PEP 590 implementation may have introduced a performance regression

2019-08-05 Thread Pablo Galindo Salgado 


Change by Pablo Galindo Salgado :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37562] PEP 590 implementation may have introduced a performance regression

2019-08-05 Thread Jeroen Demeyer 


Jeroen Demeyer  added the comment:

Please close

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37562] PEP 590 implementation may have introduced a performance regression

2019-07-15 Thread Jeroen Demeyer 


Jeroen Demeyer  added the comment:

PR 14782 (backport of PR 13781) fixes the regression for me.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37562] PEP 590 implementation may have introduced a performance regression

2019-07-15 Thread Jeroen Demeyer 


Change by Jeroen Demeyer :


--
versions:  -Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37562] PEP 590 implementation may have introduced a performance regression

2019-07-15 Thread Jeroen Demeyer 


Change by Jeroen Demeyer :


--
pull_requests: +14579
pull_request: https://github.com/python/cpython/pull/14782

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37562] PEP 590 implementation may have introduced a performance regression

2019-07-15 Thread STINNER Victor 


STINNER Victor  added the comment:

> can we backport more of the PEP 590 commits to 3.8? Or will the release 
> manager complain?

I would opt for a case by case discussion. Would you be able to identify which 
master commits have the most significant impact on performance for builtin 
functions?

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37562] PEP 590 implementation may have introduced a performance regression

2019-07-15 Thread Jeroen Demeyer 


Jeroen Demeyer  added the comment:

I did some benchmarks WITHOUT PGO (simply because it's much faster to compile 
and therefore easier to test things out).

The command I used for testing is
./python -m perf timeit --duplicate 200 -s 'f = len; x = ()' 'f(x)'

* d30da5dd9a8a965cf24a22bbaff8a5b1341c2944 (before PEP 590)
  Mean +- std dev: 25.1 ns +- 0.2 ns
* aacc77fbd77640a8f03638216fa09372cc21673d (first commit of PEP 590)
  Mean +- std dev: 29.3 ns +- 0.9 ns
* b8e198a5d09ca876b87baaf6efd2b2e7c9e3a0b3 (3.8 branch)
  Mean +- std dev: 29.5 ns +- 0.3 ns
* cd6e83b4810549c308ab2d7315dbab526e35ccf6 (master)
  Mean +- std dev: 25.1 ns +- 0.2 ns

So there does seem to be a regression with 3.8 but not with 3.9. I don't know 
what to do with this... can we backport more of the PEP 590 commits to 3.8? Or 
will the release manager complain?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37562] PEP 590 implementation may have introduced a performance regression

2019-07-13 Thread Mark Shannon 


Change by Mark Shannon :


--
keywords: +patch
pull_requests: +14529
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/14735

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37562] PEP 590 implementation may have introduced a performance regression

2019-07-12 Thread Jeroen Demeyer 


Jeroen Demeyer  added the comment:

I will certainly have a look and try a few things, but it will probably be next 
week.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37562] PEP 590 implementation may have introduced a performance regression

2019-07-11 Thread Pablo Galindo Salgado 


Change by Pablo Galindo Salgado :


--
title: PEP 590 implementation introduced a performance regression -> PEP 590 
implementation may have introduced a performance regression

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com