[issue37628] IDLE: Fix Font sample (config dialog) geometry

[Tal Einat]

Tal Einat  added the comment:

Terry, thanks for reviewing, helping get this fully ready, and merging.

Kyle, thanks for the kind feedback, it's truly heart-warming!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37628] IDLE: Fix Font sample (config dialog) geometry

[Kyle Stanley]

Kyle Stanley  added the comment:

Correction: By "scroll the list of fonts" I meant that I went through all of 
them by holding the down arrow from the top of the list (Adobe Courier - Z003), 
scrolling through the list wouldn't accomplish anything. I did that starting 
with a font size 40 and a few other ones.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37628] IDLE: Fix Font sample (config dialog) geometry

[Kyle Stanley]

Kyle Stanley  added the comment:

After PR-14958 was merged, I tested the latest development version of CPython 
on Arch Linux 5.2.3 and I can confirm that the "Settings" window no longer 
scales past the edge of the screen. Instead, the window size remains fixed and 
the scroll area dynamically changes to allow for preview of the enlarged font 
sample. To make sure it worked for all of the fonts, I scrolled the list of 
font faces with a size setting of 40 (as well as some other sizes, but not 
every possible combination). The window size remained the same and the "Font 
Sample" preview scaled dynamically with the scrollbar in every instance. 

This recent round of recent updates to the IDLE have added some fantastic QoL 
changes, nicely done taleinat and terry!

--
nosy: +aeros167

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37628] IDLE: Fix Font sample (config dialog) geometry

[miss-islington]

miss-islington  added the comment:


New changeset 171019354aa2c717af2e7b2c90aec7b9724f7282 by Miss Islington (bot) 
in branch '3.8':
bpo-37628: Fix IDLE config sample sizes (GH-14958)
https://github.com/python/cpython/commit/171019354aa2c717af2e7b2c90aec7b9724f7282


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37628] IDLE: Fix Font sample (config dialog) geometry

[miss-islington]

miss-islington  added the comment:


New changeset 0242eb3fa7818eb078c0915a4b844c5a2070b810 by Miss Islington (bot) 
in branch '3.7':
bpo-37628: Fix IDLE config sample sizes (GH-14958)
https://github.com/python/cpython/commit/0242eb3fa7818eb078c0915a4b844c5a2070b810


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37628] IDLE: Fix Font sample (config dialog) geometry

[miss-islington]

Change by miss-islington :


--
pull_requests: +14748
pull_request: https://github.com/python/cpython/pull/14981

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37628] IDLE: Fix Font sample (config dialog) geometry

[miss-islington]

Change by miss-islington :


--
pull_requests: +14747
pull_request: https://github.com/python/cpython/pull/14980

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37628] IDLE: Fix Font sample (config dialog) geometry

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset 3221a63c69268a9362802371a616f49d522a5c4f by Terry Jan Reedy (Tal 
Einat) in branch 'master':
bpo-37628: Fix IDLE config sample sizes (#14958)
https://github.com/python/cpython/commit/3221a63c69268a9362802371a616f49d522a5c4f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37628] IDLE: Fix Font sample (config dialog) geometry

[Tal Einat]

Tal Einat  added the comment:

See proposed fix in PR GH-14958.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37628] IDLE: Fix Font sample (config dialog) geometry

[Tal Einat]

Change by Tal Einat :


--
keywords: +patch
pull_requests: +14726
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/14958

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37628] IDLE: Fix Font sample (config dialog) geometry

[Terry J. Reedy]

Terry J. Reedy  added the comment:

And maybe a horizontal scroll.  In any case, line wrap should be off.  Feel 
free to whip up a minimal change PR that we can merge before Monday.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37628] IDLE: Fix Font sample (config dialog) geometry

[Tal Einat]

Tal Einat  added the comment:

Since it's a text widget, it would be simple and rather intuitive to make it 
scrollable.  We could then make its size set according to the size of the 
config dialog window, rather than the other way around.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37628] IDLE: Fix Font sample (config dialog) geometry

[Terry J. Reedy]

Terry J. Reedy  added the comment:

I consider it a bug for *IDLE* to place and size windows so that the bottom of 
the window is hidden.  (If users, perhaps temporarily, move a window down so 
that the bottom is hidden, that is their business.)

This is especially bad for the Settings dialog because the Enter and Escape 
keys are not bound to the Ok and Cancel handlers, as with at least most of the 
other dialogs.  This should be easy to fix.

The general problem in preventing over-sizing and misplacement is that, 
as far as Tal and I know, tk will only tell us the full size of a particular 
screen, not the current, usually reduced, view size.

Until about a month ago, ZoomHeight used platform-specific expressions from 
long ago that do not, in general, work now.  For issue #37039, Tal's solution 
was to 'calibrate' each screen the first time a window is zoomed on a screen in 
a session.  The window is maximized, the pixel height is saved, and the window 
is narrowed to what is was.  The saved height is used for subsequent zooms.  
Maximizing works because the OS + tk maximize to the current view size, 
depending on the current screen settings.

I suggested then the possibility of IDLE opening with a maximized splash 
screen.  Tal objected that this a) did not solve the problem of multiple 
screens, and b) would unnecessarily bother people who never zoom.  But zoom 
height is not the only feature that needs this knowledge.

On my machine with 45 line shell/editor windows, Shell is initially placed too 
low if I open IDLE one particular way.  I'll leave that to another issue.

For the config dialog, there is a geometry bug independent of the font sample 
content.  Even if the box is cleared, the dialog expands with font size.  
Fixing this is also a priority.

To completely solve geometry issues, we again need to know the screen's view 
height.  If not available, we would have to momentarily maximize the dialog as 
now done with zoom height.

The height of the Setting dialog is the maximum of the page sizes.  For normal 
font sizes, the font page is the shortest of the first 4, meaning that is has 
the most extra space.  The Highlight and General pages seem to be equally 
tallest.  So adding settings to the latter will increase the minimum size.

For 3.7.3, the dialog already fills the view height between menu line and icon 
bar on my Macbook Air.  But it is opened a quarter of the way down, so that a 
quarter of the dialog is covered.  This is another geometry bug.  On this 
machine, the dialog should be opened flush up against the app menu.  But 
hard-coding that for all machines would likely annoy most people who do not 
need that positioning.

I am worried that the addition of two more items to the General page, for zoom 
height and line numbers, will make the dialog too tall for the available space. 
 When 3.8.0a3 is released, I will check. 

I am thinking of moving indent size, revised, to the General page and moving 
Additional Help Sources, possibly flattened a bit, to the Font page.  Perhaps 
we should try to make the pages wider rather than taller.

--
nosy: +taleinat
stage:  -> needs patch
title: IDLE Font Sample distracting and too large -> IDLE: Fix Font sample 
(config dialog) geometry
type:  -> behavior
versions: +Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com