[issue37681] warning: ‘no_sanitize_thread’

[STINNER Victor]

STINNER Victor  added the comment:

Thanks Hai Shi for the bug report and the fix.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37681] warning: ‘no_sanitize_thread’

[miss-islington]

miss-islington  added the comment:


New changeset 15b6d0a712c08557a605f49034f8ad392985144c by Miss Islington (bot) 
in branch '3.7':
bpo-37681: no_sanitize_thread support from GCC 5.1 (GH-15096)
https://github.com/python/cpython/commit/15b6d0a712c08557a605f49034f8ad392985144c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37681] warning: ‘no_sanitize_thread’

[miss-islington]

miss-islington  added the comment:


New changeset 364a1d3125af6c0ff0a4bd2c8afe70fd38f30456 by Miss Islington (bot) 
in branch '3.8':
bpo-37681: no_sanitize_thread support from GCC 5.1 (GH-15096)
https://github.com/python/cpython/commit/364a1d3125af6c0ff0a4bd2c8afe70fd38f30456


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37681] warning: ‘no_sanitize_thread’

[miss-islington]

Change by miss-islington :


--
pull_requests: +14992
pull_request: https://github.com/python/cpython/pull/15270

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37681] warning: ‘no_sanitize_thread’

[miss-islington]

Change by miss-islington :


--
pull_requests: +14993
pull_request: https://github.com/python/cpython/pull/15271

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37681] warning: ‘no_sanitize_thread’

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 7e479c82218450255572e3f5fa1549dc283901ea by Victor Stinner (Hai 
Shi) in branch 'master':
bpo-37681: no_sanitize_thread support from GCC 5.1 (GH-15096)
https://github.com/python/cpython/commit/7e479c82218450255572e3f5fa1549dc283901ea


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37681] warning: ‘no_sanitize_thread’

[hai shi]

Change by hai shi :


--
keywords: +patch
pull_requests: +14843
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/15096

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37681] warning: ‘no_sanitize_thread’

[hai shi]

hai shi  added the comment:

I checked no_sanitize_thread in some gcc manual of different version. And looks 
the no_sanitize_thread from gcc 5.1.0 [3](not 4.8)

[1] 
https://gcc.gnu.org/onlinedocs/gcc-4.9.3/gcc/Function-Attributes.html#Function-Attributes
[2] 
https://gcc.gnu.org/onlinedocs/gcc-4.9.4/gcc/Function-Attributes.html#Function-Attributes
[3] 
https://gcc.gnu.org/onlinedocs/gcc-5.1.0/gcc/Function-Attributes.html#Function-Attributes
[4] 
https://gcc.gnu.org/onlinedocs/gcc-5.2.0/gcc/Function-Attributes.html#Function-Attributes

Alexey have some descr of TSAN in https://bugs.python.org/issue35204(Looks `GCC 
introduced TSan together with ASan in 4.8` is wrong)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37681] warning: ‘no_sanitize_thread’

[hai shi]

hai shi  added the comment:

thanks, Ronald. Let me check the process by the upstairs refs.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37681] warning: ‘no_sanitize_thread’

[Ronald Oussoren]

Ronald Oussoren  added the comment:

A GCC export should be able to tell more, but the warning should be harmless.

Objects/obmalloc.c says that the thread sanitizer is available from GCC 4.8, 
but for some reason it isn't on your system. This seems to be a bug in 
obmalloc.c:  The GCC 4.8.5 docs don't mention this attribute [1], while the 5.5 
docs do [2]

[1] 
https://gcc.gnu.org/onlinedocs/gcc-4.8.5/gcc/Function-Attributes.html#Function-Attributes
[2] 
https://gcc.gnu.org/onlinedocs/gcc-5.5.0/gcc/Function-Attributes.html#Function-Attributes

There's a couple of releases between 4.8.5 and 5.5.0, I don't know which one 
introduces this function attribute. Once that version is know it should be 
fairly easy to provide a patch that only uses the attribute for new enough 
compilers.

--
stage:  -> needs patch
type:  -> compile error
versions: +Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37681] warning: ‘no_sanitize_thread’

[hai shi]

hai shi  added the comment:

I want to build the cpython of master.
My platform and compiler info: Linux version 3.10.0-957.1.3.el7.x86_64 
(mockbu...@kbuilder.bsys.centos.org) (gcc version 4.8.5 20150623 (Red Hat 
4.8.5-36) (GCC) ) #1 SMP Thu Nov 29 14:49:43 UTC 2018

Looks not all platform get this info.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37681] warning: ‘no_sanitize_thread’

[Ronald Oussoren]

Ronald Oussoren  added the comment:

- Which python version do you try to build?
- What platform are you on?
- Which compiler and compiler version do you use?

--
nosy: +ronaldoussoren

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37681] warning: ‘no_sanitize_thread’

[hai shi]

New submission from hai shi :

When I build cpython, I got this error:
Objects/obmalloc.c:1414:1: warning: ‘no_sanitize_thread’ attribute directive 
ignored [-Wattributes]
 {
 ^
I removed the _Py_NO_SANITIZE_THREAD and build again, this warning dismissed. 
not sure ASAN、TSAN and MSAN have some inner relation?

--
components: Build
messages: 348441
nosy: shihai1991
priority: normal
severity: normal
status: open
title: warning: ‘no_sanitize_thread’

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com