[issue37785] argparse uses %s in gettext calls causing xgettext warnings

[Julien Palard]

Change by Julien Palard :


--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37785] argparse uses %s in gettext calls causing xgettext warnings

[Julien Palard]

Julien Palard  added the comment:


New changeset f14fcbf2995b43c8607a1448402633ac558a745f by Julien Palard in 
branch '3.7':
Revert "bpo-37785: Fix xgettext warning in argparse (GH-15161)" (GH-16082)
https://github.com/python/cpython/commit/f14fcbf2995b43c8607a1448402633ac558a745f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37785] argparse uses %s in gettext calls causing xgettext warnings

[Julien Palard]

Change by Julien Palard :


--
pull_requests: +15704
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/16082

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37785] argparse uses %s in gettext calls causing xgettext warnings

[Julien Palard]

Julien Palard  added the comment:

Thanks for noticing Serhiy!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37785] argparse uses %s in gettext calls causing xgettext warnings

[Julien Palard]

Julien Palard  added the comment:

OK to revert in 3.7, got your point.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37785] argparse uses %s in gettext calls causing xgettext warnings

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

I think it would be safer to revert changes in maintained versions. At least in 
3.7.

--
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37785] argparse uses %s in gettext calls causing xgettext warnings

[miss-islington]

miss-islington  added the comment:


New changeset 8750dfe09eaec24231e19962d17d171c323794ad by Miss Islington (bot) 
in branch '3.8':
bpo-37785: Fix xgettext warning in argparse (GH-15161)
https://github.com/python/cpython/commit/8750dfe09eaec24231e19962d17d171c323794ad


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37785] argparse uses %s in gettext calls causing xgettext warnings

[Julien Palard]

Change by Julien Palard :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37785] argparse uses %s in gettext calls causing xgettext warnings

[miss-islington]

miss-islington  added the comment:


New changeset b50eff65906f8e9b4597cb0128ea1729341346fc by Miss Islington (bot) 
in branch '3.7':
bpo-37785: Fix xgettext warning in argparse (GH-15161)
https://github.com/python/cpython/commit/b50eff65906f8e9b4597cb0128ea1729341346fc


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37785] argparse uses %s in gettext calls causing xgettext warnings

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

It is a backward incompatible change. It will break existing translations. It 
should not be backported.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37785] argparse uses %s in gettext calls causing xgettext warnings

[miss-islington]

Change by miss-islington :


--
pull_requests: +15703
pull_request: https://github.com/python/cpython/pull/16081

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37785] argparse uses %s in gettext calls causing xgettext warnings

[miss-islington]

Change by miss-islington :


--
pull_requests: +15702
pull_request: https://github.com/python/cpython/pull/16080

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37785] argparse uses %s in gettext calls causing xgettext warnings

[Julien Palard]

Julien Palard  added the comment:


New changeset 42671aea2db6cbc54369617da0fd3545048e0a45 by Julien Palard (Jakub 
Kulík) in branch 'master':
bpo-37785: Fix xgettext warning in argparse (GH-15161)
https://github.com/python/cpython/commit/42671aea2db6cbc54369617da0fd3545048e0a45


--
nosy: +mdk

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37785] argparse uses %s in gettext calls causing xgettext warnings

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
nosy: +paul.j3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37785] argparse uses %s in gettext calls causing xgettext warnings

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Hi Eric,

This is with reference to https://bugs.python.org/issue10528.

I've looked at the PR and it's ready for a core-review: 
https://github.com/python/cpython/pull/15161

Can you please take a look at this?

Many thanks!

--
nosy: +bethard, eric.araujo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37785] argparse uses %s in gettext calls causing xgettext warnings

[Jakub Kulik]

Jakub Kulik  added the comment:

Thanks,

I see; this is not a change for security only stage. I merged your suggestion.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37785] argparse uses %s in gettext calls causing xgettext warnings

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Hi Jakub,

Welcome and thank you for contributing. I've added a suggestion on your pull 
request.


Python 3.6 and Python 3.5 are in security fixes stage, so I've removed those 
tags from this bug.

--
nosy: +CuriousLearner
type:  -> behavior
versions:  -Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37785] argparse uses %s in gettext calls causing xgettext warnings

[Jakub Kulik]

Change by Jakub Kulik :


--
keywords: +patch
pull_requests: +14894
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/15161

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37785] argparse uses %s in gettext calls causing xgettext warnings

[Jakub Kulik]

Change by Jakub Kulik :


--
title: argparse uses %s in gettext calls -> argparse uses %s in gettext calls 
causing xgettext warnings

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com