[issue37793] argparse uses "container object", should be "iterable"

Srinivas Nyayapati added the comment: I understand eric.smith. I can close this PR. I currently have the following 3 other PR's waiting for review on github - https://github.com/python/cpython/pull/15180 https://github.com/python/cpython/pull/15170

[issue37793] argparse uses "container object", should be "iterable"

Eric V. Smith added the comment: Sorry, shireenrao, but I'm closing this. It's entirely my error: I misread the source where it was converting this to a list. The requirement is really that it be something you can iterate over multiple times, and supports "in". I guess "container object" is

[issue37793] argparse uses "container object", should be "iterable"

Srinivas Nyayapati added the comment: Not at all. I just started contributing to cpython 2 days ago and finally got the hang of it and was able to push this without any issues on my side. So either way I would still call this a win for me :) --

[issue37793] argparse uses "container object", should be "iterable"

Eric V. Smith added the comment: Actually, I might have mislead you on this. I now think that plain iterators won't work. I'm still researching this, I'll get back to you on it. I apologize if it turns out I wasted your time. -- ___ Python

[issue37793] argparse uses "container object", should be "iterable"

Srinivas Nyayapati added the comment: Done. Thank you. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37793] argparse uses "container object", should be "iterable"

Change by Srinivas Nyayapati : -- keywords: +patch pull_requests: +14909 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15178 ___ Python tracker

[issue37793] argparse uses "container object", should be "iterable"

Eric V. Smith added the comment: shireenrao: yes, please! As they say, PR's accepted! I'll warn you that I think the only way this could become newcomer-unfriendly is if there are objections that "iterable" is too much jargon for the argparse documentation. But I'll argue that there's a

[issue37793] argparse uses "container object", should be "iterable"

Srinivas Nyayapati added the comment: Can I work on this? -- nosy: +shireenrao ___ Python tracker ___ ___ Python-bugs-list mailing

[issue37793] argparse uses "container object", should be "iterable"

New submission from Eric V. Smith : https://docs.python.org/3/library/argparse.html#choices says "These can be handled by passing a container object as the choices keyword argument to add_argument()". I think this should be "iterable" instead. Internally, argparse reads the iterable and