[issue38020] os.path.realpath crashes in Windows Store package

2019-09-03 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue38020] os.path.realpath crashes in Windows Store package

2019-09-03 Thread miss-islington
miss-islington added the comment: New changeset 54dac6c0f4fa24d03025c45899ee7c5f2a4c367e by Miss Islington (bot) in branch '3.8': bpo-38020: Fixes crash in os.readlink() on Windows (GH-15663) https://github.com/python/cpython/commit/54dac6c0f4fa24d03025c45899ee7c5f2a4c367e -- nosy:

[issue38020] os.path.realpath crashes in Windows Store package

2019-09-03 Thread Steve Dower
Steve Dower added the comment: New changeset 993ac92418839427d4068d6ae8e618b06b5d9294 by Steve Dower in branch 'master': bpo-38020: Fixes crash in os.readlink() on Windows (GH-15663) https://github.com/python/cpython/commit/993ac92418839427d4068d6ae8e618b06b5d9294 --

[issue38020] os.path.realpath crashes in Windows Store package

2019-09-03 Thread miss-islington
Change by miss-islington : -- pull_requests: +15330 pull_request: https://github.com/python/cpython/pull/15665 ___ Python tracker ___

[issue38020] os.path.realpath crashes in Windows Store package

2019-09-03 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch pull_requests: +15328 stage: test needed -> patch review pull_request: https://github.com/python/cpython/pull/15663 ___ Python tracker

[issue38020] os.path.realpath crashes in Windows Store package

2019-09-03 Thread Steve Dower
Steve Dower added the comment: I forgot to initialize the result object in readlink() on Windows, and so when we hit the failure path it returns garbage. Attempting to DECREF that garbage fails. The call to readlink() fails in the Store app because sys.executable is not a readable link. It

[issue38020] os.path.realpath crashes in Windows Store package

2019-09-03 Thread Steve Dower
New submission from Steve Dower : When installed via the Store, "python3.8 -c 'import sysconfig'" crashes hard. So far, I've discovered it's inside an os.path.realpath() call, and appears to be a refcounting issue (double DECREF I think), but haven't gotten any further yet. I'm looking into