[issue38043] small cleanups in Unicode normalization code

2019-09-10 Thread Raymond Hettinger
Raymond Hettinger added the comment: This is mostly harmless but I'm concerned that we're encouraging a new Python developer to: * churn code in mostly minor ways, irrelevant to users * altering code long known to be stable, increasing the risk of introducing new bugs or performance

[issue38043] small cleanups in Unicode normalization code

2019-09-10 Thread STINNER Victor
Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38043] small cleanups in Unicode normalization code

2019-09-10 Thread Benjamin Peterson
Benjamin Peterson added the comment: New changeset 1ad0c776cb640be9f19c8019bbf34bb4aba312ad by Benjamin Peterson (Greg Price) in branch 'master': bpo-38043: Move unicodedata.normalize tests into test_unicodedata. (GH-15712)

[issue38043] small cleanups in Unicode normalization code

2019-09-09 Thread Benjamin Peterson
Benjamin Peterson added the comment: New changeset 7669cb8b21c7c9cef758609c44017c09d1ce4658 by Benjamin Peterson (Greg Price) in branch 'master': bpo-38043: Use `bool` for boolean flags on is_normalized_quickcheck. (GH-15711)

[issue38043] small cleanups in Unicode normalization code

2019-09-05 Thread Greg Price
Change by Greg Price : -- pull_requests: +15368 pull_request: https://github.com/python/cpython/pull/15558 ___ Python tracker ___

[issue38043] small cleanups in Unicode normalization code

2019-09-05 Thread Greg Price
Change by Greg Price : -- pull_requests: +15367 pull_request: https://github.com/python/cpython/pull/15712 ___ Python tracker ___

[issue38043] small cleanups in Unicode normalization code

2019-09-05 Thread Greg Price
Change by Greg Price : -- keywords: +patch pull_requests: +15366 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15711 ___ Python tracker ___

[issue38043] small cleanups in Unicode normalization code

2019-09-05 Thread Greg Price
New submission from Greg Price : Benjamin noticed in reviewing GH-15558 (for #37966) several points where the existing code around Unicode normalization can be improved: * on the `QuickcheckResult` enum: > Maybe `makeunicodedata.py` should output this enum (with better name namespacing) *