[issue38118] Valgrind warnings when running tokenize.py

[STINNER Victor]

STINNER Victor  added the comment:

I reopen the issue, the PyUnicode_Decode warning is not fixed yet.

vstinner@apu$ echo|PYTHONMALLOC=malloc valgrind ./python Lib/tokenize.py
==6832== Memcheck, a memory error detector
==6832== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==6832== Using Valgrind-3.15.0 and LibVEX; rerun with -h for copyright info
==6832== Command: ./python Lib/tokenize.py
==6832== 
==6832== Conditional jump or move depends on uninitialised value(s)
==6832==at 0x4D87E9: PyUnicode_Decode (unicodeobject.c:3395)
==6832==by 0x4D8E6E: PyUnicode_FromEncodedObject (unicodeobject.c:3268)
==6832==by 0x4D9283: unicode_new (unicodeobject.c:15125)
==6832==by 0x49271B: type_call (typeobject.c:969)
==6832==by 0x440E97: _PyObject_MakeTpCall (call.c:167)
==6832==by 0x42D6D3: _PyObject_Vectorcall (abstract.h:104)
==6832==by 0x42D6D3: call_function (ceval.c:4984)
==6832==by 0x42D6D3: _PyEval_EvalFrameDefault (ceval.c:3496)
==6832==by 0x4216CA: function_code_fastcall (call.c:292)
==6832==by 0x4411B5: _PyObject_FastCallDict (call.c:109)
==6832==by 0x441413: _PyObject_Call_Prepend (call.c:447)
==6832==by 0x497320: slot_tp_init (typeobject.c:6772)
==6832==by 0x492767: type_call (typeobject.c:989)
==6832==by 0x440E97: _PyObject_MakeTpCall (call.c:167)
==6832== 
1,0-1,1:NL '\n'   
2,0-2,0:ENDMARKER  '' 
==6832== 
==6832== HEAP SUMMARY:
==6832== in use at exit: 1,179,135 bytes in 8,467 blocks
==6832==   total heap usage: 93,677 allocs, 85,210 frees, 12,109,969 bytes 
allocated
==6832== 
==6832== LEAK SUMMARY:
==6832==definitely lost: 0 bytes in 0 blocks
==6832==indirectly lost: 0 bytes in 0 blocks
==6832==  possibly lost: 454,934 bytes in 1,972 blocks
==6832==still reachable: 724,201 bytes in 6,495 blocks
==6832== suppressed: 0 bytes in 0 blocks
==6832== Rerun with --leak-check=full to see details of leaked memory
==6832== 
==6832== Use --track-origins=yes to see where uninitialised values come from
==6832== For lists of detected and suppressed errors, rerun with: -s
==6832== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)

--
resolution: duplicate -> 
status: closed -> open
superseder: off-by-one error in PyState_AddModule -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38118] Valgrind warnings when running tokenize.py

[Benjamin Peterson]

Change by Benjamin Peterson :


--
resolution:  -> duplicate
stage:  -> resolved
status: open -> closed
superseder:  -> off-by-one error in PyState_AddModule

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38118] Valgrind warnings when running tokenize.py

[STINNER Victor]

STINNER Victor  added the comment:

==30746== Conditional jump or move depends on uninitialised value(s)
==30746==at 0x4DC8FF: PyState_AddModule (pystate.c:707)

Oh, this issue looks like a duplicate of bpo-38124 which has just been fixed by:

New changeset 39de95b746c990e6a2fe9af5fad01747f58b2e5f by Benjamin Peterson in 
branch 'master':
closes bpo-38124: Fix bounds check in PyState_AddModule. (GH-16007)
https://github.com/python/cpython/commit/39de95b746c990e6a2fe9af5fad01747f58b2e5f

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38118] Valgrind warnings when running tokenize.py

[STINNER Victor]

New submission from STINNER Victor :

Running tokenize.py in Valgrind emits 2 warnings:

$ ./configure --with-valgrind
$ make
$ echo|PYTHONMALLOC=malloc valgrind ./python Lib/tokenize.py

(A)

==30746== Conditional jump or move depends on uninitialised value(s)
==30746==at 0x4A01F7: PyUnicode_Decode (unicodeobject.c:3395)
==30746==by 0x4A01F7: PyUnicode_Decode (unicodeobject.c:3350)
==30746==by 0x4A062E: PyUnicode_FromEncodedObject (unicodeobject.c:3268)
==30746==by 0x4A090D: unicode_new (unicodeobject.c:15125)
==30746==by 0x46F515: type_call (typeobject.c:969)
==30746==by 0x435F82: _PyObject_MakeTpCall (call.c:167)
==30746==by 0x422B3A: _PyObject_Vectorcall (abstract.h:104)
==30746==by 0x422B3A: _PyObject_Vectorcall (abstract.h:96)
==30746==by 0x422B3A: call_function (ceval.c:4984)
==30746==by 0x423C26: _PyEval_EvalFrameDefault (ceval.c:3496)
==30746==by 0x4217D2: function_code_fastcall (call.c:292)
==30746==by 0x4360FC: _PyObject_FastCallDict (call.c:109)
==30746==by 0x436309: _PyObject_Call_Prepend (call.c:447)
==30746==by 0x4731F0: slot_tp_init (typeobject.c:6767)
==30746==by 0x46F562: type_call (typeobject.c:989)

(B)

==30746== Conditional jump or move depends on uninitialised value(s)
==30746==at 0x4DC8FF: PyState_AddModule (pystate.c:707)
==30746==by 0x485A5E1: PyInit_zlib (zlibmodule.c:1472)
==30746==by 0x4CA49C: _PyImport_LoadDynamicModuleWithSpec (importdl.c:164)
==30746==by 0x4C8462: _imp_create_dynamic_impl (import.c:2292)
==30746==by 0x4C8462: _imp_create_dynamic (import.c.h:330)
==30746==by 0x570783: cfunction_vectorcall_FASTCALL (methodobject.c:382)
==30746==by 0x435ACD: PyVectorcall_Call (call.c:203)
==30746==by 0x42424F: do_call_core (ceval.c:5031)
==30746==by 0x42424F: _PyEval_EvalFrameDefault (ceval.c:3557)
==30746==by 0x4AF4CF: _PyEval_EvalCodeWithName (ceval.c:4296)
==30746==by 0x435D3F: _PyFunction_Vectorcall (call.c:355)
==30746==by 0x422AA8: _PyObject_Vectorcall (abstract.h:106)
==30746==by 0x422AA8: call_function (ceval.c:4984)
==30746==by 0x428E51: _PyEval_EvalFrameDefault (ceval.c:3465)
==30746==by 0x4217D2: function_code_fastcall (call.c:292)

Warning (A) goes away when Python is compiled with gcc -O1.

Warning (B) is still present when Python is compiled with gcc -O0.


It's unclear to me if it's a false alarm or a real issue.


On Fedora, the issue can be seen with:

   echo|valgrind python3 /usr/lib64/python3.7/tokenize.py

On Fedora 30, python3 is Python 3.7.4.


Downstream Fedora issue: https://bugzilla.redhat.com/show_bug.cgi?id=1751208

--
components: Interpreter Core
messages: 351939
nosy: vstinner
priority: normal
severity: normal
status: open
title: Valgrind warnings when running tokenize.py
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com