[issue38137] hashopenssl fails to compile on MacOS

[Christian Heimes]

Christian Heimes  added the comment:

I don't have access to macOS. Did the PR fix the issue?

--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38137] hashopenssl fails to compile on MacOS

[Ronald Oussoren]

Change by Ronald Oussoren :


--
components: +macOS
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38137] hashopenssl fails to compile on MacOS

[Ronald Oussoren]

Ronald Oussoren  added the comment:

can this issue be closed?

--
nosy: +ronaldoussoren

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38137] hashopenssl fails to compile on MacOS

[miss-islington]

miss-islington  added the comment:


New changeset 36c29e444d6bc0e31b46509610d3fb7cff74f2c2 by Miss Islington (bot) 
(Stéphane Wirtel) in branch '3.8':
[3.8] bpo-38137: Re-add OpenSSL 1.0.2 compat (GH-16051) (GH-16057)
https://github.com/python/cpython/commit/36c29e444d6bc0e31b46509610d3fb7cff74f2c2


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38137] hashopenssl fails to compile on MacOS

[Stéphane Wirtel]

Change by Stéphane Wirtel :


--
pull_requests: +15680
pull_request: https://github.com/python/cpython/pull/16057

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38137] hashopenssl fails to compile on MacOS

[miss-islington]

miss-islington  added the comment:


New changeset 9a4963b932a087b78596cca0b8394ac898faa490 by Miss Islington (bot) 
(Christian Heimes) in branch 'master':
bpo-38137: Re-add OpenSSL 1.0.2 compat (GH-16051)
https://github.com/python/cpython/commit/9a4963b932a087b78596cca0b8394ac898faa490


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38137] hashopenssl fails to compile on MacOS

[Christian Heimes]

Change by Christian Heimes :


--
keywords: +patch
pull_requests: +15675
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/16051

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38137] hashopenssl fails to compile on MacOS

[Pablo Galindo Salgado]

New submission from Pablo Galindo Salgado :

I get this when compiling CPython master

Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:89:19: error: implicit 
declaration of function 'EVP_MD_CTX_new' is invalid in C99 
[-Werror,-Wimplicit-function-declaration]
retval->ctx = EVP_MD_CTX_new();
  ^
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:89:19: warning: this 
function declaration is not a prototype [-Wstrict-prototypes]
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:89:17: warning: 
incompatible integer to pointer conversion assigning to 'EVP_MD_CTX *' (aka 
'struct env_md_ctx_st *') from 'int' [-Wint-conversion]
retval->ctx = EVP_MD_CTX_new();
^ 
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:126:5: error: implicit 
declaration of function 'EVP_MD_CTX_free' is invalid in C99 
[-Werror,-Wimplicit-function-declaration]
EVP_MD_CTX_free(self->ctx);
^
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:126:5: note: did you 
mean 'EVP_MD_CTX_create'?
/usr/local/opt/openssl/include/openssl/evp.h:588:13: note: 'EVP_MD_CTX_create' 
declared here
EVP_MD_CTX *EVP_MD_CTX_create(void);
^
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:126:5: warning: this 
function declaration is not a prototype [-Wstrict-prototypes]
EVP_MD_CTX_free(self->ctx);
^
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:179:16: error: implicit 
declaration of function 'EVP_MD_CTX_new' is invalid in C99 
[-Werror,-Wimplicit-function-declaration]
temp_ctx = EVP_MD_CTX_new();
   ^
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:179:14: warning: 
incompatible integer to pointer conversion assigning to 'EVP_MD_CTX *' (aka 
'struct env_md_ctx_st *') from 'int' [-Wint-conversion]
temp_ctx = EVP_MD_CTX_new();
 ^ 
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:195:5: error: implicit 
declaration of function 'EVP_MD_CTX_free' is invalid in C99 
[-Werror,-Wimplicit-function-declaration]
EVP_MD_CTX_free(temp_ctx);
^
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:213:16: error: implicit 
declaration of function 'EVP_MD_CTX_new' is invalid in C99 
[-Werror,-Wimplicit-function-declaration]
temp_ctx = EVP_MD_CTX_new();
   ^
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:213:14: warning: 
incompatible integer to pointer conversion assigning to 'EVP_MD_CTX *' (aka 
'struct env_md_ctx_st *') from 'int' [-Wint-conversion]
temp_ctx = EVP_MD_CTX_new();
 ^ 
/Users/pgalindo3/github/cpython/Modules/_hashopenssl.c:229:5: error: implicit 
declaration of function 'EVP_MD_CTX_free' is invalid in C99 
[-Werror,-Wimplicit-function-declaration]
EVP_MD_CTX_free(temp_ctx);


❯ openssl version
LibreSSL 2.6.5

--
components: Build
messages: 352161
nosy: christian.heimes, pablogsal
priority: normal
severity: normal
status: open
title: hashopenssl fails to compile on MacOS
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com