[issue38266] Revert bpo-37878: Make PyThreadState_DeleteCurrent() Internal

STINNER Victor added the comment: > This is great -- thank you for handling this so quickly. Thanks for testing the master branch and reporting regressions quickly as well ;-) -- ___ Python tracker

[issue38266] Revert bpo-37878: Make PyThreadState_DeleteCurrent() Internal

Wenzel Jakob added the comment: This is great -- thank you for handling this so quickly. -- ___ Python tracker ___ ___

[issue38266] Revert bpo-37878: Make PyThreadState_DeleteCurrent() Internal

Change by Ned Deily : -- keywords: -3.8regression versions: -Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue38266] Revert bpo-37878: Make PyThreadState_DeleteCurrent() Internal

STINNER Victor added the comment: > Since this sounds like a regression being introduced by 3.8.0, should the > reversion be included in 3.8.0 final or can it wait for 3.8.1? Oh, in fact, the change was only made in the master branch: after the 3.8 branch was created. The 3.8 branch still

[issue38266] Revert bpo-37878: Make PyThreadState_DeleteCurrent() Internal

STINNER Victor added the comment: New changeset 8855e47d09d4db1206c65b24efc8ad0df585ac46 by Victor Stinner (Joannah Nanjekye) in branch 'master': bpo-38266: Revert bpo-37878: Make PyThreadState_DeleteCurrent() Internal (GH-16558)

[issue38266] Revert bpo-37878: Make PyThreadState_DeleteCurrent() Internal

STINNER Victor added the comment: > Since this sounds like a regression being introduced by 3.8.0, should the > reversion be included in 3.8.0 final or can it wait for 3.8.1? IMHO PR 16558 is safe: it adds code which already existed in Python 2.7, and likely previously. For me it's a low

[issue38266] Revert bpo-37878: Make PyThreadState_DeleteCurrent() Internal

Ned Deily added the comment: Since this sounds like a regression being introduced by 3.8.0, should the reversion be included in 3.8.0 final or can it wait for 3.8.1? -- keywords: +3.8regression nosy: +lukasz.langa, ned.deily ___ Python tracker

[issue38266] Revert bpo-37878: Make PyThreadState_DeleteCurrent() Internal

Change by Joannah Nanjekye : -- keywords: +patch pull_requests: +16148 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16558 ___ Python tracker

[issue38266] Revert bpo-37878: Make PyThreadState_DeleteCurrent() Internal

Eric Snow added the comment: @Joannah, sounds good. Thanks! -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue38266] Revert bpo-37878: Make PyThreadState_DeleteCurrent() Internal

Eric Snow added the comment: I *was* going to suggest that we also put an underscore prefix on the name, but I couldn't think of a reason why we would want to discourage use (other than to reduce the size of the [supported] public API). Moving it to Include/cpython/pystate.h is probably

[issue38266] Revert bpo-37878: Make PyThreadState_DeleteCurrent() Internal

STINNER Victor added the comment: If we want to make the function "fully public", I suggest to write documentation and have a simple unit test. -- ___ Python tracker ___

[issue38266] Revert bpo-37878: Make PyThreadState_DeleteCurrent() Internal

Joannah Nanjekye added the comment: I will handle this later today. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue38266] Revert bpo-37878: Make PyThreadState_DeleteCurrent() Internal

Joannah Nanjekye added the comment: +1 for moving from Include/pystate.h to Include/cpython/pystate.h -- ___ Python tracker ___

[issue38266] Revert bpo-37878: Make PyThreadState_DeleteCurrent() Internal

Eric Snow added the comment: s/un-revert/revert/ -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38266] Revert bpo-37878: Make PyThreadState_DeleteCurrent() Internal

Eric Snow added the comment: FWIW, when we un-revert we should be sure to move PyThreadState_DeleteCurrent() from Include/pystate.h to Include/cpython/pystate.h. (I suppose that could be done in a separate PR to keep the git history clear.) --

[issue38266] Revert bpo-37878: Make PyThreadState_DeleteCurrent() Internal

Eric Snow added the comment: FWIW, I support reverting the removal of PyThreadState_DeleteCurrent(). We only reverted under the assumption that no one was using this function. Clearly we were mistaken. :) I'll re-open #37878 to revive the discussion about documenting the function (which

[issue38266] Revert bpo-37878: Make PyThreadState_DeleteCurrent() Internal

Joannah Nanjekye added the comment: I am okay with the revert but @victor may still have some reservations on this. -- ___ Python tracker ___

[issue38266] Revert bpo-37878: Make PyThreadState_DeleteCurrent() Internal

New submission from Wenzel Jakob : A commit from a few days ago and discussed in issue #37878 removed an undocumented function PyThreadState_DeleteCurrent() from Python's public API. This function was exposed for good reasons and simply removing it because it is undocumented strikes me as a