[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[miss-islington]

miss-islington  added the comment:


New changeset 27f2f62ad490afc8e4dd6d80351916a9d06b97e3 by Miss Islington (bot) 
in branch '3.10':
bpo-38291: Update 3.10 WhatsNew with typing.{io|re} DeprecationWarning 
(GH-27872)
https://github.com/python/cpython/commit/27f2f62ad490afc8e4dd6d80351916a9d06b97e3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset 1a995b0ceefdf7eb59963f3ab395c47d8da226e3 by Ken Jin in branch 
'main':
bpo-38291: Update 3.10 WhatsNew with typing.{io|re} DeprecationWarning 
(GH-27872)
https://github.com/python/cpython/commit/1a995b0ceefdf7eb59963f3ab395c47d8da226e3


--
nosy: +lukasz.langa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Ken Jin]

Change by Ken Jin :


--
pull_requests: +26327
pull_request: https://github.com/python/cpython/pull/27872

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Ken Jin]

Change by Ken Jin :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Sebastian Rittau]

Change by Sebastian Rittau :


--
pull_requests: +25857
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/27312

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Currently deprecation warnings are emitted in test_typing:

$ ./python -m test test_typing
0:00:00 load avg: 3.38 Run tests sequentially
0:00:00 load avg: 3.38 [1/1] test_typing
/home/serhiy/py/cpython/Lib/test/test_typing.py:4657: DeprecationWarning: 
typing.io is deprecated, import directly from typing instead. typing.io will be 
removed in Python 3.12.
  k not in typing.io.__all__ and
/home/serhiy/py/cpython/Lib/test/test_typing.py:4658: DeprecationWarning: 
typing.re is deprecated, import directly from typing instead. typing.re will be 
removed in Python 3.12.
  k not in typing.re.__all__ and

== Tests result: SUCCESS ==

1 test OK.

Total duration: 564 ms
Tests result: SUCCESS

--
assignee: docs@python -> 
nosy: +serhiy.storchaka
resolution: fixed -> 
stage: resolved -> needs patch
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Guido van Rossum]

Change by Guido van Rossum :


--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Guido van Rossum]

Guido van Rossum  added the comment:


New changeset 8b849ea0f3482ad834e7989ff474dd5db2f295c8 by Sebastian Rittau in 
branch 'main':
bpo-38291: Fix a spurious warning when using help(object) (#27039)
https://github.com/python/cpython/commit/8b849ea0f3482ad834e7989ff474dd5db2f295c8


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Guido van Rossum]

Guido van Rossum  added the comment:

Thanks for the explanation. Let's reopen the issue for now.

--
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Sebastian Rittau]

Sebastian Rittau  added the comment:

typing.io is not referenced in either the tests or the implementation for 
pydoc. What happens is basically: typing.io is a class, so its derived from 
object. When formatting the docstring for object, the formatter queries the 
__module__ attribute of all sub-classes of object, including typing.io, so that 
it can include the sub-classes in its output:

--

Help on class object in module builtins:

class object
 |  The base class of the class hierarchy.
 |  
 |  When called, it accepts no arguments and returns a new featureless
 |  instance that has no instance attributes and cannot be given any.
 |  
 |  Built-in subclasses:
 |  anext_awaitable
 |  async_generator
 |  async_generator_asend
 |  async_generator_athrow
 |  ... and 88 other subclasses
 |  
[...]

--

Before the PR this failed, as accessing any typing.io.__module__ printed the 
warning.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Guido van Rossum]

Guido van Rossum  added the comment:

Why not just change "typing.io" to "typing"?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Sebastian Rittau]

Sebastian Rittau  added the comment:

pr-27039 suppresses warnings when accessing `typing.{re,io}.__module__`, which 
should fix this warning.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Sebastian Rittau]

Change by Sebastian Rittau :


--
pull_requests: +25599
pull_request: https://github.com/python/cpython/pull/27039

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Sebastian Rittau]

Sebastian Rittau  added the comment:

We could easily do what Ken did in PR-26811, and add 
"warnings.filterwarnings("default", category=DeprecationWarning)" to the test, 
but I would like to understand what is going on first. It seems the warnings 
are generated by test_builtin_with_more_than_four_children, which doesn't 
operate on typing directly. Here is a repro, without tests:

srittau@blitz:~/Projekte/cpython (typing-io *)$ ./python -Wall
Python 3.11.0a0 (heads/main:17f94e2888, Jul  5 2021, 19:19:04) [GCC 8.3.0] on 
linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import pydoc
>>> import typing
>>> doc = pydoc.TextDoc()
>>> x = doc.docclass(object)
/home/srittau/Projekte/cpython/Lib/pydoc.py:1344: DeprecationWarning: typing.io 
is deprecated, import directly from typing instead. typing.io will be removed 
in Python 3.12.
  if not cls.__name__.startswith("_") and cls.__module__ == "builtins"),
/home/srittau/Projekte/cpython/Lib/pydoc.py:1344: DeprecationWarning: typing.re 
is deprecated, import directly from typing instead. typing.re will be removed 
in Python 3.12.
  if not cls.__name__.startswith("_") and cls.__module__ == "builtins"),
>>> 

Same warning when calling "help(object)". This is not great. I assume that it 
is somehow related to pydoc.docclass() iterating over the the items of typing, 
but only if typing was imported. Please not that "io" and "re" are not part of 
typing.__all__.

I will investigate more.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Guido van Rossum]

Guido van Rossum  added the comment:

Can that be fixed by changing test_pydoc?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Ken Jin]

Ken Jin  added the comment:

> This change seems to emit deprecation warnings in test_pydoc.

test_typing emits them too as it tests importing things from __all__.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

This change seems to emit deprecation warnings in test_pydoc.

PYTHONWARNINGS=always ./python.exe -Wall -m test test_pydoc
0:00:00 load avg: 2.57 Run tests sequentially
0:00:00 load avg: 2.57 [1/1] test_pydoc
/Users/kasingar/stuff/python/cpython/Lib/pydoc.py:1344: DeprecationWarning: 
typing.io is deprecated, import directly from typing instead. typing.io will be 
removed in Python 3.12.
  if not cls.__name__.startswith("_") and cls.__module__ == "builtins"),
/Users/kasingar/stuff/python/cpython/Lib/pydoc.py:1344: DeprecationWarning: 
typing.re is deprecated, import directly from typing instead. typing.re will be 
removed in Python 3.12.
  if not cls.__name__.startswith("_") and cls.__module__ == "builtins"),
test_pydoc passed in 31.6 sec

== Tests result: SUCCESS ==

1 test OK.

Total duration: 31.7 sec
Tests result: SUCCESS

--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Ken Jin]

Ken Jin  added the comment:

@Sebastian,

Woops, thanks for the reminder. I think both options are fine. But I'm leaning 
towards creating a new issue. The title of the current issue is "Deprecate the 
typing.io and typing.re pseudo-modules" not "Remove the typing.io and typing.re 
pseudo-modules" after all ;-).

Jokes aside, the actual removal of a large chunk of code is usually quite 
contentious. And usually a lot of discussion happens when the time comes to 
remove it. So IMO having a separate issue for that when the time comes is 
better.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Sebastian Rittau]

Sebastian Rittau  added the comment:

Ken: We still need to remove these modules in Python 3.12+. Should we open a 
separate issue, reopen this one, or just handle it after the Python 3.11 branch 
has been created?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Ken Jin]

Ken Jin  added the comment:

That specific buildbot is now green. Thanks everyone :)!
https://dev.azure.com/Python/cpython/_build/results?buildId=82931=results

I'm closing the issue now as it seems there isn't anything left to do.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Ken Jin]

Ken Jin  added the comment:

> Overall it looks as if the the Azure pipeline should be fixed, though. It's 
> not ideal that the tests pass while running the PR, but not in other 
> situations.

I agree. This specific test only seems to run *after* a commit is made. I don't 
see a way to run this test on a PR, even the `test-with-buildbots` test doesn't 
seem to trigger it.

> Also, the warnings suppression is not really obvious.

Yup, it's hidden away in the docs here, so I was rather lost too: 
https://docs.python.org/3/library/warnings.html#testing-warnings

Anyways, I'm not actually sure that the PR will fix it. AFAICS, the only way to 
test it is to commit it and let the buildbot run ;). I can't reproduce it 
locally.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Sebastian Rittau]

Sebastian Rittau  added the comment:

Thank you for fixing this, Ken, the PR looks good to me.

Overall it looks as if the the Azure pipeline should be fixed, though. It's not 
ideal that the tests pass while running the PR, but not in other situations. 
Also, the warnings suppression is not really obvious.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Ken Jin]

Change by Ken Jin :


--
pull_requests: +25393
pull_request: https://github.com/python/cpython/pull/26811

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Ken Jin]

Ken Jin  added the comment:

Hello Sebastian, the tests are failing on the Azure pipelines buildbot running 
appx tests:

https://dev.azure.com/Python/cpython/_build/results?buildId=82827=logs=0fcf9c9b-89fc-526f-8708-363e467e119e=fa5ef4ee-3911-591e--19482ab189b7

I suspect it's the same problem as this issue:
https://bugs.python.org/issue44451

Sending a PR shortly to test if that fixes it.

--
nosy: +kj

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Guido van Rossum]

Guido van Rossum  added the comment:


New changeset 09eb81711597725f853e4f3b659ce185488b0d8c by Sebastian Rittau in 
branch 'main':
bpo-38291: DeprecationWarning when importing typing.{io,re} (#26719)
https://github.com/python/cpython/commit/09eb81711597725f853e4f3b659ce185488b0d8c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[miss-islington]

miss-islington  added the comment:


New changeset 7f021952b2debb51306f70ec96a94ecc7fbffc19 by Miss Islington (bot) 
in branch '3.9':
bpo-38291: Remove mention of typing.io and typing.re again (GH-26113)
https://github.com/python/cpython/commit/7f021952b2debb51306f70ec96a94ecc7fbffc19


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[miss-islington]

miss-islington  added the comment:


New changeset fc310cb862ce0411bb5daed37f7f31b75647495b by Miss Islington (bot) 
in branch '3.10':
bpo-38291: Remove mention of typing.io and typing.re again (GH-26113)
https://github.com/python/cpython/commit/fc310cb862ce0411bb5daed37f7f31b75647495b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 6.0 -> 7.0
pull_requests: +25308
pull_request: https://github.com/python/cpython/pull/26720

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Guido van Rossum]

Guido van Rossum  added the comment:


New changeset 8a76683cfb842e12b57f6d276839f6c68fd94e1a by Sebastian Rittau in 
branch 'main':
bpo-38291: Remove mention of typing.io and typing.re again (GH-26113)
https://github.com/python/cpython/commit/8a76683cfb842e12b57f6d276839f6c68fd94e1a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[miss-islington]

Change by miss-islington :


--
pull_requests: +25310
pull_request: https://github.com/python/cpython/pull/26721

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Sebastian Rittau]

Sebastian Rittau  added the comment:

And I opened a second PR (for Python 3.11 only) to issue a deprecation warning 
when typing.io or typing.re gets imported.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Sebastian Rittau]

Change by Sebastian Rittau :


--
pull_requests: +25307
pull_request: https://github.com/python/cpython/pull/26719

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Sebastian Rittau]

Sebastian Rittau  added the comment:

I opened a PR to remove their mention from the docs for now. I can look into 
how to add a deprecation warning to a module if no one else beats me to it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Sebastian Rittau]

Change by Sebastian Rittau :


--
keywords: +patch
pull_requests: +24757
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/26113

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Guido van Rossum]

Guido van Rossum  added the comment:

I agree, these namespaces were a mistake. Let's start deprecating them (and 
remove their mention from the docs again).

--
versions:  -Python 3.10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Sebastian Rittau]

Change by Sebastian Rittau :


--
nosy: +srittau

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38291] Deprecate the typing.io and typing.re pseudo-modules

[Jelle Zijlstra]

Jelle Zijlstra  added the comment:

The documentation 
(https://docs.python.org/3.10/library/typing.html#typing.BinaryIO) now mentions 
the typing.io and typing.re namespaces.

I would prefer that they be deprecated and eventually completely removed. They 
don't work with most static type checkers. https://bugs.python.org/issue42001 
makes the same points.

--
nosy: +Jelle Zijlstra
title: Unclear status of the typing.io and typing.re pseudo-modules in docs and 
runtime -> Deprecate the typing.io and typing.re pseudo-modules
versions: +Python 3.10, Python 3.11 -Python 3.6, Python 3.7, Python 3.8, Python 
3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com