[issue38326] Concerns with the last minute changes to the PEP 587 API

[STINNER Victor]

STINNER Victor  added the comment:

Nick merged my two PRS, so the initial concern is gone :-) I close the issue. 
Thanks for the feedback, it was an interesting talk. Sorry for the bad timing. 
I dislike working under pressure of a deadline :-(

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38326] Concerns with the last minute changes to the PEP 587 API

[Łukasz Langa]

Łukasz Langa  added the comment:

I suggest closing this and following up in BPO-38304 about a possible graceful 
error message during invalid embedding.

--
priority: release blocker -> normal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38326] Concerns with the last minute changes to the PEP 587 API

[Gregory P. Smith]

Change by Gregory P. Smith :


--
nosy: +gregory.p.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38326] Concerns with the last minute changes to the PEP 587 API

[STINNER Victor]

STINNER Victor  added the comment:

> Binary compatibility of an embedding-only struct is totally unnecessary, as 
> posted on the thread.

Well, I'm fine with removing PyConfig.struct_size right now. I wrote two PRs to 
remove it:

* PR 16500 (code)
* https://github.com/python/peps/pull/1185 (PEP)

We can still add a similar "version" ("struct_size" or whatever) field later 
*if* we want to provide a stable ABI for embedded Python.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38326] Concerns with the last minute changes to the PEP 587 API

[Nick Coghlan]

Change by Nick Coghlan :


--
keywords: +patch
pull_requests: +16084
stage: commit review -> patch review
pull_request: https://github.com/python/cpython/pull/16496

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38326] Concerns with the last minute changes to the PEP 587 API

[Łukasz Langa]

Change by Łukasz Langa :


--
versions: +Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38326] Concerns with the last minute changes to the PEP 587 API

[Steve Dower]

Steve Dower  added the comment:

(Continuing from the email thread, so read that for context if you haven't)

Binary compatibility of an embedding-only struct is totally unnecessary, as 
posted on the thread. There's no feasible way to embed cross-Python versions on 
any platform, so we should just officially say that embedding applications are 
only compatible with the version it was built to target.

(Aside: this is why I keep talking about "embeddable distros", as these help 
solve the problem of trying to embed an arbitrary system Python.)

AFAICT, this should remove the need for any version or size checks at all.

--
nosy: +steve.dower

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38326] Concerns with the last minute changes to the PEP 587 API

[Nick Coghlan]

Nick Coghlan  added the comment:

(I'm currently working a PR for this that Victor can review)

--
assignee:  -> ncoghlan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38326] Concerns with the last minute changes to the PEP 587 API

[Nick Coghlan]

New submission from Nick Coghlan :

(Nosy list is RM, PEP 587 BDFL-Delegate, PEP 587 author)

Filing as a release blocker, given that I don't think we should ship rc1 until 
consensus has been reached on the last minute changes to the PEP 587 
configuration API.

Thread at 
https://mail.python.org/archives/list/python-...@python.org/thread/C7Z2NA2DTM3DLOZCFQAK5A2WFYO3PHHX/

--
messages: 353573
nosy: lukasz.langa, ncoghlan, twouters, vstinner
priority: release blocker
severity: normal
stage: commit review
status: open
title: Concerns with the last minute changes to the PEP 587 API
type: enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com