[issue38376] ./configure --with-assertions generates a broken build

STINNER Victor added the comment: New changeset f82ce5b1b12873b65927149a016be6a7c65e979d by Victor Stinner in branch '3.8': [3.8] bpo-36389: Backport debug enhancements from master (GH-16796) https://github.com/python/cpython/commit/f82ce5b1b12873b65927149a016be6a7c65e979d --

[issue38376] ./configure --with-assertions generates a broken build

STINNER Victor added the comment: After pushing some fixes to 3.8 and master branches, I tested the following commands in 3.7, 3.8 and master branches: make distclean ./configure --prefix=$HOME/.local --with-assertions make ./python -m test -j0 test_bytes test_gc test_capi These commands

[issue38376] ./configure --with-assertions generates a broken build

STINNER Victor added the comment: I pushed one more fix in https://bugs.python.org/issue36389#msg354138 -- ___ Python tracker ___

[issue38376] ./configure --with-assertions generates a broken build

STINNER Victor added the comment: New changeset 435b2eeb7bc5b8ec264e900b38bcb3d76552d777 by Victor Stinner in branch '3.8': bpo-38376: Fix _PyUnicode_CheckConsistency() definition (GH-16623) https://github.com/python/cpython/commit/435b2eeb7bc5b8ec264e900b38bcb3d76552d777 --

[issue38376] ./configure --with-assertions generates a broken build

STINNER Victor added the comment: New changeset 6876257eaabdb30f27ebcbd7d2557278ce2e5705 by Victor Stinner in branch 'master': bpo-36389: _PyObject_CheckConsistency() available in release mode (GH-16612) https://github.com/python/cpython/commit/6876257eaabdb30f27ebcbd7d2557278ce2e5705

[issue38376] ./configure --with-assertions generates a broken build

Change by STINNER Victor : -- pull_requests: +16210 pull_request: https://github.com/python/cpython/pull/16623 ___ Python tracker ___

[issue38376] ./configure --with-assertions generates a broken build

STINNER Victor added the comment: My intent in bpo-36389 was to also provide _PyObject_CheckConsistency() in release mode to help debugging GC crash, especially in visit_decref(). I wrote PR 16612 to fix my implementation. -- ___ Python tracker

[issue38376] ./configure --with-assertions generates a broken build

Change by STINNER Victor : -- pull_requests: +16201 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16612 ___ Python tracker ___

[issue38376] ./configure --with-assertions generates a broken build

Thomas Wouters added the comment: The problem is _PyUnicode_CheckConsistency switched from being only defined when Py_DEBUG is set, to being defined unconditionally. That was a good change, but it made the API-compatibility hack of #defining _PyUnicode_CheckConsistency in

[issue38376] ./configure --with-assertions generates a broken build

Change by Thomas Wouters : -- keywords: +patch pull_requests: +16183 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16594 ___ Python tracker ___

[issue38376] ./configure --with-assertions generates a broken build

Vinay Sajip added the comment: Adding Thomas and Victor based on git blame on some of the source lines concerned. -- nosy: +twouters, vstinner ___ Python tracker ___

[issue38376] ./configure --with-assertions generates a broken build

Vinay Sajip added the comment: BTW it also seems to fail when just Py_DEBUG is specified (no --with-assertions). -- ___ Python tracker ___

[issue38376] ./configure --with-assertions generates a broken build

New submission from Vinay Sajip : Following ./configure --prefix=$HOME/.local --with-assertions and then running make leads to an error: $ make gcc -pthread -c -Wno-unused-result -Wsign-compare -g -fwrapv -O3 -Wall -std=c99 -Wextra -Wno-unused-result -Wno-unused-parameter