[issue38380] Update SQLite to 3.31.1 in Windows and macOS installer builds

Benjamin Peterson added the comment: Traditionally, we've taken these dependency updates in 2.7, but there doesn't seem to be a compelling reason to take this one. -- resolution: -> fixed stage: backport needed -> resolved status: open -> closed

[issue38380] Update SQLite to 3.31.1 in Windows and macOS installer builds

Erlend Egeberg Aasland added the comment: Cool. Should I remove Python-3.* from the Versions label, so it doesn't show up in searches for 3.* issues? -- ___ Python tracker

[issue38380] Update SQLite to 3.31.1 in Windows and macOS installer builds

Steve Dower added the comment: Leaving open until someone (*cough* Benjamin) confirms whether this has to go into 2.7 or not. -- nosy: +benjamin.peterson stage: patch review -> backport needed ___ Python tracker

[issue38380] Update SQLite to 3.31.1 in Windows and macOS installer builds

miss-islington added the comment: New changeset 7ca251bd85f1182b9734579975c17fbd0488e2a4 by Miss Islington (bot) in branch '3.7': bpo-38380: Update macOS & Windows builds to SQLite v3.31.1 (GH-18678) https://github.com/python/cpython/commit/7ca251bd85f1182b9734579975c17fbd0488e2a4

[issue38380] Update SQLite to 3.31.1 in Windows and macOS installer builds

miss-islington added the comment: New changeset 7ad99821d8ae75222c50e69194a39f535bb058f5 by Miss Islington (bot) in branch '3.8': bpo-38380: Update macOS & Windows builds to SQLite v3.31.1 (GH-18678) https://github.com/python/cpython/commit/7ad99821d8ae75222c50e69194a39f535bb058f5

[issue38380] Update SQLite to 3.31.1 in Windows and macOS installer builds

Change by miss-islington : -- pull_requests: +18096 pull_request: https://github.com/python/cpython/pull/18741 ___ Python tracker ___

[issue38380] Update SQLite to 3.31.1 in Windows and macOS installer builds

miss-islington added the comment: New changeset 1382c3289bcfd34ac6811fdf9aa5bc09ca8c320e by Erlend Egeberg Aasland in branch 'master': bpo-38380: Update macOS & Windows builds to SQLite v3.31.1 (GH-18678) https://github.com/python/cpython/commit/1382c3289bcfd34ac6811fdf9aa5bc09ca8c320e

[issue38380] Update SQLite to 3.31.1 in Windows and macOS installer builds

Change by miss-islington : -- pull_requests: +18095 pull_request: https://github.com/python/cpython/pull/18740 ___ Python tracker ___

[issue38380] Update SQLite to 3.31.1 in Windows and macOS installer builds

Steve Dower added the comment: I marked the PR to backport to 3.7 and 3.8. Up to Benjamin whether 2.7 gets it, but unless there's a specific and impactful CVE that's been fixed, I doubt it (the one linked at the start of this issue seems to require direct modification of the SQL statement,

[issue38380] Update SQLite to 3.31.1 in Windows and macOS installer builds

Erlend Egeberg Aasland added the comment: Ok, thanks for your patience and time. I'll fix the NEWS entries right away. -- ___ Python tracker ___

[issue38380] Update SQLite to 3.31.1 in Windows and macOS installer builds

Steve Dower added the comment: Nope, same PR and bug is totally fine. Putting the NEWS items in their platform-specific sections is how we normally do it (though to be fair, I had to go look it up). -- ___ Python tracker

[issue38380] Update SQLite to 3.31.1 in Windows and macOS installer builds

Erlend Egeberg Aasland added the comment: Ah, but you're all set @steve.dower, someone at cpython-source-deps already pulled my tags: https://github.com/python/cpython-source-deps/tags :) But I guess that if I were to do the same maneouver again, it would probably be preferable if I made

[issue38380] Update SQLite to 3.31.1 in Windows and macOS installer builds

Steve Dower added the comment: No, that one is fine. I just need someone else to jump in and tag the commit in cpython-source-deps for me (because I can't clone it successfully on my current internet connection). -- ___ Python tracker

[issue38380] Update SQLite to 3.31.1 in Windows and macOS installer builds

Erlend Egeberg Aasland added the comment: Would you prefer that I close GH_18678 and split it up in separate RPs for macOS and Windows? -- ___ Python tracker ___

[issue38380] Update SQLite to 3.31.1 in Windows and macOS installer builds

Erlend Egeberg Aasland added the comment: Understood; I’ll remember it for future PRs. Thanks for clarifying. -- ___ Python tracker ___

[issue38380] Update SQLite to 3.31.1 in Windows and macOS installer builds

Steve Dower added the comment: > (BTW, is it kosher to force push to PRs like this?) We always squash merge, so you don't need to do it to hide your history. Personally, I do it occasionally when the history is very long and nobody has started reviewing. Force pushing will reset any

[issue38380] Update SQLite to 3.31.1 in Windows and macOS installer builds

Change by Erlend Egeberg Aasland : -- title: Update SQLite to 3.30 in Windows and macOS installer builds -> Update SQLite to 3.31.1 in Windows and macOS installer builds ___ Python tracker