[issue38466] [Easy doc] threading.excepthook doc talks about "object"

STINNER Victor added the comment: Thanks Daniel Baskal for the fix and Sebastian Rittau for the bug report. The doc is now fixed in 3.8 and master branches. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python

[issue38466] [Easy doc] threading.excepthook doc talks about "object"

miss-islington added the comment: New changeset 6329a56ca7f99075caa95a075024736a90ad2857 by Miss Skeleton (bot) in branch '3.8': bpo-38466: Fix threading.excepthook doc (GH-16891) https://github.com/python/cpython/commit/6329a56ca7f99075caa95a075024736a90ad2857 -- nosy:

[issue38466] [Easy doc] threading.excepthook doc talks about "object"

Change by miss-islington : -- pull_requests: +16433 pull_request: https://github.com/python/cpython/pull/16894 ___ Python tracker ___

[issue38466] [Easy doc] threading.excepthook doc talks about "object"

STINNER Victor added the comment: New changeset 91528f40c30717563a478920861c81d18da5bf63 by Victor Stinner (Daniel Baskal) in branch 'master': bpo-38466: Fix threading.excepthook doc (GH-16891) https://github.com/python/cpython/commit/91528f40c30717563a478920861c81d18da5bf63 --

[issue38466] [Easy doc] threading.excepthook doc talks about "object"

Change by Roundup Robot : -- keywords: +patch pull_requests: +16430 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16891 ___ Python tracker ___

[issue38466] [Easy doc] threading.excepthook doc talks about "object"

STINNER Victor added the comment: > https://docs.python.org/3.8/library/threading.html#threading.excepthook "Storing *object* using a custom hook can resurrect it" should be "Storing *thread* using a custom hook can resurrect it" in Doc/library/threading.rst --

[issue38466] [Easy doc] threading.excepthook doc talks about "object"

Daniel Baskal added the comment: Hi, as a newcomer I'd like to work on this! Though, I am uncertain about whether these two hooks (threading.excepthook and sys.unraisablehook) have similar behavior and wouldn't it be misleading to simply change mentions of "object" to "thread" in the docs?

[issue38466] [Easy doc] threading.excepthook doc talks about "object"

Change by STINNER Victor : -- keywords: +newcomer friendly title: threading.excepthook doc talks about "object" -> [Easy doc] threading.excepthook doc talks about "object" ___ Python tracker