[issue38470] test_compileall fails in AMD64 Windows7 SP1 3.x

Change by Juho Vähä-Herttua : -- pull_requests: +16371 pull_request: https://github.com/python/cpython/pull/16819 ___ Python tracker ___

[issue38470] test_compileall fails in AMD64 Windows7 SP1 3.x

STINNER Victor added the comment: It seems like test_compileall now pass on the 4 Windows workers: * https://buildbot.python.org/all/#/builders/3 * https://buildbot.python.org/all/#/builders/12 * https://buildbot.python.org/all/#/builders/40 * https://buildbot.python.org/all/#/builders/58

[issue38470] test_compileall fails in AMD64 Windows7 SP1 3.x

STINNER Victor added the comment: > create_long_path isn't taking into account _write_atomic in > Lib/importlib/_bootstrap_external.py. Yeah, I found the same issue: https://github.com/python/cpython/pull/16778#issuecomment-541764285 I began to write a complex change to take _write_atomic()

[issue38470] test_compileall fails in AMD64 Windows7 SP1 3.x

Petr Viktorin added the comment: New changeset eb1dda2b56f67f09352c303588c28880c471ae87 by Petr Viktorin (Victor Stinner) in branch 'master': bpo-38470: Fix test_compileall.test_compile_dir_maxlevels() (GH-16789)

[issue38470] test_compileall fails in AMD64 Windows7 SP1 3.x

Eryk Sun added the comment: I tested in Windows 10 with long paths disabled, and the FileNotFoundError exception showed that the failing .pyc had a numeric suffix appended to the name. create_long_path isn't taking into account _write_atomic in Lib/importlib/_bootstrap_external.py. This

[issue38470] test_compileall fails in AMD64 Windows7 SP1 3.x

STINNER Victor added the comment: I wrote PR 16789 which fix the issue. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue38470] test_compileall fails in AMD64 Windows7 SP1 3.x

Jeremy Kloth added the comment: > Windows 7 is not supported for Python 3.9, so this buildbot can be > disabled/upgraded. As long as 3.7 and 3.8 are being tested through the buildbots, I would think testing on Windows 7 is still advised. That said, once those versions are no longer tested

[issue38470] test_compileall fails in AMD64 Windows7 SP1 3.x

STINNER Victor added the comment: The new test was added by bpo-38112: commit 4267c989e7fc6cd528e8a1d04a07fac5cca85ec7. -- ___ Python tracker ___

[issue38470] test_compileall fails in AMD64 Windows7 SP1 3.x

Change by STINNER Victor : -- pull_requests: +16350 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16789 ___ Python tracker ___

[issue38470] test_compileall fails in AMD64 Windows7 SP1 3.x

Steve Dower added the comment: I'm okay with skipping the failing test if we detect sys.getwindowsversion().major < 10 Windows 7 is not supported for Python 3.9, so this buildbot can be disabled/upgraded. Windows 8.1 will be supported for at least 3.9, so we'll have to keep skipping the

[issue38470] test_compileall fails in AMD64 Windows7 SP1 3.x

STINNER Victor added the comment: To reproduce the recent on a recent Windows 10, you can opt-out for long path using this change: diff --git a/PC/python.manifest b/PC/python.manifest index 8e1bc022ad..524f9b2f6d 100644 --- a/PC/python.manifest +++ b/PC/python.manifest @@ -18,7 +18,6 @@

[issue38470] test_compileall fails in AMD64 Windows7 SP1 3.x

Pablo Galindo Salgado added the comment: You can trigger custom buildbot runs by pushing to the 'buildbot-custom' branch in the CPython repo. -- ___ Python tracker ___

[issue38470] test_compileall fails in AMD64 Windows7 SP1 3.x

Petr Viktorin added the comment: If someone has access to Windows and can reproduce this (you need a more special setup than "just Windows"), and you want to spend some time debugging, please do. I'm shooting in the dark. My proposed patch limits the maximum path depth to 20 directories on

[issue38470] test_compileall fails in AMD64 Windows7 SP1 3.x

Change by Petr Viktorin : -- keywords: +patch pull_requests: +16340 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16778 ___ Python tracker ___

[issue38470] test_compileall fails in AMD64 Windows7 SP1 3.x

Petr Viktorin added the comment: Oh! Sorry, I thought I saw green bots, and haven't looked since. I should have time for this tomorrow. If that's too late, remove/skip test_compile_dir_maxlevels on Windows. (The feature was untested before, and the 3.9 enhancement added test coverage, so I

[issue38470] test_compileall fails in AMD64 Windows7 SP1 3.x

New submission from Pablo Galindo Salgado : This buildbot has been failing for a long time (example failure https://buildbot.python.org/all/#/builders/40/builds/3291) since https://github.com/python/cpython/commit/4267c989e7fc6cd528e8a1d04a07fac5cca85ec7: