[issue38539] Update demo files

Raymond Hettinger added the comment: New changeset ea6041cd7ff0d752296d1759927eff898ceba864 by Raymond Hettinger in branch 'master': bpo-38539: Finish rename of ss1.py to spreadsheet.py (GH-16896) https://github.com/python/cpython/commit/ea6041cd7ff0d752296d1759927eff898ceba864 --

[issue38539] Update demo files

Change by Raymond Hettinger : -- pull_requests: +16434 pull_request: https://github.com/python/cpython/pull/16896 ___ Python tracker ___

[issue38539] Update demo files

Change by Raymond Hettinger : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue38539] Update demo files

Raymond Hettinger added the comment: New changeset a4aeb336697c85996d781271cc6b42bc6d4c2908 by Raymond Hettinger (Julin S) in branch 'master': bpo-38539: Update demo files (GH-16890) https://github.com/python/cpython/commit/a4aeb336697c85996d781271cc6b42bc6d4c2908 --

[issue38539] Update demo files

Julin added the comment: I've made a PR. Can you review it? -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue38539] Update demo files

Change by Julin : -- keywords: +patch pull_requests: +16428 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16890 ___ Python tracker ___

[issue38539] Update demo files

Raymond Hettinger added the comment: Let's just do the rename for ss1.py. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue38539] Update demo files

Julin added the comment: Okay. While I'm at it, can I make a few minor change as well? Like - Use fstrings - change range(0, val) to range(val) as range()'s first argument has default value 0. - Change `for i in range(len(groups)):` to enumerated (redemo.py) - rename ss1.py to

[issue38539] Update demo files

Change by Raymond Hettinger : -- assignee: -> rhettinger versions: -Python 3.6, Python 3.7, Python 3.8 ___ Python tracker ___ ___

[issue38539] Update demo files

Raymond Hettinger added the comment: The Tools/demo modules are sort of a quaint museum to the past. That said, most of the code reads fine even by today's standards. Go ahead with as PR to change "while 1" to "while True". The star imports should remain (they are the norm for Tkinter)

[issue38539] Update demo files

New submission from Julin : The demo programs inside Tools/demo, which is to guide people new to the language (that's the purpose, right?), makes use of several bad coding practices. Like - `while 1:` being used instead of `while True:` - star import - function call and an `if` statement