[issue38580] select()'s documentation claims only sequences are accepted, but it allows all iterables

Jakub Stasiak added the comment: Cheers for backporting this, Tal, you beat me to it! -- ___ Python tracker ___ ___

[issue38580] select()'s documentation claims only sequences are accepted, but it allows all iterables

miss-islington added the comment: New changeset 500cd89ecce97750a1af32d4097d9945b7296bac by Miss Islington (bot) in branch '3.9': bpo-38580: Document that select() accepts iterables, not just sequences (GH-16832)

[issue38580] select()'s documentation claims only sequences are accepted, but it allows all iterables

Tal Einat added the comment: New changeset 3f215f35bdb9d666f5a692fc60f800da1bb1e4a9 by Tal Einat in branch '3.7': [3.7] bpo-38580: Document that select() accepts iterables, not just sequences (GH-16832) https://github.com/python/cpython/commit/3f215f35bdb9d666f5a692fc60f800da1bb1e4a9

[issue38580] select()'s documentation claims only sequences are accepted, but it allows all iterables

Tal Einat added the comment: New changeset e3e800f3d28881cc9de38cd9bcbcf8fbdea238a6 by Tal Einat in branch '3.8': [3.8] bpo-38580: Document that select() accepts iterables, not just sequences (GH-16832) https://github.com/python/cpython/commit/e3e800f3d28881cc9de38cd9bcbcf8fbdea238a6

[issue38580] select()'s documentation claims only sequences are accepted, but it allows all iterables

Change by Tal Einat : -- pull_requests: +19684 pull_request: https://github.com/python/cpython/pull/20426 ___ Python tracker ___

[issue38580] select()'s documentation claims only sequences are accepted, but it allows all iterables

Change by Tal Einat : -- pull_requests: +19682 pull_request: https://github.com/python/cpython/pull/20424 ___ Python tracker ___

[issue38580] select()'s documentation claims only sequences are accepted, but it allows all iterables

Tal Einat added the comment: Nothing further is required; I've merged the PR. Thanks! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10 ___ Python tracker

[issue38580] select()'s documentation claims only sequences are accepted, but it allows all iterables

Change by miss-islington : -- keywords: +patch nosy: +miss-islington nosy_count: 8.0 -> 9.0 pull_requests: +19635 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20372 ___ Python tracker

[issue38580] select()'s documentation claims only sequences are accepted, but it allows all iterables

Tal Einat added the comment: New changeset 372ee27d4958302dac7ad6a8711f6fd04771b2e6 by Jakub Stasiak in branch 'master': bpo-38580: Document that select() accepts iterables, not just sequences (GH-16832) https://github.com/python/cpython/commit/372ee27d4958302dac7ad6a8711f6fd04771b2e6

[issue38580] select()'s documentation claims only sequences are accepted, but it allows all iterables

Ido Michael added the comment: Hey Tal, I see this issue is pending and pretty much done, what else there's to fix here? -- nosy: +Ido Michael ___ Python tracker ___

[issue38580] select()'s documentation claims only sequences are accepted, but it allows all iterables

Tal Einat added the comment: It seems pretty clear to me that we should simply update the docs as suggested. If nobody chimes in about this within a week, I intend to merge the PR (GH-16832) with the small fixes I've suggested there. -- ___

[issue38580] select()'s documentation claims only sequences are accepted, but it allows all iterables

Tal Einat added the comment: It seems that select() does indeed support arbitrary iterables through the use of PySequence_Fast(). The commit where this was introduced, by Brett Cannon from 2003 (62dba4c2775adfb5a5a97ca012a3ab00c4e28597), doesn't seems to have intended this though:

[issue38580] select()'s documentation claims only sequences are accepted, but it allows all iterables

Change by Cheryl Sabella : -- versions: -Python 3.5, Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue38580] select()'s documentation claims only sequences are accepted, but it allows all iterables

Change by Brandt Bucher : -- nosy: +brandtbucher ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38580] select()'s documentation claims only sequences are accepted, but it allows all iterables

Change by Dong-hee Na : -- nosy: +serhiy.storchaka, vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38580] select()'s documentation claims only sequences are accepted, but it allows all iterables

New submission from Jakub Stasiak : Excerpt from the documentation: """This is a straightforward interface to the Unix select() system call. The first three arguments are sequences of ‘waitable objects’: either integers representing file descriptors or objects with a parameterless method