[issue39006] test_asyncio: sendfile tests fail on AMD64 Debian root 3.7 when _ssl is missing

miss-islington added the comment: New changeset a0078d9a3335a5e99afe97590fdcb8e2f526ed7b by Miss Islington (bot) in branch '3.7': bpo-39006: Fix asyncio when the ssl module is missing (GH-17524) https://github.com/python/cpython/commit/a0078d9a3335a5e99afe97590fdcb8e2f526ed7b --

[issue39006] test_asyncio: sendfile tests fail on AMD64 Debian root 3.7 when _ssl is missing

miss-islington added the comment: New changeset b22183f2738e0e6c23f8c5fb5b232768c184ec96 by Miss Islington (bot) in branch '3.8': bpo-39006: Fix asyncio when the ssl module is missing (GH-17524) https://github.com/python/cpython/commit/b22183f2738e0e6c23f8c5fb5b232768c184ec96 --

[issue39006] test_asyncio: sendfile tests fail on AMD64 Debian root 3.7 when _ssl is missing

STINNER Victor added the comment: I wrote a fix which was approved by Andrew Svetlov. Andrew prefers my PR than Christian's PR 17526, so I merged my PR instead. See PR 17526 discussion for the rationale. I merged your PR to master, 3.7 and 3.8 backport will automatically follow. I close

[issue39006] test_asyncio: sendfile tests fail on AMD64 Debian root 3.7 when _ssl is missing

STINNER Victor added the comment: New changeset 82b4950b5e92bec343a436b3f9c116400b66e1b9 by Victor Stinner in branch 'master': bpo-39006: Fix asyncio when the ssl module is missing (GH-17524) https://github.com/python/cpython/commit/82b4950b5e92bec343a436b3f9c116400b66e1b9 --

[issue39006] test_asyncio: sendfile tests fail on AMD64 Debian root 3.7 when _ssl is missing

Change by miss-islington : -- pull_requests: +17006 pull_request: https://github.com/python/cpython/pull/17528 ___ Python tracker ___

[issue39006] test_asyncio: sendfile tests fail on AMD64 Debian root 3.7 when _ssl is missing

Change by miss-islington : -- pull_requests: +17005 pull_request: https://github.com/python/cpython/pull/17527 ___ Python tracker ___

[issue39006] test_asyncio: sendfile tests fail on AMD64 Debian root 3.7 when _ssl is missing

Christian Heimes added the comment: The problem was introduced by https://bugs.python.org/issue37404. I created https://github.com/python/cpython/pull/17526 to fix the problem and address a minor performance regression. -- ___ Python tracker

[issue39006] test_asyncio: sendfile tests fail on AMD64 Debian root 3.7 when _ssl is missing

Andrew Svetlov added the comment: Sorry, my fault. -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue39006] test_asyncio: sendfile tests fail on AMD64 Debian root 3.7 when _ssl is missing

STINNER Victor added the comment: Same issue on AMD64 Debian root 3.8: https://buildbot.python.org/all/#builders/162/builds/14 And AMD64 Debian root 3.x: https://buildbot.python.org/all/#builders/225/builds/28 -- versions: +Python 3.8, Python 3.9

[issue39006] test_asyncio: sendfile tests fail on AMD64 Debian root 3.7 when _ssl is missing

Change by STINNER Victor : -- keywords: +patch pull_requests: +17002 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17524 ___ Python tracker ___

[issue39006] test_asyncio: sendfile tests fail on AMD64 Debian root 3.7 when _ssl is missing

Christian Heimes added the comment: I don't see test_ssl.py in the logs. test_unix_events.py is failing because it is missing a check for _ssl. -- nosy: +christian.heimes ___ Python tracker

[issue39006] test_asyncio: sendfile tests fail on AMD64 Debian root 3.7 when _ssl is missing

Change by STINNER Victor : -- components: -SSL nosy: -christian.heimes title: test_ssl: sendfile tests fail on AMD64 Debian root 3.7 when _ssl is missing -> test_asyncio: sendfile tests fail on AMD64 Debian root 3.7 when _ssl is missing ___