[issue39184] Many command execution functions are not raising auditing events

Saiyang Gou added the comment: Since the original problem (command execution functions missing audit events) is already solved, we can close this issue now. Further discussions on additional audit hooks (e.g. for the networking modules) could go to issue 37363. --

[issue39184] Many command execution functions are not raising auditing events

Change by Saiyang Gou : -- pull_requests: +20473 pull_request: https://github.com/python/cpython/pull/21322 ___ Python tracker ___

[issue39184] Many command execution functions are not raising auditing events

miss-islington added the comment: New changeset d0a464e31ac67685ef8ad35ecd993f17dfd6ab35 by Miss Islington (bot) in branch '3.8': bpo-39184: Fix incorrect return value (GH-18580) https://github.com/python/cpython/commit/d0a464e31ac67685ef8ad35ecd993f17dfd6ab35 --

[issue39184] Many command execution functions are not raising auditing events

Change by miss-islington : -- pull_requests: +17952 pull_request: https://github.com/python/cpython/pull/18582 ___ Python tracker ___

[issue39184] Many command execution functions are not raising auditing events

miss-islington added the comment: New changeset 6c444d0dab8f06cf304263b34beb299101cef3de by Steve Dower in branch 'master': bpo-39184: Fix incorrect return value (GH-18580) https://github.com/python/cpython/commit/6c444d0dab8f06cf304263b34beb299101cef3de --

[issue39184] Many command execution functions are not raising auditing events

Change by Steve Dower : -- pull_requests: +17950 pull_request: https://github.com/python/cpython/pull/18580 ___ Python tracker ___

[issue39184] Many command execution functions are not raising auditing events

Steve Dower added the comment: New changeset a00b5be5f71b702ab80b0a7c046485046aaae160 by Steve Dower in branch '3.8': bpo-39184: Add audit events to functions in `fcntl`, `msvcrt`, `os`, `resource`, `shutil`, `signal`, `syslog` (GH-18407)

[issue39184] Many command execution functions are not raising auditing events

Change by Steve Dower : -- pull_requests: +17874 pull_request: https://github.com/python/cpython/pull/18500 ___ Python tracker ___

[issue39184] Many command execution functions are not raising auditing events

Steve Dower added the comment: New changeset 7514f4f6254f4a2d13ea8e5632a8e5f22b637e0b by Saiyang Gou in branch 'master': bpo-39184: Add audit events to functions in `fcntl`, `msvcrt`, `os`, `resource`, `shutil`, `signal`, `syslog` (GH-18407)

[issue39184] Many command execution functions are not raising auditing events

Saiyang Gou added the comment: Thanks for your review! PR 18407 is for the second list. For now I haven't added audit hooks for the http, socketserver and xmlrpc modules because they look a bit complex. There seems to be so many classes and methods to hook, we may need to find good places

[issue39184] Many command execution functions are not raising auditing events

Change by Saiyang Gou : -- pull_requests: +17782 pull_request: https://github.com/python/cpython/pull/18407 ___ Python tracker ___

[issue39184] Many command execution functions are not raising auditing events

miss-islington added the comment: New changeset 3498ac55bcfc18d698ea605424ec65a6e1457a39 by Miss Islington (bot) in branch '3.8': bpo-39184: Add audit events to command execution functions in os and pty modules (GH-17824)

[issue39184] Many command execution functions are not raising auditing events

Steve Dower added the comment: Thanks for the spawn patch, I've merged it. On the second list, I'd say go for it. The only one I'd skip are the stat() calls (and those that just do a stat call, such as exists/isfile, etc.), and getcwd() (which has many other ways to implicitly use the

[issue39184] Many command execution functions are not raising auditing events

Change by miss-islington : -- pull_requests: +17728 pull_request: https://github.com/python/cpython/pull/18353 ___ Python tracker ___

[issue39184] Many command execution functions are not raising auditing events

Steve Dower added the comment: New changeset 95f60010219e142a436fae18e1695cbc45407afe by Saiyang Gou in branch 'master': bpo-39184: Add audit events to command execution functions in os and pty modules (GH-17824)

[issue39184] Many command execution functions are not raising auditing events

Saiyang Gou added the comment: I have made PR 17824 to add auditing events for the command execution functions mentioned above. After a review on other related Python modules, I think maybe the following functions can also be audited, but a discussion may be required to determine whether

[issue39184] Many command execution functions are not raising auditing events

Change by Saiyang Gou : -- keywords: +patch pull_requests: +17252 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17824 ___ Python tracker ___

[issue39184] Many command execution functions are not raising auditing events

Steve Dower added the comment: Agreed, we should add events for all of these. They can go into the next 3.8 release. Ideally, the lowest level operations (typically os module) should raise events. Where it's convenient to also audit operations at a higher level (shutil, subprocess, etc.)

[issue39184] Many command execution functions are not raising auditing events

Change by STINNER Victor : -- nosy: +steve.dower ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39184] Many command execution functions are not raising auditing events

New submission from Saiyang Gou : Similar to `os.system` (which is already raising auditing event), the following functions are also capable of command execution, so they also need auditing: - os.execl - os.execle - os.execlp - os.execlpe - os.execv - os.execve - os.execvp - os.execvpe -