[issue39305] Merge nntplib._NNTPBase and nntplib.NNTP

STINNER Victor added the comment: Thanks, that's a nice simplification of the code ;-) -- ___ Python tracker ___ ___

[issue39305] Merge nntplib._NNTPBase and nntplib.NNTP

Dong-hee Na added the comment: I am no closing this issue :) Thank you for the suggestion, Victor. And also thank you for the interest in this issue, Luciana :) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___

[issue39305] Merge nntplib._NNTPBase and nntplib.NNTP

Dong-hee Na added the comment: New changeset aa92a7cf210c98ad94229f282221136d846942db by Dong-hee Na in branch 'master': bpo-39305: Update nntplib to merge nntplib.NNTP and nntplib._NNTPBase (GH-19817) https://github.com/python/cpython/commit/aa92a7cf210c98ad94229f282221136d846942db

[issue39305] Merge nntplib._NNTPBase and nntplib.NNTP

Change by Dong-hee Na : -- pull_requests: +19137 pull_request: https://github.com/python/cpython/pull/19817 ___ Python tracker ___

[issue39305] Merge nntplib._NNTPBase and nntplib.NNTP

Luciana added the comment: I just uploaded the PR, please take a look when you have a chance :) I did my best trying to come up with a good code. -- ___ Python tracker ___

[issue39305] Merge nntplib._NNTPBase and nntplib.NNTP

Change by Roundup Robot : -- keywords: +patch pull_requests: +17439 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18045 ___ Python tracker ___

[issue39305] Merge nntplib._NNTPBase and nntplib.NNTP

Luciana added the comment: Thank you, I am creating the patch now and will submit it later today! -- ___ Python tracker ___ ___

[issue39305] Merge nntplib._NNTPBase and nntplib.NNTP

Dong-hee Na added the comment: @lucianamarques Good news, if you submit the patch. Please ping me and @vstinner :) -- ___ Python tracker ___

[issue39305] Merge nntplib._NNTPBase and nntplib.NNTP

Luciana added the comment: Hey, I'm taking a look into this! -- nosy: +lucianamarques ___ Python tracker ___ ___ Python-bugs-list

[issue39305] Merge nntplib._NNTPBase and nntplib.NNTP

New submission from Dong-hee Na : See: https://github.com/python/cpython/pull/17939#pullrequestreview-341290152 There was partial refactoring through PR 17939. I and Victor think that nntplib._NNTPBase can be removed by merging nntplib._NNTPBase and nntplib.NNTP. The only care point would be