[issue39359] zipfile: add missing "pwd: expected bytes, got str" exception message

Daniel Hillier added the comment: I agree it is bad form but I would accidentally do it when I couldn't remember the proper API and took a stab in the dark without looking up the docs. I unfortunately used it in an example in the docs for pyzipper and started getting a few bug reports even

[issue39359] zipfile: add missing "pwd: expected bytes, got str" exception message

Serhiy Storchaka added the comment: Why do you set the ZipFile.pwd attribute directly? -- ___ Python tracker ___ ___

[issue39359] zipfile: add missing "pwd: expected bytes, got str" exception message

Daniel Hillier added the comment: Thanks Łukasz! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39359] zipfile: add missing "pwd: expected bytes, got str" exception message

Łukasz Langa added the comment: Thanks, Daniel! ✨  ✨ -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.11 -Python 3.7, Python 3.8, Python 3.9 ___ Python tracker

[issue39359] zipfile: add missing "pwd: expected bytes, got str" exception message

Łukasz Langa added the comment: New changeset 91099e25446b214725f8e2bec6f90553260c by Daniel Hillier in branch 'main': bpo-39359: [zipfile] add missing "pwd: expected bytes, got str" exception (GH-18031) https://github.com/python/cpython/commit/91099e25446b214725f8e2bec6f90553260c

[issue39359] zipfile: add missing "pwd: expected bytes, got str" exception message

Change by Cheryl Sabella : -- nosy: +serhiy.storchaka, twouters ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue39359] zipfile: add missing "pwd: expected bytes, got str" exception message

Change by Daniel Hillier : -- keywords: +patch pull_requests: +17427 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18031 ___ Python tracker ___

[issue39359] zipfile: add missing "pwd: expected bytes, got str" exception message

New submission from Daniel Hillier : Setting the ZipFile.pwd attribute directly skips the check to ensure the password is a bytes object and, if not, return a user friendly TypeError("pwd: expected bytes, got ") informing them of that. -- components: Library (Lib) messages: 360118