[issue39366] Remove deprecated nntplib method

[Berker Peksag]

Berker Peksag  added the comment:

Thanks for the PR! I'm glad these previously deprecated functions are now gone.

--
components: +Library (Lib)
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
type:  -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39366] Remove deprecated nntplib method

[Berker Peksag]

Berker Peksag  added the comment:


New changeset 1f0f102dec506fd06f912b74dd2be64a7fba0d3f by Berker Peksag 
(Dong-hee Na) in branch 'master':
bpo-39366: Remove xpath() and xgtitle() methods of NNTP (GH-18035)
https://github.com/python/cpython/commit/1f0f102dec506fd06f912b74dd2be64a7fba0d3f


--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39366] Remove deprecated nntplib method

[STINNER Victor]

STINNER Victor  added the comment:

>>> a.description('gmane.comp.python.committers')
'CPython Committers (non-public) (Moderated)'
>>> a.descriptions('gmane.comp.python.committers')
('215 Newsgroup descriptions in form "group description"', 
{'gmane.comp.python.committers': 'CPython Committers (non-public) (Moderated)'})

Well, both results contain the same important string: 'CPython Committers 
(non-public) (Moderated)'. So I think that it's ok to drop xgtitle() as well.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39366] Remove deprecated nntplib method

[Dong-hee Na]

Dong-hee Na  added the comment:

> Does 
> https://docs.python.org/dev/library/nntplib.html#nntplib.NNTP.description 
> give the same result?

Not exactly same but descriptions give a similar result.

>>> import nntplib
>>> a = nntplib.NNTP('news.gmane.io')
>>> a.description('gmane.comp.python.committers')
'CPython Committers (non-public) (Moderated)'
>>> a.descriptions('gmane.comp.python.committers')
('215 Newsgroup descriptions in form "group description"', 
{'gmane.comp.python.committers': 'CPython Committers (non-public) (Moderated)'})
>>> a.xgtitle('gmane.comp.python.committers')
:1: DeprecationWarning: The XGTITLE extension is not actively used, use 
descriptions() instead
('282 Descriptions in form "group description"', 
[('gmane.comp.python.committers', 'CPython Committers (non-public) 
(Moderated)')])

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39366] Remove deprecated nntplib method

[STINNER Victor]

STINNER Victor  added the comment:

>>> a.xgtitle('gmane.comp.python.committers')
('282 Descriptions in form "group description"', 
[('gmane.comp.python.committers', 'CPython Committers (non-public) 
(Moderated)')])

Does https://docs.python.org/dev/library/nntplib.html#nntplib.NNTP.description 
give the same result?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39366] Remove deprecated nntplib method

[Dong-hee Na]

Dong-hee Na  added the comment:

Looks like xgtitle is supported but xpath is not.

>>> a.xgtitle('gmane.comp.python.committers')
('282 Descriptions in form "group description"', 
[('gmane.comp.python.committers', 'CPython Committers (non-public) 
(Moderated)')])
>>> a.xpath(message_id)
Traceback (most recent call last):
  File "", line 1, in 
  File 
"/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/nntplib.py", 
line 865, in xpath
resp = self._shortcmd('XPATH {0}'.format(id))
  File 
"/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/nntplib.py", 
line 513, in _shortcmd
return self._getresp()
  File 
"/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/nntplib.py", 
line 458, in _getresp
raise NNTPPermanentError(resp)
nntplib.NNTPPermanentError: 500 What?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39366] Remove deprecated nntplib method

[STINNER Victor]

STINNER Victor  added the comment:

I'm not used to the NNTP protocol. Does the news.gmane.io support these 2 
extensions?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39366] Remove deprecated nntplib method

[Dong-hee Na]

Change by Dong-hee Na :


--
keywords: +patch
pull_requests: +17432
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/18035

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39366] Remove deprecated nntplib method

[Dong-hee Na]

New submission from Dong-hee Na :

Remove deprecated methods since Python 3.3.
Moreover nntplib.NNTP.xgtitle has not been exposed through docs.python.org
https://docs.python.org/3/library/nntplib.html

--
assignee: corona10
messages: 360163
nosy: corona10, vstinner
priority: normal
severity: normal
status: open
title: Remove deprecated nntplib method
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com