[issue39837] Remove Azure Pipelines from GitHub PRs

STINNER Victor added the comment: Another issue: I still see "Azure Pipelines PR Expected — Waiting for status to be reported" 15 min after I created my PR :-/ Technically, I created the PR and then pushed a second commit to the PR. The only option is to close/reopen the PR to re-trigger

[issue39837] Remove Azure Pipelines from GitHub PRs

hai shi added the comment: > Sadly (again), closing/reopening a PR re-runs all CIs. At the first run, GH > Action macOS job passed. At the second run, the "Tests" step of GH Action > macOS job, but I'm clueless with its logs: (...) Oh, I encountered the same trouble twice :(

[issue39837] Remove Azure Pipelines from GitHub PRs

STINNER Victor added the comment: > Sadly (again), closing/reopening a PR re-runs all CIs. At the first run, GH > Action macOS job passed. At the second run, the "Tests" step of GH Action > macOS job, but I'm clueless with its logs: (...) Oops, I looked at two different PRs. In fact, the

[issue39837] Remove Azure Pipelines from GitHub PRs

STINNER Victor added the comment: > Sadly, I had to close/reopen my PR since there is no button to only restart > the failure job, or even restart all Azure Pipeline jobs. This retrigger all > CI jobs :-( Sadly (again), closing/reopening a PR re-runs all CIs. At the first run, GH Action

[issue39837] Remove Azure Pipelines from GitHub PRs

STINNER Victor added the comment: Another Azure Pipeline failure on my https://github.com/python/cpython/pull/19769 PR, it looks like a random networking failure. Sadly, I had to close/reopen my PR since there is no button to only restart the failure job, or even restart all Azure Pipeline

[issue39837] Remove Azure Pipelines from GitHub PRs

STINNER Victor added the comment: > There is another issue: sometimes, the Ubuntu VM fails to download .deb from > azure.archive.ubuntu.com. I created bpo-40188: "Azure Pipelines jobs failing randomly with: Unable to connect to azure.archive.ubuntu.com". --

[issue39837] Remove Azure Pipelines from GitHub PRs

Brett Cannon added the comment: > I'm not aware of Travis CI current issue. There were issues in the past, as > with any CI, right ;-) Travis CI looks quite reliable these days. That's what everyone said when Travis was required and before it went flaky the last time. ;) The point is I

[issue39837] Remove Azure Pipelines from GitHub PRs

Steve Dower added the comment: > I don't understand how it's possible that the Ubuntu job passed in the GitHub > action, but failed in Azure Pipelines. Random network issues, most likely. Those are about the only flakiness I've seen in recent times. The OpenSSL cache should only be for the

[issue39837] Remove Azure Pipelines from GitHub PRs

STINNER Victor added the comment: > About the "Install Dependencies" issue, I created bpo-40146: "Upgrade Azure > Pipelines to OpenSSL 1.1.1f". I fixed this issue. There is another issue: sometimes, the Ubuntu VM fails to download .deb from azure.archive.ubuntu.com. Example:

[issue39837] Remove Azure Pipelines from GitHub PRs

STINNER Victor added the comment: About the "Install Dependencies" issue, I created bpo-40146: "Upgrade Azure Pipelines to OpenSSL 1.1.1f". I don't understand how it's possible that the Ubuntu job passed in the GitHub action, but failed in Azure Pipelines. Maybe there was a download cache

[issue39837] Remove Azure Pipelines from GitHub PRs

STINNER Victor added the comment: > Yes, but I don't want to to do that as we have had equivalent flakiness > issues with Travis which is why it isn't required ATM. I'm not aware of Travis CI current issue. There were issues in the past, as with any CI, right ;-) Travis CI looks quite

[issue39837] Remove Azure Pipelines from GitHub PRs

Steve Dower added the comment: Or we could remove the path filter on GitHub Actions so that all checks run even for doc-only changes? Then they can be marked as required. -- ___ Python tracker

[issue39837] Remove Azure Pipelines from GitHub PRs

Brett Cannon added the comment: > Is it possible to make Travis CI required and make Azure Pipelines not > required? Yes, but I don't want to to do that as we have had equivalent flakiness issues with Travis which is why it isn't required ATM. The only way to prevent flaky CI from blocking

[issue39837] Remove Azure Pipelines from GitHub PRs

STINNER Victor added the comment: I cannot merge a PR until it completes. It re-runs jobs which are already run as GH Actions. There is another annoying issue with Azure Pipelines. When a job fails randomly for whatever reason, a job cannot be re-run, even if I log in Microsoft Azure.

[issue39837] Remove Azure Pipelines from GitHub PRs

Ned Deily added the comment: New changeset b092892f9afd37fd3355b1e91fc5835f196ea914 by Ned Deily (Miss Islington (bot)) in branch '3.7': bpo-39837: Disable macOS tests on Azure Pipelines (GH-18818) https://github.com/python/cpython/commit/b092892f9afd37fd3355b1e91fc5835f196ea914 --

[issue39837] Remove Azure Pipelines from GitHub PRs

Change by Roundup Robot : -- nosy: +python-dev nosy_count: 4.0 -> 5.0 pull_requests: +18192 pull_request: https://github.com/python/cpython/pull/18835 ___ Python tracker ___

[issue39837] Remove Azure Pipelines from GitHub PRs

miss-islington added the comment: New changeset d692d52f4aaeb6feaabb18f18d49907dd578fbeb by Miss Islington (bot) in branch '3.8': bpo-39837: Disable macOS tests on Azure Pipelines (GH-18818) https://github.com/python/cpython/commit/d692d52f4aaeb6feaabb18f18d49907dd578fbeb --

[issue39837] Remove Azure Pipelines from GitHub PRs

miss-islington added the comment: New changeset 47b7c227048f2cb019cc3ec2fef7e867f1b232f3 by Miss Islington (bot) in branch '3.7': bpo-39837: Disable macOS tests on Azure Pipelines (GH-18818) https://github.com/python/cpython/commit/47b7c227048f2cb019cc3ec2fef7e867f1b232f3 --

[issue39837] Remove Azure Pipelines from GitHub PRs

Steve Dower added the comment: I've disabled macOS builds on Pipelines, so now they're essentially advisory through the GitHub Actions build. I also pinged some contacts about the not-very-useful behaviour of required checks vs. path filters. So will see what they say. -- versions:

[issue39837] Remove Azure Pipelines from GitHub PRs

Change by miss-islington : -- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +18178 pull_request: https://github.com/python/cpython/pull/18820 ___ Python tracker

[issue39837] Remove Azure Pipelines from GitHub PRs

Change by miss-islington : -- pull_requests: +18179 pull_request: https://github.com/python/cpython/pull/18821 ___ Python tracker ___

[issue39837] Remove Azure Pipelines from GitHub PRs

Steve Dower added the comment: New changeset 31350f9af09dcff7cf6ff4b0a0a7ea595942372e by Steve Dower in branch 'master': bpo-39837: Disable macOS tests on Azure Pipelines (GH-18818) https://github.com/python/cpython/commit/31350f9af09dcff7cf6ff4b0a0a7ea595942372e --

[issue39837] Remove Azure Pipelines from GitHub PRs

Change by Steve Dower : -- pull_requests: +18176 pull_request: https://github.com/python/cpython/pull/18818 ___ Python tracker ___

[issue39837] Remove Azure Pipelines from GitHub PRs

Steve Dower added the comment: It would make the job definition significantly more complicated, and I don't want to do that just to work around an issue with github until we've got positive confirmation that the behaviour is intentional and won't change. --

[issue39837] Remove Azure Pipelines from GitHub PRs

Brett Cannon added the comment: I've turned off the required checks for GH Actions and flipped Azure Pipelines back on. And to answer Victor's question, yes, you can make things conditional at the workflow, job, and job step level. I don't know what would happen if the check was moved from

[issue39837] Remove Azure Pipelines from GitHub PRs

Steve Dower added the comment: Adding a screenshot here so I can point people at it. Let's not rush into complicating the build steps yet - AP is basically fine. We should switch back the required checks (@Brett?) If anything, let's add a "condition: false" to the macOS build to disable it

[issue39837] Remove Azure Pipelines from GitHub PRs

STINNER Victor added the comment: Instead of not running the job, is it technically possible to modify the jobs to do nothing for docs only changes? .travis.yml works like that: before_install: - set -e - | # Check short-circuit conditions if [[ "${TESTING}" != "docs" &&

[issue39837] Remove Azure Pipelines from GitHub PRs

Steve Dower added the comment: Looks like it isn't fixed... https://github.com/python/cpython/pull/18774 -- ___ Python tracker ___

[issue39837] Remove Azure Pipelines from GitHub PRs

Brett Cannon added the comment: It was an old issue that if required checks didn't run it would block, but hopefully it's fixed. :) I have gone ahead and removed the Azure Pipelines requirement from 3.7, 3.8, and master and flipped on the check requirements for the ones I listed.

[issue39837] Remove Azure Pipelines from GitHub PRs

Steve Dower added the comment: Are you sure the required check isn't just for failures? Surely GitHub is smarter than requiring checks that it can tell aren't required (as it's their logic to include/exclude, not ours). If they're not, I now have many internal contacts there, so we can

[issue39837] Remove Azure Pipelines from GitHub PRs

Brett Cannon added the comment: Actually, I just realized we can't make these status checks required because they don't always run. :) Our Actions are smart enough to not run when they aren't necessary, i.e. doc changes don't run the rest of the checks. And so making the OS-specific tests

[issue39837] Remove Azure Pipelines from GitHub PRs

STINNER Victor added the comment: > And to answer Victor's question on the PR that he closed, we can make any > individual status check required. Great! I saw a macOS failure this week which was caused by an internal CI error. I hope that it will be fixed soon. In the meanwhile, I would

[issue39837] Remove Azure Pipelines from GitHub PRs

Steve Dower added the comment: There's no PR required. We need to change the required check so when I disable new builds from running it won't break existing PRs. As for actually changing the files in the repo, I don't see any hurry there. We can clean up a few of them, and maybe I can move

[issue39837] Remove Azure Pipelines from GitHub PRs

Brett Cannon added the comment: Yes, I can do it. And to answer Victor's question on the PR that he closed, we can make any individual status check required. So probably: - Docs - Ubuntu - Windows x86 - Windows x64 Just let me know when we are ready to merge a PR and I will switch off

[issue39837] Remove Azure Pipelines from GitHub PRs

Steve Dower added the comment: > Who is allowed to do that? Brett did it the first time. I'm having too much trouble with GitHub right now to find the current admins. -- nosy: +brett.cannon ___ Python tracker

[issue39837] Remove Azure Pipelines from GitHub PRs

STINNER Victor added the comment: > PR 18769 should *not* be merged. Ok, I closed it. > First, it needs to be changed to a non-required check. Who is allowed to do that? -- ___ Python tracker

[issue39837] Remove Azure Pipelines from GitHub PRs

Steve Dower added the comment: Deleting the files is not the right first step. First, it needs to be changed to a non-required check. Then, I can use the web UI to disable it starting. *Then*, we can remove *some* of the files in the directory. Others are used for the official release, and

[issue39837] Remove Azure Pipelines from GitHub PRs

Change by Brett Cannon : -- nosy: +steve.dower ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39837] Remove Azure Pipelines from GitHub PRs

Change by STINNER Victor : -- keywords: +patch pull_requests: +18128 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18769 ___ Python tracker ___

[issue39837] Remove Azure Pipelines from GitHub PRs

New submission from STINNER Victor : The Azure Pipelines jobs have been reimplemented as GitHub actions which are better integrated with GitHub: * Docs / Docs (pull_request) * Tests / Windows (x64) (pull_request) * Tests / macOS (pull_request) * Tests / Ubuntu (pull_request) * etc. Azure