[issue39852] IDLE: Goto should remove selection and update the status bar

Terry J. Reedy added the comment: https://github.com/python/devguide/issues/577 -- ___ Python tracker ___ ___ Python-bugs-list

[issue39852] IDLE: Goto should remove selection and update the status bar

Guido van Rossum added the comment: I guess it's similar to the 'return' vs. 'returns' issue, but I feel much stronger about it here. I would have written that as "make the spam module more spammy". Just read a bunch of commits using e.g. `git log --oneline` to see what the prevailing style

[issue39852] IDLE: Goto should remove selection and update the status bar

Terry J. Reedy added the comment: Is it the temporal ambiguity (fixed by adding 'now', which is in the blurbs) or the descriptive versus command style (as with 'Returns' versus 'Return') that you do not like? If the latter, the devguide could use augmentation. The only relevant 'guidance'

[issue39852] IDLE: Goto should remove selection and update the status bar

Guido van Rossum added the comment: I have a nit on the commit message used here (and also in issue 39885). *Please* don't use this style of commit message "IDLE context menu clears selection". That phrasing sounds like it is the description of a bug. Please always use a phrasing that makes

[issue39852] IDLE: Goto should remove selection and update the status bar

miss-islington added the comment: New changeset ec61f53243a4455f41e37a5c645e668661952c28 by Miss Islington (bot) in branch '3.7': bpo-39852: IDLE 'Go to line' deletes selection, updates status (GH-18801) https://github.com/python/cpython/commit/ec61f53243a4455f41e37a5c645e668661952c28

[issue39852] IDLE: Goto should remove selection and update the status bar

Change by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue39852] IDLE: Goto should remove selection and update the status bar

miss-islington added the comment: New changeset a5e821c7269ebed6e8b4b4eee3f2247ec41a9788 by Miss Islington (bot) in branch '3.8': bpo-39852: IDLE 'Go to line' deletes selection, updates status (GH-18801) https://github.com/python/cpython/commit/a5e821c7269ebed6e8b4b4eee3f2247ec41a9788

[issue39852] IDLE: Goto should remove selection and update the status bar

Change by miss-islington : -- pull_requests: +18215 pull_request: https://github.com/python/cpython/pull/18858 ___ Python tracker ___

[issue39852] IDLE: Goto should remove selection and update the status bar

Change by miss-islington : -- nosy: +miss-islington nosy_count: 2.0 -> 3.0 pull_requests: +18214 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/18857 ___ Python tracker

[issue39852] IDLE: Goto should remove selection and update the status bar

Terry J. Reedy added the comment: New changeset 2522db11df102be3baf25ce9e816ebe8ffdb7fcc by Terry Jan Reedy in branch 'master': bpo-39852: IDLE 'Go to line' deletes selection, updates status (GH-18801) https://github.com/python/cpython/commit/2522db11df102be3baf25ce9e816ebe8ffdb7fcc

[issue39852] IDLE: Goto should remove selection and update the status bar

Terry J. Reedy added the comment: Agreed about right clicks. See new issue #39885. -- ___ Python tracker ___ ___ Python-bugs-list

[issue39852] IDLE: Goto should remove selection and update the status bar

Dave Liptack added the comment: Like goto, right-click also exhibits this behavior. Should selection_clear also be added to right-click code? -- ___ Python tracker ___

[issue39852] IDLE: Goto should remove selection and update the status bar

Terry J. Reedy added the comment: I am expanding this issue to include the part of #27115 that the PR will fix. (I will also change the scope of the latter). -- stage: patch review -> needs patch title: IDLE: Goto should remove any selection -> IDLE: Goto should remove selection