[issue39868] Stale Python Language Reference docs (no walrus).

Guido van Rossum added the comment: Congratulations SHANKAR JHA. Thank you for your contribution. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10, Python 3.9 ___ Python tracker

[issue39868] Stale Python Language Reference docs (no walrus).

miss-islington added the comment: New changeset 616734b6c80e222f16249e9a9ce52588a0b611a7 by Miss Islington (bot) in branch '3.9': bpo-39868: Add documentation for Assignment Expressions (walrus, PEP 572) (GH-18851)

[issue39868] Stale Python Language Reference docs (no walrus).

miss-islington added the comment: New changeset 755cb49429581679fc7b12905cb3d3ecf439032c by Miss Islington (bot) in branch '3.8': bpo-39868: Add documentation for Assignment Expressions (walrus, PEP 572) (GH-18851)

[issue39868] Stale Python Language Reference docs (no walrus).

Change by miss-islington : -- pull_requests: +20764 pull_request: https://github.com/python/cpython/pull/21623 ___ Python tracker ___

[issue39868] Stale Python Language Reference docs (no walrus).

Change by miss-islington : -- pull_requests: +20763 pull_request: https://github.com/python/cpython/pull/21622 ___ Python tracker ___

[issue39868] Stale Python Language Reference docs (no walrus).

Guido van Rossum added the comment: New changeset f117cef25b5ffc4db9fbe373ddb65e14f59f0397 by Shankar Jha in branch 'master': bpo-39868: Add documentation for Assignment Expressions (walrus, PEP 572) (#18851) https://github.com/python/cpython/commit/f117cef25b5ffc4db9fbe373ddb65e14f59f0397

[issue39868] Stale Python Language Reference docs (no walrus).

Change by SHANKAR JHA : -- keywords: +patch pull_requests: +18213 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18851 ___ Python tracker ___

[issue39868] Stale Python Language Reference docs (no walrus).

SHANKAR JHA added the comment: I have added the pull request: https://github.com/python/cpython/pull/18851. Please check it out and let me know if I need to change anything. Thank you everyone for your guidance. -- ___ Python tracker

[issue39868] Stale Python Language Reference docs (no walrus).

Brandt Bucher added the comment: > I have created my draft with an example but I am confused about where exactly > do I have to add the code and push it. > I have cloned these two repositories in my system and setup everything: > https://github.com/python/cpython >

[issue39868] Stale Python Language Reference docs (no walrus).

SHANKAR JHA added the comment: I have created my draft with an example but I am confused about where exactly do I have to add the code and push it. I have cloned these two repositories in my system and setup everything: https://github.com/python/cpython https://github.com/python/devguide 1.

[issue39868] Stale Python Language Reference docs (no walrus).

Brandt Bucher added the comment: Great. Just replacing the TODO line with your new description (and maybe an example) should be perfect! -- keywords: -patch stage: patch review -> ___ Python tracker

[issue39868] Stale Python Language Reference docs (no walrus).

SHANKAR JHA added the comment: I got it that I have to fill the "Assignment expression" section in the code. I am working on it and send you the for review once I am done. -- ___ Python tracker

[issue39868] Stale Python Language Reference docs (no walrus).

SHANKAR JHA added the comment: I am also checking your commit for this: (https://github.com/python/cpython/commit/8bae21962bab2fac7630982abd73676b89930902) and see that you are changing the "expression: to "assignment_expression". Do I have to fill what assignment expression does with some

[issue39868] Stale Python Language Reference docs (no walrus).

SHANKAR JHA added the comment: Thank you for helping me out brandtbucher. As per my understanding, I am looking into the code (https://github.com/python/cpython/blob/master/Doc/reference/expressions.rst) and finding where the code doesn't follow the pattern described in

[issue39868] Stale Python Language Reference docs (no walrus).

Brandt Bucher added the comment: Thanks for offering to help, Shankar! For this change, you can look at the other sections of the Doc/reference/expressions.rst file for an idea of what we're looking for. I think a few sentences and maybe a small code snippet should probably be fine. The

[issue39868] Stale Python Language Reference docs (no walrus).

miss-islington added the comment: New changeset 0c717709c1b19b6f146b56db5f10bab3f09c by Miss Islington (bot) in branch '3.8': bpo-39868: Update Language Reference for PEP 572. (GH-18793) https://github.com/python/cpython/commit/0c717709c1b19b6f146b56db5f10bab3f09c --

[issue39868] Stale Python Language Reference docs (no walrus).

Guido van Rossum added the comment: New changeset 8bae21962bab2fac7630982abd73676b89930902 by Brandt Bucher in branch 'master': bpo-39868: Update Language Reference for PEP 572. (#18793) https://github.com/python/cpython/commit/8bae21962bab2fac7630982abd73676b89930902 -- nosy:

[issue39868] Stale Python Language Reference docs (no walrus).

Change by miss-islington : -- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +18153 pull_request: https://github.com/python/cpython/pull/18797 ___ Python tracker

[issue39868] Stale Python Language Reference docs (no walrus).

SHANKAR JHA added the comment: This is my first contribution to Python. This is why I am looking for some guidance, just point me to some resource, and then I will look into it thoroughly. I am reading this https://www.python.org/dev/peps/pep-0572/ for better understanding. --

[issue39868] Stale Python Language Reference docs (no walrus).

Brandt Bucher added the comment: Of course. After my PR is merged, you can make another PR that replaces the ".. TODO: BPO-39868" line with a description of how assignment expressions work. Likely much of the language can be borrowed from the PEP. Let me know if you need help with any of

[issue39868] Stale Python Language Reference docs (no walrus).

SHANKAR JHA added the comment: Thank you for that!!! Can you please provide some pointers to what exactly I have to do? -- ___ Python tracker ___

[issue39868] Stale Python Language Reference docs (no walrus).

Change by Brandt Bucher : -- keywords: +patch pull_requests: +18151 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18793 ___ Python tracker ___

[issue39868] Stale Python Language Reference docs (no walrus).

Brandt Bucher added the comment: Sorry, I hadn't seen your comment... :( I've already finished the grammar specification bit, but not the prose description of how assignment expressions work, etc. How about I leave that empty in my PR and you can actually do the documentation part

[issue39868] Stale Python Language Reference docs (no walrus).

SHANKAR JHA added the comment: Can I take this issue? -- nosy: +shankarj67 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue39868] Stale Python Language Reference docs (no walrus).

New submission from Brandt Bucher : It looks like https://docs.python.org/3/reference/expressions.html and https://docs.python.org/3/reference/compound_stmts.html were never updated for named expressions. Because this change has to be backported, it's sort of a blocker for my PEP 614 doc