[issue39873] Debug mode: check if objects are valid

2020-03-25 Thread STINNER Victor
STINNER Victor added the comment: This change was mostly an experimentation. But I'm not sure that it does solve any issue. The change is more intrusive than what I expected. I prefer to abandon PR 18803 and this issue. -- resolution: -> rejected stage: patch review -> resolved

[issue39873] Debug mode: check if objects are valid

2020-03-06 Thread STINNER Victor
STINNER Victor added the comment: New changeset 9a73705a1d0cb8b89d0a20add2ffa2c4d32950ed by Victor Stinner in branch 'master': bpo-39873: Cleanup _PyObject_CheckConsistency() (GH-18807) https://github.com/python/cpython/commit/9a73705a1d0cb8b89d0a20add2ffa2c4d32950ed --

[issue39873] Debug mode: check if objects are valid

2020-03-06 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +18165 pull_request: https://github.com/python/cpython/pull/18807 ___ Python tracker ___

[issue39873] Debug mode: check if objects are valid

2020-03-06 Thread STINNER Victor
STINNER Victor added the comment: New changeset 1fb5a9f394a6fdf62e21b96080c3257c959cf8c9 by Victor Stinner in branch 'master': bpo-39873: PyObject_Init() uses PyObject_INIT() (GH-18804) https://github.com/python/cpython/commit/1fb5a9f394a6fdf62e21b96080c3257c959cf8c9 --

[issue39873] Debug mode: check if objects are valid

2020-03-06 Thread STINNER Victor
Change by STINNER Victor : -- nosy: +inada.naoki, pablogsal, serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing

[issue39873] Debug mode: check if objects are valid

2020-03-06 Thread STINNER Victor
STINNER Victor added the comment: See also bpo-38392: "Ensure that objects entering the GC are valid". I fixed this one with commit 1b1845569539db5c1a6948a5d32daea381f1e35f. -- ___ Python tracker

[issue39873] Debug mode: check if objects are valid

2020-03-06 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +18160 pull_request: https://github.com/python/cpython/pull/18804 ___ Python tracker ___

[issue39873] Debug mode: check if objects are valid

2020-03-06 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +18159 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18803 ___ Python tracker ___

[issue39873] Debug mode: check if objects are valid

2020-03-06 Thread STINNER Victor
New submission from STINNER Victor : One of the worst issue that I had to debug is a crash in the Python garbage collector. It is usually a crash in visit_decref(). See my notes: https://pythondev.readthedocs.io/debug_tools.html#debug-crash-in-garbage-collection-visit-decref My previous